From: pramod gurav <pramod.gurav.etc@gmail.com>
To: divya ojha <odivya77@gmail.com>
Cc: "Ivan T. Ivanov" <iivanov@mm-sol.com>,
Linus Walleij <linus.walleij@linaro.org>,
Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
Grant Likely <grant.likely@linaro.org>,
Bjorn Andersson <bjorn.andersson@sonymobile.com>,
Mark Brown <broonie@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
linux-arm-msm <linux-arm-msm@vger.kernel.org>
Subject: Re: [PATCH v2 2/4] pinctrl: qpnp: Qualcomm PMIC pin controller driver
Date: Mon, 21 Jul 2014 21:45:29 +0530 [thread overview]
Message-ID: <CAMf-jSmGE9_buYv1EjYPhzQXC4ke8hb7cp1mpGSjvSUhnoDnjg@mail.gmail.com> (raw)
In-Reply-To: <CADsdr6Pwa+Vzugy7_-yWePmT6Wj5bpJRDq=qq2KLdG2woioY4g@mail.gmail.com>
On Mon, Jul 21, 2014 at 9:32 PM, divya ojha <odivya77@gmail.com> wrote:
> Hi,
>
> On Thu, Jul 17, 2014 at 8:55 PM, Ivan T. Ivanov <iivanov@mm-sol.com> wrote:
>> From: "Ivan T. Ivanov" <iivanov@mm-sol.com>
>>
>> This is the pinctrl, pinmux, pinconf and gpiolib driver for the
>> Qualcomm GPIO and MPP sub-function blocks found in the PMIC chips.
>>
>> Signed-off-by: Ivan T. Ivanov <iivanov@mm-sol.com>
>> ---
>> drivers/pinctrl/Kconfig | 12 +
>> drivers/pinctrl/Makefile | 1 +
>> drivers/pinctrl/pinctrl-qpnp.c | 1565 +++++++++++++++++++++++++
>> include/dt-bindings/pinctrl/qcom,pm8xxx-mpp.h | 34 +
> ..
> + struct device *dev = qctrl->dev;
>> + struct pinctrl_pin_desc *desc, *descs;
>> + struct qpnp_padinfo *pad, *pads;
>> + int idx, ret, cnt, gps, ais, aos, css;
>> + const char **names, *format;
>> + unsigned int addr;
>> +
>> + pads = devm_kcalloc(dev, qchip->npads, sizeof(*pads), GFP_KERNEL);
>
> when do we free these structures..?
>
devm_kmalloc is the function that is called in the end. Memory
allocated with this API will be automatically released after device
exit.
Read http://lxr.free-electrons.com/source/drivers/base/devres.c#L774 for more.
>> + if (!pads)
>> + return -ENOMEM;
>> +
>> + descs = devm_kcalloc(dev, qchip->npads, sizeof(*descs), GFP_KERNEL);
>
> ditto..
>
>> + if (!descs)
>> + return -ENOMEM;
>> +
> ..
>> + cnt = qctrl->groups[idx].npins;
>> + if (!cnt)
>> + continue;
>> +
>> + names = devm_kcalloc(dev, cnt, sizeof(names), GFP_KERNEL);
>
> ditto..
>
>> + if (!names)
>> + return -ENOMEM;
>
>> +#define PM8XXX_MPP_AIN_ABUS4 7
>> +
>> +#endif
>> --
>> 1.8.3.2
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
>
> Regards
> Divya
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
--
Thanks and Regards
Pramod
next prev parent reply other threads:[~2014-07-21 16:15 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-17 15:25 [PATCH v2 0/4] New Qualcomm PMIC pin controller drivers Ivan T. Ivanov
2014-07-17 15:25 ` [PATCH v2 2/4] pinctrl: qpnp: Qualcomm PMIC pin controller driver Ivan T. Ivanov
2014-07-21 11:29 ` kiran.padwal
2014-07-21 16:02 ` divya ojha
2014-07-21 16:15 ` pramod gurav [this message]
2014-07-21 16:16 ` Ivan T. Ivanov
2014-07-23 15:27 ` Linus Walleij
2014-07-23 16:11 ` Ivan T. Ivanov
2014-07-26 1:43 ` David Collins
2014-07-28 8:39 ` Ivan T. Ivanov
2014-08-05 1:36 ` Stephen Boyd
2014-08-05 11:55 ` Ivan T. Ivanov
2014-07-17 15:25 ` [PATCH v2 3/4] pinctrl: qcom: Add documentation for pinctrl-qpnp driver bindings Ivan T. Ivanov
2014-07-17 15:25 ` [PATCH v2 4/4] ARM: dts: qcom: Add PM8941 and PM8841 pinctrl nodes Ivan T. Ivanov
2014-07-17 19:41 ` [PATCH RESEND v2 1/4] pinctrl: Update Qualcomm pm8xxx GPIO parameters definitions Ivan T. Ivanov
2014-07-22 14:51 ` Ivan T. Ivanov
2014-07-22 21:46 ` Bjorn Andersson
2014-07-23 12:47 ` Ivan T. Ivanov
2014-07-23 16:05 ` Ivan T. Ivanov
2014-07-23 21:46 ` Stephen Boyd
2014-07-23 23:47 ` Stephen Boyd
2014-07-24 15:40 ` Linus Walleij
2014-07-25 0:23 ` Stephen Boyd
2014-07-25 11:29 ` Linus Walleij
2014-07-25 15:15 ` Ivan T. Ivanov
2014-08-06 15:02 ` Ivan T. Ivanov
2014-08-11 5:40 ` Bjorn Andersson
2014-07-23 12:47 ` [PATCH v2 0/4] New Qualcomm PMIC pin controller drivers Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMf-jSmGE9_buYv1EjYPhzQXC4ke8hb7cp1mpGSjvSUhnoDnjg@mail.gmail.com \
--to=pramod.gurav.etc@gmail.com \
--cc=bjorn.andersson@sonymobile.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=grant.likely@linaro.org \
--cc=iivanov@mm-sol.com \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=odivya77@gmail.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).