From: Fritz Koenig <frkoenig@chromium.org>
To: Stanimir Varbanov <stanimir.varbanov@linaro.org>
Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org,
Vikash Garodia <vgarodia@codeaurora.org>,
Alexandre Courbot <acourbot@chromium.org>,
Fritz Koenig <frkoenig@chromium.org>
Subject: Re: [PATCH v2 1/8] venus: hfi: Use correct state in unload resources
Date: Sat, 28 Nov 2020 22:02:08 -0800 [thread overview]
Message-ID: <CAMfZQbx5j+c3HQBjaT45ur_6r6Nm3tsRji8D0f_EtLJF_CFiyw@mail.gmail.com> (raw)
In-Reply-To: <20201111143755.24541-2-stanimir.varbanov@linaro.org>
On Wed, Nov 11, 2020 at 6:38 AM Stanimir Varbanov
<stanimir.varbanov@linaro.org> wrote:
>
> INST_RELEASE_RESOURCES state is set but not used, correct this
> by enter into INIT state once the unload resources is done.
>
> Signed-off-by: Stanimir Varbanov <stanimir.varbanov@linaro.org>
> ---
> drivers/media/platform/qcom/venus/hfi.c | 2 +-
> drivers/media/platform/qcom/venus/hfi.h | 1 -
> 2 files changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/media/platform/qcom/venus/hfi.c b/drivers/media/platform/qcom/venus/hfi.c
> index 638ed5cfe05e..4c87228e8e1d 100644
> --- a/drivers/media/platform/qcom/venus/hfi.c
> +++ b/drivers/media/platform/qcom/venus/hfi.c
> @@ -388,7 +388,7 @@ int hfi_session_unload_res(struct venus_inst *inst)
> if (ret)
> return ret;
>
> - inst->state = INST_RELEASE_RESOURCES;
> + inst->state = INST_INIT;
>
> return 0;
> }
> diff --git a/drivers/media/platform/qcom/venus/hfi.h b/drivers/media/platform/qcom/venus/hfi.h
> index f25d412d6553..e9c944271cc1 100644
> --- a/drivers/media/platform/qcom/venus/hfi.h
> +++ b/drivers/media/platform/qcom/venus/hfi.h
> @@ -87,7 +87,6 @@ struct hfi_event_data {
> #define INST_LOAD_RESOURCES 4
> #define INST_START 5
> #define INST_STOP 6
> -#define INST_RELEASE_RESOURCES 7
>
> struct venus_core;
> struct venus_inst;
> --
> 2.17.1
>
Reviewed-by: Fritz Koenig <frkoenig@chromium.org>
next prev parent reply other threads:[~2020-11-29 6:03 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-11 14:37 [PATCH v2 0/8] Venus stateful encoder compliance Stanimir Varbanov
2020-11-11 14:37 ` [PATCH v2 1/8] venus: hfi: Use correct state in unload resources Stanimir Varbanov
2020-11-29 6:02 ` Fritz Koenig [this message]
2020-11-11 14:37 ` [PATCH v2 2/8] venus: helpers: Add a new helper for buffer processing Stanimir Varbanov
2020-11-29 6:03 ` Fritz Koenig
2020-11-11 14:37 ` [PATCH v2 3/8] venus: hfi_cmds: Allow null buffer address on encoder input Stanimir Varbanov
2020-11-29 6:05 ` Fritz Koenig
2020-11-11 14:37 ` [PATCH v2 4/8] venus: helpers: Calculate properly compressed buffer size Stanimir Varbanov
2020-11-29 6:07 ` Fritz Koenig
2020-11-30 7:52 ` Stanimir Varbanov
2020-11-11 14:37 ` [PATCH v2 5/8] venus: pm_helpers: Check instance state when calculate instance frequency Stanimir Varbanov
2020-11-29 6:08 ` Fritz Koenig
2020-11-11 14:37 ` [PATCH v2 6/8] venus: venc: add handling for VIDIOC_ENCODER_CMD Stanimir Varbanov
2020-11-29 6:12 ` Fritz Koenig
2020-11-11 14:37 ` [PATCH v2 7/8] venus: venc: Handle reset encoder state Stanimir Varbanov
2021-01-02 0:13 ` Fritz Koenig
2021-01-07 10:09 ` Stanimir Varbanov
2020-11-11 14:37 ` [PATCH v2 8/8] venus: helpers: Delete unused stop streaming helper Stanimir Varbanov
2020-11-29 6:09 ` Fritz Koenig
2020-11-29 19:17 ` [PATCH v2 0/8] Venus stateful encoder compliance Fritz Koenig
2020-11-30 7:55 ` Stanimir Varbanov
2020-11-30 17:28 ` Fritz Koenig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMfZQbx5j+c3HQBjaT45ur_6r6Nm3tsRji8D0f_EtLJF_CFiyw@mail.gmail.com \
--to=frkoenig@chromium.org \
--cc=acourbot@chromium.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=stanimir.varbanov@linaro.org \
--cc=vgarodia@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).