Re: [PATCH] staging:pci-mt7621: Use PTR_ERR_OR_ZERO to replace the open code

From: Sergio Paracuellos <sergio.paracuellos@gmail.com>
To: zhong jiang <zhongjiang@huawei.com>
Cc: Greg KH <gregkh@linuxfoundation.org>, NeilBrown <neil@brown.name>,
	peter.vernia@gmail.com, oliver.huebers@web.de,
	linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] staging:pci-mt7621: Use PTR_ERR_OR_ZERO to replace the open code
Date: Mon, 13 Aug 2018 13:26:25 +0200	[thread overview]
Message-ID: <CAMhs-H9+FBfjvtYb0ehoAz7hHaaoKiO6-Ypmb+q-aXRO-xYG6Q@mail.gmail.com> (raw)
In-Reply-To: <1534157699-23637-1-git-send-email-zhongjiang@huawei.com>

On Mon, Aug 13, 2018 at 12:54 PM, zhong jiang <zhongjiang@huawei.com> wrote:
> PTR_ERR_OR_ZERO has implemented the if(IS_ERR(...)) + PTR_ERR, So
> just replace them rather than duplicating its implement.
>
> Signed-off-by: zhong jiang <zhongjiang@huawei.com>
> ---
>  drivers/staging/mt7621-pci/pci-mt7621.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/staging/mt7621-pci/pci-mt7621.c b/drivers/staging/mt7621-pci/pci-mt7621.c
> index a49e279..9a8ff1d 100644
> --- a/drivers/staging/mt7621-pci/pci-mt7621.c
> +++ b/drivers/staging/mt7621-pci/pci-mt7621.c
> @@ -403,10 +403,8 @@ static int mt7621_pcie_parse_dt(struct mt7621_pcie *pcie)
>         }
>
>         pcie->base = devm_ioremap_resource(dev, &regs);
> -       if (IS_ERR(pcie->base))
> -               return PTR_ERR(pcie->base);
>
> -       return 0;
> +       return PTR_ERR_OR_ZERO(pcie->base);
>  }

Hi Zhong,

Thanks for this. This driver is in the middle of cleanup and this
function is not doing all the DT parse
yet, so this patch looks good but after applying this series (if they
work and are good enough to be applied)
has no sense.

See: http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2018-August/124890.html

Best regards,
    Sergio Paracuellos

>
>  static int mt7621_pcie_request_resources(struct mt7621_pcie *pcie,
> --
> 1.7.12.4
>