linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sergio Paracuellos <sergio.paracuellos@gmail.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: "open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
	"Linus Walleij" <linus.walleij@linaro.org>,
	"Gregory Fong" <gregory.0xf0@gmail.com>,
	"Bartosz Golaszewski" <bgolaszewski@baylibre.com>,
	"Florian Fainelli" <f.fainelli@gmail.com>,
	"Matthias Brugger" <matthias.bgg@gmail.com>,
	"René van Dorst" <opensource@vdorst.com>,
	"John Thomson" <git@johnthomson.fastmail.com.au>,
	NeilBrown <neil@brown.name>,
	"Nicholas Mc Guire" <hofrat@osadl.org>,
	"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 1/3] gpiolib: convert 'devprop_gpiochip_set_names' to support multiple gpiochip banks per device
Date: Tue, 27 Jul 2021 17:06:56 +0200	[thread overview]
Message-ID: <CAMhs-H_XktfW0PnK3yURS_bVBM10qws3iDp3Xgb602AZim0c=Q@mail.gmail.com> (raw)
In-Reply-To: <CAHp75VdxrBbnkBDfhb3q7KM3CkAzyAq86gqjLFD5aaKNzVJCHQ@mail.gmail.com>

On Tue, Jul 27, 2021 at 5:05 PM Andy Shevchenko
<andy.shevchenko@gmail.com> wrote:
>
> On Tue, Jul 27, 2021 at 5:48 PM Sergio Paracuellos
> <sergio.paracuellos@gmail.com> wrote:
> >
> > The default gpiolib-of implementation does not work with the multiple
> > gpiochip banks per device structure used for example by the gpio-mt7621
> > and gpio-brcmstb drivers. To fix these kind of situations driver code
> > is forced to fill the names to avoid the gpiolib code to set names
> > repeated along the banks. Instead of continue with that antipattern
> > fix the gpiolib core function to get expected behaviour for every
> > single situation adding a field 'offset' in the gpiochip structure.
> > Doing in this way, we can assume this offset will be zero for normal
> > driver code where only one gpiochip bank per device is used but
> > can be set explicitly in those drivers that really need more than
> > one gpiochip.
>
> ...
>
> > +               dev_warn(&gdev->dev, "gpio-line-names too short (length %d) "
> > +                        "cannot map names for the gpiochip at offset %u\n",
>
> Reflow this that string literal will be on one line (it's fine to be
> over even 100).

Ah, ok. Will fix this and send v3.

Thanks,
    Sergio Paracuellos

>
> > +                        count, chip->offset);
>
> --
> With Best Regards,
> Andy Shevchenko

  reply	other threads:[~2021-07-27 15:07 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-27 14:48 [PATCH v2 0/3] gpiolib: convert 'devprop_gpiochip_set_names' to support multiple gpiochip " Sergio Paracuellos
2021-07-27 14:48 ` [PATCH v2 1/3] gpiolib: convert 'devprop_gpiochip_set_names' to support multiple gpiochip banks " Sergio Paracuellos
2021-07-27 15:04   ` Andy Shevchenko
2021-07-27 15:06     ` Sergio Paracuellos [this message]
2021-07-27 14:48 ` [PATCH v2 2/3] gpio: mt7621: support gpio-line-names property Sergio Paracuellos
2021-07-27 14:48 ` [PATCH v2 3/3] gpio: brcmstb: remove custom 'brcmstb_gpio_set_names' Sergio Paracuellos
2021-07-27 15:06   ` Andy Shevchenko
2021-07-27 15:08     ` Sergio Paracuellos

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAMhs-H_XktfW0PnK3yURS_bVBM10qws3iDp3Xgb602AZim0c=Q@mail.gmail.com' \
    --to=sergio.paracuellos@gmail.com \
    --cc=andy.shevchenko@gmail.com \
    --cc=bgolaszewski@baylibre.com \
    --cc=f.fainelli@gmail.com \
    --cc=git@johnthomson.fastmail.com.au \
    --cc=gregory.0xf0@gmail.com \
    --cc=hofrat@osadl.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=matthias.bgg@gmail.com \
    --cc=neil@brown.name \
    --cc=opensource@vdorst.com \
    --subject='Re: [PATCH v2 1/3] gpiolib: convert '\''devprop_gpiochip_set_names'\'' to support multiple gpiochip banks per device' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).