From: Sergio Paracuellos <sergio.paracuellos@gmail.com>
To: "Antti Keränen" <detegr@gmail.com>
Cc: Matthias Brugger <matthias.bgg@gmail.com>,
Greg KH <gregkh@linuxfoundation.org>,
benniciemanuel78@gmail.com, NeilBrown <neil@brown.name>,
devel@driverdev.osuosl.org, linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] staging: mt7621-pci-phy: prevent use of uninitialized variable
Date: Thu, 4 Apr 2019 14:55:56 +0200 [thread overview]
Message-ID: <CAMhs-H_qFRQ21VoJjy0r=B2uashkGK2Oyf=UWFo66G0spydkaA@mail.gmail.com> (raw)
In-Reply-To: <20190404124414.22846-1-detegr@gmail.com>
On Thu, Apr 4, 2019 at 2:46 PM Antti Keränen <detegr@gmail.com> wrote:
>
> Do not use uninitialized variable 'port' when printing an error message
>
> Signed-off-by: Antti Keränen <detegr@gmail.com>
> ---
> drivers/staging/mt7621-pci-phy/pci-mt7621-phy.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/mt7621-pci-phy/pci-mt7621-phy.c b/drivers/staging/mt7621-pci-phy/pci-mt7621-phy.c
> index 118302c122ee..aa3ae7777632 100644
> --- a/drivers/staging/mt7621-pci-phy/pci-mt7621-phy.c
> +++ b/drivers/staging/mt7621-pci-phy/pci-mt7621-phy.c
> @@ -331,7 +331,7 @@ static int mt7621_pci_phy_probe(struct platform_device *pdev)
>
> ret = of_address_to_resource(np, 0, &res);
> if (ret) {
> - dev_err(dev, "failed to get address resource(id-%d)\n", port);
> + dev_err(dev, "failed to get address resource\n");
> return ret;
> }
Reviewed-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Thanks,
Sergio Paracuellos
>
> --
> 2.21.0
>
prev parent reply other threads:[~2019-04-04 12:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-04 12:44 [PATCH] staging: mt7621-pci-phy: prevent use of uninitialized variable Antti Keränen
2019-04-04 12:55 ` Sergio Paracuellos [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMhs-H_qFRQ21VoJjy0r=B2uashkGK2Oyf=UWFo66G0spydkaA@mail.gmail.com' \
--to=sergio.paracuellos@gmail.com \
--cc=benniciemanuel78@gmail.com \
--cc=detegr@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=neil@brown.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).