From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7706CC4332F for ; Thu, 21 Oct 2021 11:21:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4D4A1610A1 for ; Thu, 21 Oct 2021 11:21:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230323AbhJULYA (ORCPT ); Thu, 21 Oct 2021 07:24:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51306 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230235AbhJULX6 (ORCPT ); Thu, 21 Oct 2021 07:23:58 -0400 Received: from mail-io1-xd29.google.com (mail-io1-xd29.google.com [IPv6:2607:f8b0:4864:20::d29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C7CFCC06161C for ; Thu, 21 Oct 2021 04:21:41 -0700 (PDT) Received: by mail-io1-xd29.google.com with SMTP id z69so369049iof.9 for ; Thu, 21 Oct 2021 04:21:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=hHTl0EN9dQ/dp9evKTTMpGqyp59LLT52mZlH+IIiot8=; b=AQ+5EHmgKNlon0JYKx/HWu5x6U66Dcgko2YsZqPv201SVAWH6nfAXCe6BrNIJTgweU owxFxSqSKQ9lfcUwyV5ckK+OFn0e5vmPJR0CFUWJ53fpkGyrgJFB1ZfsmNZL3iUFz8jH OkREspWPq5dNqwJRHY0/qL6/apmHCbOMTfg9d8moUcertONvMnP7xYWRrSx9gCe7OwYG J9aPVhC3YVVbEWzBVBCINMU/2Q4E8R0jUYUxzNmdIq4wj64/gJsEr1qWWjBfwL9+V238 0Vu3k6epCFJJEmMmYn8r3vfBt2LLoyx+84QGCYdsK46gvG0KfTTlZuBV03A344QGE1pb 6nOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=hHTl0EN9dQ/dp9evKTTMpGqyp59LLT52mZlH+IIiot8=; b=P8CAIaSTuw/dUUFVxim60phHS6qkiF62PJZ8FVoMPK9/zjJ6Th4WAkJKf9pAv7yThh wF4Yc5eMFW/C0gyUSRtKXivG948OX0ZVjQATd69Z8XFAlHGL7IDo9I/OpO85JN8cJZva a+7Cok6y+FkJFdsXl2Sy3tKLDbgJU1eoMnZSVY4qI7KSv9+uKUpqT4b+ku1B/ag0OHW1 05Z9+tCe9w95sPutt3mNr1Kqiik61NbRBmhgP81w1MzIu99J+BQdHJrrJ9fT5Z2z9eHQ Mz8QVnw+mXRfaTpJhWxeS4NuJA3xkqfmXJrPdWgFdPNxO9QZL704HMzCruhbAwO782Oj K9OQ== X-Gm-Message-State: AOAM531FUBFfZ6AAaXnyA9NVzUFAbxApW9mqlL1LQKjtsNmGQ4Pk7fzh 5o2LeuekVLG7yN9WVMqkSgfYu1s/708N42jTMWluVQ== X-Google-Smtp-Source: ABdhPJxMRo/M6HcJdEwh6eTZSJmNRK1zwILbTp96Xp6bcY/ASKoT49bvdtBnoUUI19JfFMMWqZN4m0P00TAN76G7v0w= X-Received: by 2002:a05:6638:3796:: with SMTP id w22mr3510784jal.25.1634815300995; Thu, 21 Oct 2021 04:21:40 -0700 (PDT) MIME-Version: 1.0 References: <20210929000735.585237-1-saravanak@google.com> <20210929000735.585237-3-saravanak@google.com> In-Reply-To: <20210929000735.585237-3-saravanak@google.com> From: Amit Pundir Date: Thu, 21 Oct 2021 16:51:04 +0530 Message-ID: Subject: Re: [PATCH v4 2/2] drivers: bus: Delete CONFIG_SIMPLE_PM_BUS To: Saravana Kannan Cc: Russell King , Neil Armstrong , Geert Uytterhoeven , Magnus Damm , Tony Lindgren , Catalin Marinas , Will Deacon , Damien Le Moal , Greg Kroah-Hartman , Ulf Hansson , Rob Herring , Android Kernel Team , linux-arm-kernel@lists.infradead.org, lkml , linux-oxnas@groups.io, linux-renesas-soc@vger.kernel.org, linux-omap@vger.kernel.org, linux-riscv@lists.infradead.org, Dmitry Baryshkov , John Stultz Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Saravana, This patch broke v5.15-rc6 on RB5 (sm8250 | qcom/qrb5165-rb5.dts). I can't boot past this point https://www.irccloud.com/pastebin/raw/Nv6ZwHmW. Regards, Amit Pundir On Wed, 29 Sept 2021 at 05:37, Saravana Kannan wrote: > > The simple-pm-bus driver is mandatory for CONFIG_OF based platforms to work > with fw_devlink. So, always compile it in for CONFIG_OF and delete the > config since it's no longer necessary. > > Signed-off-by: Saravana Kannan > Tested-by: Ulf Hansson > --- > arch/arm/configs/multi_v7_defconfig | 1 - > arch/arm/configs/oxnas_v6_defconfig | 1 - > arch/arm/configs/shmobile_defconfig | 1 - > arch/arm/mach-omap2/Kconfig | 1 - > arch/arm64/configs/defconfig | 1 - > drivers/bus/Kconfig | 12 ------------ > drivers/bus/Makefile | 2 +- > drivers/soc/canaan/Kconfig | 1 - > 8 files changed, 1 insertion(+), 19 deletions(-) > > diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_defconfig > index d9abaae118dd..362720ae8d65 100644 > --- a/arch/arm/configs/multi_v7_defconfig > +++ b/arch/arm/configs/multi_v7_defconfig > @@ -196,7 +196,6 @@ CONFIG_PCI_EPF_TEST=m > CONFIG_DEVTMPFS=y > CONFIG_DEVTMPFS_MOUNT=y > CONFIG_OMAP_OCP2SCP=y > -CONFIG_SIMPLE_PM_BUS=y > CONFIG_MTD=y > CONFIG_MTD_CMDLINE_PARTS=y > CONFIG_MTD_BLOCK=y > diff --git a/arch/arm/configs/oxnas_v6_defconfig b/arch/arm/configs/oxnas_v6_defconfig > index cae0db6b4eaf..de37f7e90999 100644 > --- a/arch/arm/configs/oxnas_v6_defconfig > +++ b/arch/arm/configs/oxnas_v6_defconfig > @@ -46,7 +46,6 @@ CONFIG_DEVTMPFS=y > CONFIG_DEVTMPFS_MOUNT=y > CONFIG_DMA_CMA=y > CONFIG_CMA_SIZE_MBYTES=64 > -CONFIG_SIMPLE_PM_BUS=y > CONFIG_MTD=y > CONFIG_MTD_CMDLINE_PARTS=y > CONFIG_MTD_BLOCK=y > diff --git a/arch/arm/configs/shmobile_defconfig b/arch/arm/configs/shmobile_defconfig > index d9a27e4e0914..18d2a960b2d2 100644 > --- a/arch/arm/configs/shmobile_defconfig > +++ b/arch/arm/configs/shmobile_defconfig > @@ -40,7 +40,6 @@ CONFIG_PCI_RCAR_GEN2=y > CONFIG_PCIE_RCAR_HOST=y > CONFIG_DEVTMPFS=y > CONFIG_DEVTMPFS_MOUNT=y > -CONFIG_SIMPLE_PM_BUS=y > CONFIG_MTD=y > CONFIG_MTD_BLOCK=y > CONFIG_MTD_CFI=y > diff --git a/arch/arm/mach-omap2/Kconfig b/arch/arm/mach-omap2/Kconfig > index 7df8f5276ddf..02f2f3157f07 100644 > --- a/arch/arm/mach-omap2/Kconfig > +++ b/arch/arm/mach-omap2/Kconfig > @@ -112,7 +112,6 @@ config ARCH_OMAP2PLUS > select PM_GENERIC_DOMAINS > select PM_GENERIC_DOMAINS_OF > select RESET_CONTROLLER > - select SIMPLE_PM_BUS > select SOC_BUS > select TI_SYSC > select OMAP_IRQCHIP > diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig > index f423d08b9a71..474b1f2e3f06 100644 > --- a/arch/arm64/configs/defconfig > +++ b/arch/arm64/configs/defconfig > @@ -245,7 +245,6 @@ CONFIG_DEVTMPFS_MOUNT=y > CONFIG_FW_LOADER_USER_HELPER=y > CONFIG_FW_LOADER_USER_HELPER_FALLBACK=y > CONFIG_HISILICON_LPC=y > -CONFIG_SIMPLE_PM_BUS=y > CONFIG_FSL_MC_BUS=y > CONFIG_TEGRA_ACONNECT=m > CONFIG_GNSS=m > diff --git a/drivers/bus/Kconfig b/drivers/bus/Kconfig > index e7f7eee6ee9a..dc3801369488 100644 > --- a/drivers/bus/Kconfig > +++ b/drivers/bus/Kconfig > @@ -141,18 +141,6 @@ config QCOM_EBI2 > Interface 2, which can be used to connect things like NAND Flash, > SRAM, ethernet adapters, FPGAs and LCD displays. > > -config SIMPLE_PM_BUS > - tristate "Simple Power-Managed Bus Driver" > - depends on OF && PM > - help > - Driver for transparent busses that don't need a real driver, but > - where the bus controller is part of a PM domain, or under the control > - of a functional clock, and thus relies on runtime PM for managing > - this PM domain and/or clock. > - An example of such a bus controller is the Renesas Bus State > - Controller (BSC, sometimes called "LBSC within Bus Bridge", or > - "External Bus Interface") as found on several Renesas ARM SoCs. > - > config SUN50I_DE2_BUS > bool "Allwinner A64 DE2 Bus Driver" > default ARM64 > diff --git a/drivers/bus/Makefile b/drivers/bus/Makefile > index 397e35392bff..86aacd36a56d 100644 > --- a/drivers/bus/Makefile > +++ b/drivers/bus/Makefile > @@ -26,7 +26,7 @@ obj-$(CONFIG_OMAP_OCP2SCP) += omap-ocp2scp.o > obj-$(CONFIG_QCOM_EBI2) += qcom-ebi2.o > obj-$(CONFIG_SUN50I_DE2_BUS) += sun50i-de2.o > obj-$(CONFIG_SUNXI_RSB) += sunxi-rsb.o > -obj-$(CONFIG_SIMPLE_PM_BUS) += simple-pm-bus.o > +obj-$(CONFIG_OF) += simple-pm-bus.o > obj-$(CONFIG_TEGRA_ACONNECT) += tegra-aconnect.o > obj-$(CONFIG_TEGRA_GMI) += tegra-gmi.o > obj-$(CONFIG_TI_PWMSS) += ti-pwmss.o > diff --git a/drivers/soc/canaan/Kconfig b/drivers/soc/canaan/Kconfig > index 8179b69518b4..853096b7e84c 100644 > --- a/drivers/soc/canaan/Kconfig > +++ b/drivers/soc/canaan/Kconfig > @@ -5,7 +5,6 @@ config SOC_K210_SYSCTL > depends on RISCV && SOC_CANAAN && OF > default SOC_CANAAN > select PM > - select SIMPLE_PM_BUS > select SYSCON > select MFD_SYSCON > help > -- > 2.33.0.685.g46640cef36-goog >