From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D31CAC433EF for ; Mon, 21 Mar 2022 11:22:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346720AbiCULYP (ORCPT ); Mon, 21 Mar 2022 07:24:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34590 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233349AbiCULYM (ORCPT ); Mon, 21 Mar 2022 07:24:12 -0400 Received: from mail-yb1-xb29.google.com (mail-yb1-xb29.google.com [IPv6:2607:f8b0:4864:20::b29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A1C618BE39 for ; Mon, 21 Mar 2022 04:22:47 -0700 (PDT) Received: by mail-yb1-xb29.google.com with SMTP id h126so27456491ybc.1 for ; Mon, 21 Mar 2022 04:22:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=59/+29AfugXrFjzNAA/AleHnJFc3FQCIzeHJaozhbYs=; b=m8XwpHjKU/W+0aeE0aPhwzwKwy85wfRo4sPTe4jYG6ugw9k55IP7wQxyjtUlrsYH6L vFwf5X7rYpPMGoZFzSGwYJXPJUhhU4vS3KxGFE7zo6tMzsRA0EDCmqOJ38RjXh4aZTQi B6Cxjhpbq0VX/zpyHtpaFWgO6Sb/XqE970Af3s89fgoDUWPk9HvLdPDyKwn3SBEkMOrd 5A0fFiNLHfesAR1aGGivG9Z8mI5iYsgSF/z6NoXTm1gsSQ5Nszw1za0F3pfafe21R8tA VUU2+JfQYqGDFCwJZe+ClHoqpUO/YzBcw3+pl0UxJO3btWaKLVma4kA4NAyWFtk/9qnM DxIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=59/+29AfugXrFjzNAA/AleHnJFc3FQCIzeHJaozhbYs=; b=5plIQYfmp6ccOvxCpjIDkADmYOEuTFsguhzInBPg6rN2h2bPFj7p3dVOlQwI9aAF8s FZFRHxTgogZ1jSzDxYRRDZ4Ds4cn4h4NT3rkMD5SZBnovjgR1vzHlailC1XU3wKfyjy6 SrIlsiXLYUZhBlavOY+KG/isBj+jANZTeiw2spHENTyR0rqUO9X0szymXwXeOsUBOjwc OAD88EKKNLj421Mo01ZAUR+l1Kq1XjP2o9KXRBNgendnzLnSweKuadYDqF3Zb0d0sCj7 b7Cjnjor/9V12s7/2bmSIEmC40lhwFwbszOvJ89kBZjYP0DYNfkLGqkkbOhalOuwQa3W AUMA== X-Gm-Message-State: AOAM531tsmNPO9+mzsdeFM/pIhNVkUs2nPIQlIZrlEnCTKTiwWDf0Qf8 EIzTHv5Jffm8xzcg8OlAYgp42wnhAak5iCotRKT0Gg== X-Google-Smtp-Source: ABdhPJzWhuELzmeHPG56Ha7BZy3OBGHZOV0q502yNMMRvCHzJ3G4EqBNQBJ2L5I4VLWlR1XUtgBEqVKLi8rTJQxjiwA= X-Received: by 2002:a5b:848:0:b0:633:716f:1fb0 with SMTP id v8-20020a5b0848000000b00633716f1fb0mr19901896ybq.522.1647861766807; Mon, 21 Mar 2022 04:22:46 -0700 (PDT) MIME-Version: 1.0 References: <20220320110616.18355-1-krzk@kernel.org> In-Reply-To: <20220320110616.18355-1-krzk@kernel.org> From: Amit Pundir Date: Mon, 21 Mar 2022 16:52:10 +0530 Message-ID: Subject: Re: [RFT] ufs: qcom: drop custom Android boot parameters To: Krzysztof Kozlowski Cc: Andy Gross , Bjorn Andersson , Alim Akhtar , Avri Altman , "James E.J. Bottomley" , "Martin K. Petersen" , linux-arm-msm@vger.kernel.org, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, Luca Weiss Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 20 Mar 2022 at 16:36, Krzysztof Kozlowski wrote: > > The QCOM UFS driver requires an androidboot.bootdevice command line > argument matching the UFS device name. If the name is different, it > refuses to probe. Thise androidboot.bootdevice is provided by > stock/vendor (from an Android-based device) bootloader. > > This does not make sense from Linux point of view. Driver should be > able to boot regardless of bootloader. Driver should not depend on some > Android custom environment data. > No obvious regression on QCOM devboards DB845c (sdm845) and RB5 (sm8250), and Xiaomi Pocophone F1 (sdm845) running AOSP. Tested-by: Amit Pundir > Cc: Luca Weiss > Signed-off-by: Krzysztof Kozlowski > > --- > > Not tested, please kindly provide tests. > > See also: > https://lore.kernel.org/linux-devicetree/f61abc2b-3ce8-7b1f-3d28-8a4a03ec58eb@kernel.org/T/#u > --- > drivers/scsi/ufs/ufs-qcom.c | 15 --------------- > 1 file changed, 15 deletions(-) > > diff --git a/drivers/scsi/ufs/ufs-qcom.c b/drivers/scsi/ufs/ufs-qcom.c > index 0d2e950d0865..586c0e567ff9 100644 > --- a/drivers/scsi/ufs/ufs-qcom.c > +++ b/drivers/scsi/ufs/ufs-qcom.c > @@ -957,18 +957,6 @@ static const struct reset_control_ops ufs_qcom_reset_ops = { > .deassert = ufs_qcom_reset_deassert, > }; > > -#define ANDROID_BOOT_DEV_MAX 30 > -static char android_boot_dev[ANDROID_BOOT_DEV_MAX]; > - > -#ifndef MODULE > -static int __init get_android_boot_dev(char *str) > -{ > - strlcpy(android_boot_dev, str, ANDROID_BOOT_DEV_MAX); > - return 1; > -} > -__setup("androidboot.bootdevice=", get_android_boot_dev); > -#endif > - > /** > * ufs_qcom_init - bind phy with controller > * @hba: host controller instance > @@ -988,9 +976,6 @@ static int ufs_qcom_init(struct ufs_hba *hba) > struct resource *res; > struct ufs_clk_info *clki; > > - if (strlen(android_boot_dev) && strcmp(android_boot_dev, dev_name(dev))) > - return -ENODEV; > - > host = devm_kzalloc(dev, sizeof(*host), GFP_KERNEL); > if (!host) { > err = -ENOMEM; > -- > 2.32.0 >