From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AFA14C433FE for ; Tue, 7 Sep 2021 08:26:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9B38D60184 for ; Tue, 7 Sep 2021 08:26:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242726AbhIGI1L (ORCPT ); Tue, 7 Sep 2021 04:27:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44094 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242634AbhIGI1F (ORCPT ); Tue, 7 Sep 2021 04:27:05 -0400 Received: from mail-io1-xd29.google.com (mail-io1-xd29.google.com [IPv6:2607:f8b0:4864:20::d29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 80886C0613C1 for ; Tue, 7 Sep 2021 01:25:59 -0700 (PDT) Received: by mail-io1-xd29.google.com with SMTP id y18so11685646ioc.1 for ; Tue, 07 Sep 2021 01:25:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=NsKj9cPaLgyBNOvmCyBpPD5MVH61aPQBDGk2ylDvT4I=; b=Cqjo+7flYZt5PVjhviejc951vnn/ZxHjZDDSZm2iE0Rym074UsRk9jSB8UzOfpCM20 1L7LsMW2HeQwiSX1w7skzHYqzLwWa4CPoh5LlihNGeqtjjfG1GqmfL5R3o2BrSipgrlA OuBBIr1mdYQh9FPAF67gcxNx2Kiu+zHh65/LVhufxDIGEAhIB9JYe1+R/wotXAyJUivj 0EMSCIzmvIGHrrspZkocKYi6byJGjOhIKyix3nw5KN8ARegcY64YWoEaTFwGuSTWs+KI gDgyLFcM0QY8iY+pcGyzE7Iu2oEGesDb4IGg6lFY7iJ0uL/WSxFH76C9e2HTozPJfOAU pvPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=NsKj9cPaLgyBNOvmCyBpPD5MVH61aPQBDGk2ylDvT4I=; b=aeCqQcDSH9+KazZjluvjcjxe6hbkp1EIQsmwzlGXSaRxOjQFlIM2iOUtnSAQA7SA0L JI8wWu1jzWHuYW2oCMTn/wmMCRqX1p5VDXUtAJPv0phKWgZtmmEzHiPXulro8N70n/Pu NeeCwQ+ixpCc+yeylaMUdmjSIi4mQc3qhjIhU/nMVJ+CWKPPK5aS+KNorjZzbky2ppv+ FyuECItprmyuJ0o2pZ4iSW5cZSTY5Y/31Jz6H5umKIiSkExCg2CPDcVBvlCWTLVSq69c qL6YDgcxOKV2RYqzdfBoM+BCOqF5DU9cFtbKuVvRFeat294EBhDoXWMh6b/wkeglOZE2 Q52A== X-Gm-Message-State: AOAM530jtAAyGLmT01BaNWkWhh/C7hgXx4MB9N7x7mkZQTmRHE74j4Wg A128yXljeHIa8q3E2KrpHqu5+DxEGIRms/VKvKtXuw== X-Google-Smtp-Source: ABdhPJyJyljW5UoDalrx/KiXWJ1AmyFiYxxkN5TxwIiLyNRIfmd72o0Tug4f9p9B9LTcvpjzBQv03fcRV3wdDGSffHI= X-Received: by 2002:a02:3846:: with SMTP id v6mr14251170jae.45.1631003158871; Tue, 07 Sep 2021 01:25:58 -0700 (PDT) MIME-Version: 1.0 References: <20210729183942.2839925-1-robdclark@gmail.com> <1a38a590-a64e-58ef-1bbf-0ae49c004d05@linaro.org> In-Reply-To: From: Amit Pundir Date: Tue, 7 Sep 2021 13:55:22 +0530 Message-ID: Subject: Re: [PATCH] drm/msm: Disable frequency clamping on a630 To: Rob Clark Cc: John Stultz , Caleb Connolly , Rob Clark , freedreno , Sai Prakash Ranjan , Jonathan Marek , David Airlie , linux-arm-msm , Akhil P Oommen , dri-devel , Jordan Crouse , Stephen Boyd , Bjorn Andersson , Sean Paul , open list Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 7 Sept 2021 at 07:11, Rob Clark wrote: > > One thing I thought of, which would be worth ruling out, is whether > this issue only occurs with freq changes immediately after resuming > the GPU, vs freq changes in general. Could you try the below patch. > And if it "fixes" the issue, then try reducing the delay until you > start seeing GPU hangs again. It doesn't fix the crash and I can still reproduce it https://pastebin.com/raw/bxK4mAhB > > ---------- > diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gpu.c > b/drivers/gpu/drm/msm/adreno/a6xx_gpu.c > index 40c9fef457a4..278b85207ea3 100644 > --- a/drivers/gpu/drm/msm/adreno/a6xx_gpu.c > +++ b/drivers/gpu/drm/msm/adreno/a6xx_gpu.c > @@ -1513,6 +1513,8 @@ static int a6xx_pm_resume(struct msm_gpu *gpu) > if (ret) > return ret; > > + msleep(5); > + > msm_devfreq_resume(gpu); > > a6xx_llc_activate(a6xx_gpu); > ---------- > > BR, > -R