From: Amit Pundir <amit.pundir@linaro.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Linux regressions mailing list <regressions@lists.linux.dev>,
Mark Brown <broonie@kernel.org>,
Doug Anderson <dianders@chromium.org>,
Bjorn Andersson <andersson@kernel.org>,
Andy Gross <agross@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Caleb Connolly <caleb.connolly@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-arm-msm <linux-arm-msm@vger.kernel.org>,
dt <devicetree@vger.kernel.org>,
lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] arm64: dts: qcom: sdm845-db845c: Move LVS regulator nodes up
Date: Mon, 19 Jun 2023 12:36:10 +0530 [thread overview]
Message-ID: <CAMi1Hd2dO9WSfRQxZLhiyTjFrC_mX6ej9Q=u=Rd1XgRd5AU=jA@mail.gmail.com> (raw)
In-Reply-To: <fbe5138f-fe97-11ee-a14a-4bb447c0972a@linaro.org>
On Sat, 17 Jun 2023 at 12:51, Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:
>
> On 16/06/2023 19:09, Amit Pundir wrote:
> > Hi,
> >
> > On Fri, 16 Jun 2023 at 13:57, Krzysztof Kozlowski
> > <krzysztof.kozlowski@linaro.org> wrote:
> >>
> >>
> >> So you have interconnect as module - this is not a supported setup. It
> >> might work with if all the modules are loaded very early or might not.
> >> Pinctrl is another driver which should be built-in.
> >>
> >> With your defconfig I see regular issue - console and system dies
> >> because of lack of interconnects, most likely. I don't see your WARNs -
> >> I just see usual hang.
> >>
> >> See:
> >> https://lore.kernel.org/all/20221021032702.1340963-1-krzysztof.kozlowski@linaro.org/
> >>
> >> If you want them to really be modules, then you need to fix all the
> >> dependencies (SOFTDEP?), probe ordering glitches. It's not a problem of
> >> DTS. Just because something can be built as module, does not mean it
> >> will work. We don't test it, we don't work with them as modules.
> >
> > I do somewhat agree with most of your arguments but not this one. If a
> > driver doesn't work as a module then it shouldn't be allowed to build
> > as a module.
>
> Of course you are right. That's why I am pushing against blindly adding
> "tristate" by everyone working on GKI. Because such folks like to make
> them tristate, but not actually test it or work on issues later.
>
> That's exactly the case from Google and Samsung patches here:
> https://lore.kernel.org/all/ac328b6a-a8e2-873d-4015-814cb4f5588e@canonical.com/
> and in previous submissions.
>
> > I took a quick look at the history of the interconnect
> > driver and it is tristate from the beginning. And not converted to a
> > modular build later-on like some of the other drivers to support GKI.
>
> OK, maybe it was never actually tested. Or maybe some versions were
> working on boards where debug serial does not have interconnect, but new
> chips just followed the pattern without testing?
> >
> >>
> >> It's kind of the same as here:
> >> https://lore.kernel.org/all/ac328b6a-a8e2-873d-4015-814cb4f5588e@canonical.com/
> >>
> >> I understand that we might have here regression, if these were working
> >> as modules, but I don't think we ever really committed to it. We can as
> >> well make it non-module to solve the regression.
> >
> > Sure. But since v6.4 is around the corner, can we merge this
> > workaround for now, while a proper fix is being worked upon.
>
> DTS workaround? No. I don't agree. Once it is merged it will not be fixed.
>
> I am perfectly fine though with making the interconnect or even rpmh
> regulator bool instead of tristate.
As Doug also mentioned in one of his earlier emails, this workaround
is only limited to one particular board. If I try to change the common
interconnect and/or rpmh driver then it will need ack from other stake
holders as well and I'll most likely get more pushback from that side.
Regards,
Amit Pundir
next prev parent reply other threads:[~2023-06-19 7:07 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-02 16:12 [PATCH] arm64: dts: qcom: sdm845-db845c: Move LVS regulator nodes up Amit Pundir
2023-06-06 23:34 ` Doug Anderson
2023-06-07 7:49 ` Krzysztof Kozlowski
2023-06-07 9:17 ` Amit Pundir
2023-06-07 10:16 ` Krzysztof Kozlowski
2023-06-08 17:26 ` Amit Pundir
2023-06-08 17:44 ` Doug Anderson
2023-06-07 7:46 ` Krzysztof Kozlowski
2023-06-14 18:18 ` Linux regression tracking (Thorsten Leemhuis)
2023-06-14 18:47 ` Krzysztof Kozlowski
2023-06-14 19:08 ` Amit Pundir
2023-06-15 13:47 ` Amit Pundir
2023-06-15 15:03 ` Krzysztof Kozlowski
2023-06-15 16:09 ` Amit Pundir
2023-06-15 16:15 ` Amit Pundir
2023-06-16 8:27 ` Krzysztof Kozlowski
2023-06-16 17:09 ` Amit Pundir
2023-06-17 7:21 ` Krzysztof Kozlowski
2023-06-19 7:06 ` Amit Pundir [this message]
2023-06-14 19:44 ` Doug Anderson
2023-06-20 15:59 ` Bjorn Andersson
2023-06-22 7:47 ` Linux regression tracking (Thorsten Leemhuis)
2023-06-22 11:48 ` Amit Pundir
2023-07-07 5:08 ` Amit Pundir
2023-07-14 11:04 ` Linux regression tracking #update (Thorsten Leemhuis)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMi1Hd2dO9WSfRQxZLhiyTjFrC_mX6ej9Q=u=Rd1XgRd5AU=jA@mail.gmail.com' \
--to=amit.pundir@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=broonie@kernel.org \
--cc=caleb.connolly@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=regressions@lists.linux.dev \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).