From: Ard Biesheuvel <ardb@kernel.org>
To: Borislav Petkov <bp@alien8.de>
Cc: Smita Koralahalli <Smita.KoralahalliChannabasappa@amd.com>,
X86 ML <x86@kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-pm@vger.kernel.org, linux-edac@vger.kernel.org,
linux-efi <linux-efi@vger.kernel.org>,
ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
devel@acpica.org, Tony Luck <tony.luck@intel.com>,
"Rafael J . Wysocki" <rjw@rjwysocki.net>,
Len Brown <len.brown@intel.com>,
Punit Agrawal <punit1.agrawal@toshiba.co.jp>,
Yazen Ghannam <yazen.ghannam@amd.com>
Subject: Re: [PATCH v6] cper, apei, mce: Pass x86 CPER through the MCA handling chain
Date: Sat, 21 Nov 2020 11:38:02 +0100 [thread overview]
Message-ID: <CAMj1kXEAkmKCSwKAnvWhZyo7=HdQNYFLQOzX0R+qN=WVHYd+OQ@mail.gmail.com> (raw)
In-Reply-To: <20201121101511.GA24020@zn.tnic>
On Sat, 21 Nov 2020 at 11:15, Borislav Petkov <bp@alien8.de> wrote:
>
> On Thu, Nov 19, 2020 at 12:29:38PM -0600, Smita Koralahalli wrote:
> > diff --git a/drivers/firmware/efi/cper-x86.c b/drivers/firmware/efi/cper-x86.c
> > index 2531de49f56c..438ed9eff6d0 100644
> > --- a/drivers/firmware/efi/cper-x86.c
> > +++ b/drivers/firmware/efi/cper-x86.c
> > @@ -2,6 +2,7 @@
> > // Copyright (C) 2018, Advanced Micro Devices, Inc.
> >
> > #include <linux/cper.h>
> > +#include <linux/acpi.h>
> >
> > /*
> > * We don't need a "CPER_IA" prefix since these are all locally defined.
> > @@ -347,9 +348,13 @@ void cper_print_proc_ia(const char *pfx, const struct cper_sec_proc_ia *proc)
> > ctx_info->mm_reg_addr);
> > }
> >
> > - printk("%sRegister Array:\n", newpfx);
> > - print_hex_dump(newpfx, "", DUMP_PREFIX_OFFSET, 16, groupsize,
> > - (ctx_info + 1), ctx_info->reg_arr_size, 0);
> > + if (ctx_info->reg_ctx_type != CTX_TYPE_MSR ||
> > + arch_apei_report_x86_error(ctx_info, proc->lapic_id)) {
> > + printk("%sRegister Array:\n", newpfx);
> > + print_hex_dump(newpfx, "", DUMP_PREFIX_OFFSET, 16,
> > + groupsize, (ctx_info + 1),
> > + ctx_info->reg_arr_size, 0);
> > + }
> >
> > ctx_info = (struct cper_ia_proc_ctx *)((long)ctx_info + size);
> > }
> > --
>
> Ard, ack?
>
Acked-by: Ard Biesheuvel <ardb@kernel.org>
next prev parent reply other threads:[~2020-11-21 10:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-19 18:29 [PATCH v6] cper, apei, mce: Pass x86 CPER through the MCA handling chain Smita Koralahalli
2020-11-21 10:15 ` Borislav Petkov
2020-11-21 10:38 ` Ard Biesheuvel [this message]
2020-11-21 11:04 ` Borislav Petkov
2020-11-21 11:06 ` [tip: ras/core] x86/mce, cper: " tip-bot2 for Smita Koralahalli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMj1kXEAkmKCSwKAnvWhZyo7=HdQNYFLQOzX0R+qN=WVHYd+OQ@mail.gmail.com' \
--to=ardb@kernel.org \
--cc=Smita.KoralahalliChannabasappa@amd.com \
--cc=bp@alien8.de \
--cc=devel@acpica.org \
--cc=len.brown@intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-edac@vger.kernel.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=punit1.agrawal@toshiba.co.jp \
--cc=rjw@rjwysocki.net \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
--cc=yazen.ghannam@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).