From: Ard Biesheuvel <ardb@kernel.org>
To: Sakari Ailus <sakari.ailus@linux.intel.com>
Cc: linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
sbinding@opensource.cirrus.com, andriy.shevchenko@intel.com,
patches@opensource.cirrus.com, rafael@kernel.org
Subject: Re: [PATCH 1/1] acpi: Remove default association from integer maximum values
Date: Fri, 26 Aug 2022 12:14:45 +0200 [thread overview]
Message-ID: <CAMj1kXFVnZzmYN46d0YB8ieri4vEPz49ufw1FvQ19GT+cQ+wLw@mail.gmail.com> (raw)
In-Reply-To: <20220825111715.3025694-1-sakari.ailus@linux.intel.com>
On Thu, 25 Aug 2022 at 13:17, Sakari Ailus <sakari.ailus@linux.intel.com> wrote:
>
> Remove the default association from integer maximum value checks. It is
> not necessary and has caused a bug in other associations being unnoticed.
>
> Fixes: 923044133367 ("ACPI: property: Unify integer value reading functions")
> Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Acked-by: Ard Biesheuvel <ardb@kernel.org>
> ---
> drivers/acpi/property.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/acpi/property.c b/drivers/acpi/property.c
> index 91d0e75859d37..d4c168ce428ca 100644
> --- a/drivers/acpi/property.c
> +++ b/drivers/acpi/property.c
> @@ -1046,8 +1046,7 @@ static int acpi_data_prop_read_single(const struct acpi_device_data *data,
> u8 *: U8_MAX, \
> u16 *: U16_MAX, \
> u32 *: U32_MAX, \
> - u64 *: U64_MAX, \
> - default: 0U)) { \
> + u64 *: U64_MAX)) { \
> ret = -EOVERFLOW; \
> break; \
> } \
> --
> 2.30.2
>
prev parent reply other threads:[~2022-08-26 10:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-25 11:17 [PATCH 1/1] acpi: Remove default association from integer maximum values Sakari Ailus
2022-08-26 10:14 ` Ard Biesheuvel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMj1kXFVnZzmYN46d0YB8ieri4vEPz49ufw1FvQ19GT+cQ+wLw@mail.gmail.com \
--to=ardb@kernel.org \
--cc=andriy.shevchenko@intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@opensource.cirrus.com \
--cc=rafael@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=sbinding@opensource.cirrus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).