From: Ard Biesheuvel <ardb@kernel.org>
To: Alexandru Elisei <alexandru.elisei@arm.com>
Cc: catalin.marinas@arm.com, will@kernel.org,
linux-efi@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [Possible BUG] arm64: efi: efi_runtime_fixup_exception() and efi_call_virt_check_flags() both taint the kernel
Date: Wed, 9 Nov 2022 10:07:00 +0100 [thread overview]
Message-ID: <CAMj1kXGswMfSXYmr=LyAOusYjq6eLqC9oPRRCEaR-1u-kFu4Hw@mail.gmail.com> (raw)
In-Reply-To: <Y2oq79NaCn6UKkLw@monolith.localdoman>
On Tue, 8 Nov 2022 at 11:10, Alexandru Elisei <alexandru.elisei@arm.com> wrote:
>
...
>
> Speaking as an user, I think it would be nice to revert the commit, that's
> how I am running v6.1-rcX kernels on the machine, as updating the firmware
> is not feasible right now. But I realize that I'm not the one maintaining
> the code, so I don't have a strong opinion about it :) And it's better now
> than it was at rc3, when the kernel was panicing.
>
I sent out a patch yesterday that tweaks the sync exception fixup
handler to only disable the runtime service that triggered the
exception. This means, of course, that you might hit it multiple times
if several runtime service implementations are buggy, but there are
only five or so that we actually use, so that shouldn't make a huge
difference. But it also means a) we don't trigger other code paths
that freak out when a runtime service that was available suddenly goes
away and b) the diagnostics are more useful because we will find out
which other runtime services are broken.
Could you please test that patch? And for good measure, could you try
something like
efibootmgr -t 3
(as root) to exercise the SetVariable() path as well?
next prev parent reply other threads:[~2022-11-09 9:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-07 17:27 [Possible BUG] arm64: efi: efi_runtime_fixup_exception() and efi_call_virt_check_flags() both taint the kernel Alexandru Elisei
2022-11-07 17:47 ` Ard Biesheuvel
2022-11-08 10:09 ` Alexandru Elisei
2022-11-09 9:07 ` Ard Biesheuvel [this message]
2022-11-09 10:08 ` Alexandru Elisei
2022-11-08 12:19 ` [Possible BUG] arm64: efi: efi_runtime_fixup_exception() and efi_call_virt_check_flags() both taint the kernel #forregzbot Thorsten Leemhuis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMj1kXGswMfSXYmr=LyAOusYjq6eLqC9oPRRCEaR-1u-kFu4Hw@mail.gmail.com' \
--to=ardb@kernel.org \
--cc=alexandru.elisei@arm.com \
--cc=catalin.marinas@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).