From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1A962C46CA3 for ; Fri, 8 Dec 2023 14:50:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1574025AbjLHOu1 (ORCPT ); Fri, 8 Dec 2023 09:50:27 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55978 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1573984AbjLHOuZ (ORCPT ); Fri, 8 Dec 2023 09:50:25 -0500 Received: from mail-lj1-x22d.google.com (mail-lj1-x22d.google.com [IPv6:2a00:1450:4864:20::22d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 87CE3173F for ; Fri, 8 Dec 2023 06:50:30 -0800 (PST) Received: by mail-lj1-x22d.google.com with SMTP id 38308e7fff4ca-2c9e9c2989dso27108531fa.0 for ; Fri, 08 Dec 2023 06:50:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1702047029; x=1702651829; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=p1vCAo/0XghnYmheAcvJKeKXj1PDXUChqBaVuIxQEDk=; b=L++SddHB53ds+BDyxsaCgrubvQa2iCP6jmnnUM20jJFeqUnEt0V9babowwqiEJ7M+m 4oXRahXSndOR0chVc4l5qV1/5KA8ZKwg5y/6H0zZrBItRv2q8qrAo1tpq+HDuCZQRwfA kkOMh4IcaKVD1f5/XyCGn4iO3yMYqU9r6rH4UzCPv0CdTi2scs4hFu1nf1X6OFiR2hAm oBi0D/zpRjmSlcaqy3jE0tDYVu1KNhHRvQVYLb2Xp8WEXkNdLZIpUVQx/XA2Tnb1kF7/ 4WsrK5ezJrOcaL7wTe9s64u+yPTfWKjivjednOeku0/8sixZbTZPHzqJRIXr6S1bfMet JV6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702047029; x=1702651829; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=p1vCAo/0XghnYmheAcvJKeKXj1PDXUChqBaVuIxQEDk=; b=Agh5AUq+3gFZOaCQ+7JFmIsSEe5eQOLTDumsoLoz17hVPmvbO3nkOkhtugHHqiOmiF uqp+5u1QKclyZAMVWxHXG9867cOHblkEJLlL2Kp85hPAbnlIsVcs5nku5zGfoS9IYfu1 C51KTWoU9HCpOxG8JWcjCPvI/jgDG9jJQSA85ApCqhyGtZS+gnYlK+b7SZYyPWWVKLQr H7D2FiM60P/aK00mddqNto1/Q7t0ukPMJ+tQbypbKWt7623+rvXky7BrRVHIZ7+1juw8 1467eC731ZmEiZJSoi7aVUdGOWXp13Nwm5Hs+bIyhdBe6F0GUgL5md0du/9x24Sj1X50 +O0A== X-Gm-Message-State: AOJu0YyVKqQv2Za6OjLQFm4LQvuavJKdAtZHYxUwh1WSssxM+UsS2VbK RoOfRG9bDAINbP5CFbtmkz48oZ7fair/1rS8snYMvg== X-Google-Smtp-Source: AGHT+IF7XrHbo2zzPPfxnAYa+JlWU8BR5gIVI4S58FUUPJRXqcyKVeGHxAfQTma9B0lG/uCzmUYQrmEbcjxPBSW/Wuw= X-Received: by 2002:a2e:878d:0:b0:2ca:34d:f80a with SMTP id n13-20020a2e878d000000b002ca034df80amr8350lji.64.1702047028634; Fri, 08 Dec 2023 06:50:28 -0800 (PST) MIME-Version: 1.0 References: <53d55f3195b15bd8d47387e296036730ea270770.1701971344.git.marcelo.schmitt1@gmail.com> In-Reply-To: From: David Lechner Date: Fri, 8 Dec 2023 08:50:17 -0600 Message-ID: Subject: Re: [PATCH v3 10/13] dt-bindings: iio: Add AD7091R-8 To: Marcelo Schmitt Cc: Marcelo Schmitt , apw@canonical.com, joe@perches.com, dwaipayanray1@gmail.com, lukas.bulwahn@gmail.com, paul.cercueil@analog.com, Michael.Hennerich@analog.com, lars@metafoo.de, jic23@kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, dan.carpenter@linaro.org, linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Dec 8, 2023 at 7:28=E2=80=AFAM Marcelo Schmitt wrote: > > Hi David, thank you for your suggestions. > Comments inline. > > On 12/07, David Lechner wrote: > > On Thu, Dec 7, 2023 at 12:42=E2=80=AFPM Marcelo Schmitt > > wrote: > > > > > > Add device tree documentation for AD7091R-8. > > > > > > Signed-off-by: Marcelo Schmitt > > > --- > > > .../bindings/iio/adc/adi,ad7091r8.yaml | 99 +++++++++++++++++= ++ > > > 1 file changed, 99 insertions(+) > > > create mode 100644 Documentation/devicetree/bindings/iio/adc/adi,ad7= 091r8.yaml > > > > > > diff --git a/Documentation/devicetree/bindings/iio/adc/adi,ad7091r8.y= aml b/Documentation/devicetree/bindings/iio/adc/adi,ad7091r8.yaml > > > new file mode 100644 > > > index 000000000000..02320778f225 > > > --- /dev/null > > > +++ b/Documentation/devicetree/bindings/iio/adc/adi,ad7091r8.yaml > > > @@ -0,0 +1,99 @@ > > > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > > > +%YAML 1.2 > > > +--- > > > +$id: http://devicetree.org/schemas/iio/adc/adi,ad7091r8.yaml# > > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > > + > > > +title: Analog Devices AD7091R8 8-Channel 12-Bit ADC > > > + > > > +maintainers: > > > + - Marcelo Schmitt > > > + > > > +description: | > > > + Analog Devices AD7091R-8 8-Channel 12-Bit ADC > > > + https://www.analog.com/media/en/technical-documentation/data-sheet= s/AD7091R-2_7091R-4_7091R-8.pdf > > > + > > > +properties: > > > + compatible: > > > + enum: > > > + - adi,ad7091r2 > > > + - adi,ad7091r4 > > > + - adi,ad7091r8 > > > + > > > + reg: > > > + maxItems: 1 > > > + > > > > Missing other supplies? Like vdd-supply and vdrive-supply? > > > > I used the name that would work with ad7091r-base.c. > If I'm not misinterpreting the datasheet, vdd-supply and vdrive-supply ar= e > for powering the ADC and setting SPI lanes logic level, respectively. > They don't have any impact on ADC readings. The guidelines [1] say that bindings should be complete even if the feature is not used. In the most recent bindings I have submitted, Jonathan specifically called out making sure all supplies were included in the bindings. So I would assume the same applies here. [1]: https://www.kernel.org/doc/html/latest/devicetree/bindings/writing-bin= dings.html > By the way, should maybe I extend ad7091r5 dt doc instead of creating thi= s > new one? If it is pin-compatible or 90% the same, then perhaps.