From: bingjing chang <bxxxjxxg@gmail.com>
To: Miklos Szeredi <miklos@szeredi.hu>
Cc: Al Viro <viro@zeniv.linux.org.uk>, Jan Kara <jack@suse.com>,
Jan Kara <jack@suse.cz>, Jens Axboe <axboe@kernel.dk>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
cccheng@synology.com, robbieko@synology.com,
bingjingc <bingjingc@synology.com>
Subject: Re: [PATCH 3/3] parser: add unsigned int parser
Date: Fri, 29 Jan 2021 14:00:59 +0800 [thread overview]
Message-ID: <CAMmgxWFMBxg47J_Zjdfm5i36m3TMf2VEzoeREGKD6VFJXcbN3A@mail.gmail.com> (raw)
In-Reply-To: <939d2196-8468-4d93-b976-70f3d8ac83de@Mail>
Hi Miklos,
Thank you for your mail. Please see my message below.
bingjingc <bingjingc@synology.com> 於 2021年1月29日 週五 下午1:50寫道:
>
> [loop bxxxjxxg@gmail.com] in order to reply in plain-text
> Miklos Szeredi <miklos@szeredi.hu> 於 2021-01-28 16:37 寫道:
>
> On Thu, Jan 28, 2021 at 3:21 AM bingjingc <bingjingc@synology.com> wrote:
> >
> > From: BingJing Chang <bingjingc@synology.com>
> >
> > Will be used by fs parsing options
> >
> > Reviewed-by: Robbie Ko<robbieko@synology.com>
> > Reviewed-by: Chung-Chiang Cheng <cccheng@synology.com>
> > Signed-off-by: BingJing Chang <bingjingc@synology.com>
> > ---
> > fs/isofs/inode.c | 16 ++--------------
> > fs/udf/super.c | 16 ++--------------
> > include/linux/parser.h | 1 +
> > lib/parser.c | 22 ++++++++++++++++++++++
> > 4 files changed, 27 insertions(+), 28 deletions(-)
> >
> > diff --git a/fs/isofs/inode.c b/fs/isofs/inode.c
> > index 342ac19..21edc42 100644
> > --- a/fs/isofs/inode.c
> > +++ b/fs/isofs/inode.c
> > @@ -335,18 +335,6 @@ static const match_table_t tokens = {
> > {Opt_err, NULL}
> > };
> >
> > -static int isofs_match_uint(substring_t *s, unsigned int *res)
> > -{
> > - int err = -ENOMEM;
> > - char *buf = match_strdup(s);
> > -
> > - if (buf) {
> > - err = kstrtouint(buf, 10, res);
> > - kfree(buf);
> > - }
> > - return err;
> > -}
>
> I don't see how adding this function and removing it in the same
> series makes any sense.
That's true. Simple and clear is better.
I used to think that the acceptance of patch can be 3/3 or 2/3.
And I was not sure are there needs for making match_uint
as shared lib. So I made the first patch.
I simplify them. Please see the third patch, thanks!
>
> Why not make this the first patch in the series, simplifying everything?
>
> And while at it the referenced fuse implementation can also be
> converted (as a separate patch).
>
> Thanks,
> Miklos
Thanks,
BingJing
prev parent reply other threads:[~2021-01-29 6:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-28 2:20 [PATCH 3/3] parser: add unsigned int parser bingjingc
2021-01-28 3:27 ` Randy Dunlap
2021-01-28 8:32 ` Miklos Szeredi
[not found] ` <939d2196-8468-4d93-b976-70f3d8ac83de@Mail>
2021-01-29 6:00 ` bingjing chang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMmgxWFMBxg47J_Zjdfm5i36m3TMf2VEzoeREGKD6VFJXcbN3A@mail.gmail.com \
--to=bxxxjxxg@gmail.com \
--cc=axboe@kernel.dk \
--cc=bingjingc@synology.com \
--cc=cccheng@synology.com \
--cc=jack@suse.com \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=robbieko@synology.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).