From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751325AbeDTQ1h (ORCPT ); Fri, 20 Apr 2018 12:27:37 -0400 Received: from mail-yb0-f193.google.com ([209.85.213.193]:45952 "EHLO mail-yb0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750751AbeDTQ1g (ORCPT ); Fri, 20 Apr 2018 12:27:36 -0400 X-Google-Smtp-Source: AIpwx4/Rd1SebrFHwcFhXnSAtQRuXMXQ13pFmYIuFWiYkVnvgce/3sDIuR0Jt6h41jgos08NjcG5lN0yh6/RI3w+nWQ= MIME-Version: 1.0 In-Reply-To: <20180420143811.9994-22-ebiederm@xmission.com> References: <87604mhrnb.fsf@xmission.com> <20180420143811.9994-22-ebiederm@xmission.com> From: Max Filippov Date: Fri, 20 Apr 2018 09:27:35 -0700 Message-ID: Subject: Re: [REVIEW][PATCH 22/22] signal/xtensa: Use force_sig_fault where appropriate To: "Eric W. Biederman" Cc: Linux-Arch , LKML , Chris Zankel , linux-xtensa@linux-xtensa.org Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Apr 20, 2018 at 7:38 AM, Eric W. Biederman wrote: > Filling in struct siginfo before calling force_sig_info a tedious and > error prone process, where once in a great while the wrong fields > are filled out, and siginfo has been inconsistently cleared. > > Simplify this process by using the helper force_sig_fault. Which > takes as a parameters all of the information it needs, ensures > all of the fiddly bits of filling in struct siginfo are done properly > and then calls force_sig_info. > > In short about a 5 line reduction in code for every time force_sig_info > is called, which makes the calling function clearer. > > Cc: Max Filippov > Cc: Chris Zankel > Cc: linux-xtensa@linux-xtensa.org > Cc: linux-xtensa@linux-xtensa.org > Signed-off-by: "Eric W. Biederman" > --- > arch/xtensa/kernel/traps.c | 10 +--------- > arch/xtensa/mm/fault.c | 19 +++++-------------- > 2 files changed, 6 insertions(+), 23 deletions(-) Acked-by: Max Filippov -- Thanks. -- Max