From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1035084AbdEYWwZ (ORCPT ); Thu, 25 May 2017 18:52:25 -0400 Received: from mail-yb0-f196.google.com ([209.85.213.196]:34099 "EHLO mail-yb0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1760337AbdEYWwV (ORCPT ); Thu, 25 May 2017 18:52:21 -0400 MIME-Version: 1.0 In-Reply-To: <116e7ba5-cb5e-8e96-ea74-bf91b4818d69@oracle.com> References: <116e7ba5-cb5e-8e96-ea74-bf91b4818d69@oracle.com> From: Max Filippov Date: Thu, 25 May 2017 15:52:14 -0700 Message-ID: Subject: Re: CPU_BIG_ENDIAN in generic code (was: Re: [PATCH v3 3/7] arch/sparc: Define config parameter CPU_BIG_ENDIAN) To: Babu Moger Cc: Arnd Bergmann , Geert Uytterhoeven , "David S. Miller" , Peter Zijlstra , Ingo Molnar , sparclinux , "linux-kernel@vger.kernel.org" , Linux-Arch , "devicetree@vger.kernel.org" , "linux-serial@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 25, 2017 at 3:41 PM, Babu Moger wrote: > On 5/25/2017 5:27 PM, Max Filippov wrote: >> Xtensa may have either endianness and for xtensa we define >> CONFIG_CPU_BIG_ENDIAN or CONFIG_CPU_LITTLE_ENDIAN >> in the arch/xtensa/Makefile based on the value of the compiler builtin >> macro. > > Hmm.. That means defining CPU_LITTLE_ENDIAN based on "def_bool > !CPU_BIG_ENDIAN" will > be a problem for Xtensa because menuconfig does not have the knowledge of > compiler builtin macro. > Is that correct? I think so. OTOH outside the arch/ CPU_LITTLE_ENDIAN is only used in two Kconfig files: drivers/crypto/nx/Kconfig drivers/isdn/hisax/Kconfig both of which are irrelevant for xtensa. -- Thanks. -- Max