From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
To: Sakari Ailus <sakari.ailus@iki.fi>
Cc: Sakari Ailus <sakari.ailus@linux.intel.com>,
"Rafael J. Wysocki" <rafael@kernel.org>,
linux-i2c <linux-i2c@vger.kernel.org>,
Wolfram Sang <wsa@the-dreams.de>,
linux-acpi@vger.kernel.org, Bingbu Cao <bingbu.cao@intel.com>,
linux-media <linux-media@vger.kernel.org>,
Chiranjeevi Rapolu <chiranjeevi.rapolu@intel.com>,
Hyungwoo Yang <hyungwoo.yang@intel.com>,
Arnd Bergmann <arnd@arndb.de>,
LKML <linux-kernel@vger.kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Rajmohan Mani <rajmohan.mani@intel.com>,
Tomasz Figa <tfiga@chromium.org>
Subject: Re: [PATCH v4 5/6] at24: Support probing while off
Date: Mon, 10 Aug 2020 20:12:00 +0200 [thread overview]
Message-ID: <CAMpxmJUKSR-oCGnV1E5XiAMA2nYBy5f_f8=VSoMn0zf+qF39vg@mail.gmail.com> (raw)
In-Reply-To: <20200810082549.GD840@valkosipuli.retiisi.org.uk>
On Mon, Aug 10, 2020 at 10:26 AM Sakari Ailus <sakari.ailus@iki.fi> wrote:
>
[snip]
> >
> > Rafael: I think that there are two issues with patch 1/5:
> > 1. It adds a very specific boolean flag to a structure that's meant to
> > be very general. As I pointed out in the i2c patch: at the very least
> > this could be made into an int storing flag values, instead of a
> > boolean field. But rather than that - it looks to me more like a
> > device (or bus) feature than a driver feature. Is there any ACPI flag
> > we could use to pass this information to the driver model without
> > changing the driver structure?
>
> To my knowledge there isn't. The fact that I²C devices are powered on for
> probe in ACPI based systems is specific to Linux kernel and not ACPI as
> such.
>
> The reason this needs to be in a generic struct is that the device's power
> state will be changed before any interaction with the driver takes place as
> it's the I²C framework that powers on the device.
>
I'm not sure I'm following. Looking at patch 1/6 struct device already
exists so why can't this information be conveyed "per device" as
opposed to "per driver"?
[snip]
Bartosz
next prev parent reply other threads:[~2020-08-10 18:12 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-21 13:41 [PATCH v4 0/6] Support running driver's probe for a device powered off Sakari Ailus
2020-01-21 13:41 ` [PATCH v4 1/6] i2c: Allow driver to manage the device's power state during probe Sakari Ailus
2020-01-29 13:54 ` Bartosz Golaszewski
2020-03-23 21:36 ` Sakari Ailus
2020-01-21 13:41 ` [PATCH v4 2/6] ACPI: Add a convenience function to tell a device is in low power state Sakari Ailus
2020-01-21 16:07 ` Rafael J. Wysocki
2020-01-21 13:41 ` [PATCH v4 3/6] ov5670: Support probe whilst the device is in a " Sakari Ailus
2020-01-21 13:41 ` [PATCH v4 4/6] media: i2c: imx319: Support probe while the device is off Sakari Ailus
2020-01-21 13:41 ` [PATCH v4 5/6] at24: Support probing while off Sakari Ailus
2020-01-29 13:36 ` Bartosz Golaszewski
2020-03-11 8:55 ` Sakari Ailus
2020-03-12 13:10 ` Bartosz Golaszewski
2020-03-23 21:31 ` Sakari Ailus
2020-03-25 13:48 ` Bartosz Golaszewski
2020-08-10 8:25 ` Sakari Ailus
2020-08-10 18:12 ` Bartosz Golaszewski [this message]
2020-08-11 8:00 ` Sakari Ailus
2020-08-12 18:07 ` Bartosz Golaszewski
2020-08-12 19:25 ` Wolfram Sang
2020-08-12 19:33 ` Bartosz Golaszewski
2020-01-21 13:41 ` [PATCH v4 6/6] Documentation: ACPI: Document probe-low-power _DSD property Sakari Ailus
2020-01-21 16:09 ` Rafael J. Wysocki
2020-01-21 16:18 ` Sakari Ailus
2020-01-21 16:56 ` Rafael J. Wysocki
2020-01-21 16:58 ` Sakari Ailus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMpxmJUKSR-oCGnV1E5XiAMA2nYBy5f_f8=VSoMn0zf+qF39vg@mail.gmail.com' \
--to=bgolaszewski@baylibre.com \
--cc=arnd@arndb.de \
--cc=bingbu.cao@intel.com \
--cc=chiranjeevi.rapolu@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=hyungwoo.yang@intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=rajmohan.mani@intel.com \
--cc=sakari.ailus@iki.fi \
--cc=sakari.ailus@linux.intel.com \
--cc=tfiga@chromium.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).