From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5A976C3A5A9 for ; Wed, 4 Sep 2019 06:57:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2BE652339D for ; Wed, 4 Sep 2019 06:57:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20150623.gappssmtp.com header.i=@baylibre-com.20150623.gappssmtp.com header.b="Pvsm0jkN" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728951AbfIDG55 (ORCPT ); Wed, 4 Sep 2019 02:57:57 -0400 Received: from mail-ot1-f68.google.com ([209.85.210.68]:33314 "EHLO mail-ot1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728921AbfIDG54 (ORCPT ); Wed, 4 Sep 2019 02:57:56 -0400 Received: by mail-ot1-f68.google.com with SMTP id p23so19574783oto.0 for ; Tue, 03 Sep 2019 23:57:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=Dt75WhUIfHVQfvigwZn6/besGZVEJEtBIQcEOqZ+B54=; b=Pvsm0jkNiRhObMK4vm9PFjK6gDG1RInx1dfQIY+anapAMmQ7BBqa+FSp2oQcED/5ZB fMFHq1bQSJaQxWDjSZDwYSgSZiGzcMYKOHp3BHHpvmkR/bFVtnN1/nZhEyIerU3Ius5Z nhj9GQwxsboOGg+Xy6lXBu8TMN5aY7NAg746v/3ONWMWbQRN3cS84RI2pA4veYqocRhW Tk70wmmQirUWHbVtRF2QYa5Fa7ZUVBzx4h5df3jv2vIplCQB6rnVK09hgrU5zieTdwdI HxM/Gs7C8qN25BCH3ub6QKRMsgVuWSajuOJsabMCCXmOevSJjqfqamqw3aKhEiPWNJMV /Q6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=Dt75WhUIfHVQfvigwZn6/besGZVEJEtBIQcEOqZ+B54=; b=erDtQ3vl0KhOZ8wx3Bc6BcPB8NqQztsY7iVjrl9lLk+bhSzHMDKxxIFXg7HxNy9O13 IU5nHckmjVwpwON48I5iUFjamcJ5MGNgiPulLCUR3nZ/xY/XgVfDR+k/zV90rzwZhMz5 8Hd8yNdGwx3kheQF49fzIlPCJRKmzpQPeZ5OoAEV0sZORA9tS3OobQdTM7mgaAqEf3EW PGNSsxRHEkaTqBiI90BpXVpjZ3DzGnM4d78J/mdHLItfzfpd8fmhUoSPnSDge1nml5q5 4mqHTRz9MHNVwiXL2iZsJHI3zD5N0dU30OIiM9a01pErJH8fNtFisr3xexrWmVe2xkLU nCng== X-Gm-Message-State: APjAAAVc+4aHVjeUZQsc33Rj/d26yUgsbkmeGXX3IVHnAUFhyHT9+QUQ 8jWCXxkSwNNFbp9p51kmwKBi1nKEMjp8/4GBBHR6Dg== X-Google-Smtp-Source: APXvYqwU0uoAvsRitFcgVrGOxLPCnceC5cmEGe0+fYS1mNopOondiib3itWCLOA9ZD86Hadp9khJFTIPsIhusxb2mrI= X-Received: by 2002:a9d:6c0d:: with SMTP id f13mr1329516otq.85.1567580275770; Tue, 03 Sep 2019 23:57:55 -0700 (PDT) MIME-Version: 1.0 References: <20190904061245.30770-1-rashmica.g@gmail.com> In-Reply-To: <20190904061245.30770-1-rashmica.g@gmail.com> From: Bartosz Golaszewski Date: Wed, 4 Sep 2019 08:57:44 +0200 Message-ID: Subject: Re: [PATCH 1/4] gpio/aspeed: Fix incorrect number of banks To: Rashmica Gupta Cc: Linus Walleij , linux-gpio , arm-soc , linux-aspeed@lists.ozlabs.org, LKML , Joel Stanley , Andrew Jeffery Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org =C5=9Br., 4 wrz 2019 o 08:13 Rashmica Gupta napisa= =C5=82(a): > > Fixes: 361b79119a4b7 ('gpio: Add Aspeed driver') > Please, add a proper commit description. Checkpatch should have warned you about it. Bart > Signed-off-by: Rashmica Gupta > --- > drivers/gpio/gpio-aspeed.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpio/gpio-aspeed.c b/drivers/gpio/gpio-aspeed.c > index 9defe25d4721..77752b2624e8 100644 > --- a/drivers/gpio/gpio-aspeed.c > +++ b/drivers/gpio/gpio-aspeed.c > @@ -1165,7 +1165,7 @@ static int __init aspeed_gpio_probe(struct platform= _device *pdev) > gpio->chip.base =3D -1; > > /* Allocate a cache of the output registers */ > - banks =3D gpio->config->nr_gpios >> 5; > + banks =3D (gpio->config->nr_gpios >> 5) + 1; > gpio->dcache =3D devm_kcalloc(&pdev->dev, > banks, sizeof(u32), GFP_KERNEL); > if (!gpio->dcache) > -- > 2.20.1 >