From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9BD2CC072B5 for ; Fri, 24 May 2019 07:03:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5BAC021841 for ; Fri, 24 May 2019 07:03:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20150623.gappssmtp.com header.i=@baylibre-com.20150623.gappssmtp.com header.b="VrpPEWTy" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388955AbfEXHD0 (ORCPT ); Fri, 24 May 2019 03:03:26 -0400 Received: from mail-oi1-f193.google.com ([209.85.167.193]:46386 "EHLO mail-oi1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388260AbfEXHD0 (ORCPT ); Fri, 24 May 2019 03:03:26 -0400 Received: by mail-oi1-f193.google.com with SMTP id 203so6259164oid.13 for ; Fri, 24 May 2019 00:03:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=ggAqQCZOVRZtFKzDVVtPukGfGP3OkJTZeJtZud1HmIk=; b=VrpPEWTyV7w/xBs02DOpEB2wHeHLcT5gaBjDP3+JsnrYHNsdP/gHQs/91puwpoSwjk lI+Q6BKnQWGbZSAcUtt+qBmgzxJjPIehh1lqAs6zBvLLVtSJU1dc35uKKxtIBPJtRdrJ +MPG8/Oig2M2xOLcbZ64OB9F6H9f++/ZIRGdX42UUQsXKaSVQZ8/+UdKxOEbPLku9DGm I0LkfKw8RXhb40SCoxN2zrMDPkMYzDuAZBdjPtYIAUZd/45cIRRlB2GRyl+oXe8kO0vq EhA+pIJE+8ehAjGmHvnAsFwTB2JCRZCsdF50f5UCREyiZEYmM9S0D5/A1eNVUXS+FJwR PUGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=ggAqQCZOVRZtFKzDVVtPukGfGP3OkJTZeJtZud1HmIk=; b=UjHugAtp0ccA6b47F8HlHMHYiBabArflrHMC1OZimXyfWcp+AgwDENA2seIRAKtfXX 2pZPl8jQwMLuW4eCRzyo9yZCsnxY4tZGVK0Pem5hd4zTIDfnHXxO3jo5/J8MZDlX1VNC pQ2CzDyrCxXIZDVSjOLcCfwvS4CTJNJN6F+K/4jGCwIpRvk8BjSB0w05DJPAV4u4Zf+6 4kl+9XpcmuR0k8VWcx5evlEYFCesMuu7Xza4xrCdp4L695/plkvmcc/4LfQPkWe5Y8bF AzZ/XSdOv5Qt0FKAF3GraUrLlUcVB5mL7MQ70r80vqqNi0UZGw/i2RlmsafwHOUZIjtB s8jw== X-Gm-Message-State: APjAAAUpuKqbVrmfThZfhwf76jRg8DX3rdGFYhZBxKs34yxVJZNWRHlj JTiS/sPIM6vtCKurA6uLBEI0Io+oPpjH/ZIZWT7RsA== X-Google-Smtp-Source: APXvYqxAbBUuROv5rdCa31jOH1GdpIUh2srX0z4DRxWpYcHFRalRwK2qR7nmEndZPgcFAvpYqZyxeAGzKrIjF2xYEU8= X-Received: by 2002:aca:4e42:: with SMTP id c63mr5486438oib.170.1558681405264; Fri, 24 May 2019 00:03:25 -0700 (PDT) MIME-Version: 1.0 References: <8054bec0-ea24-8590-738b-bae58c0be3b4@infradead.org> In-Reply-To: <8054bec0-ea24-8590-738b-bae58c0be3b4@infradead.org> From: Bartosz Golaszewski Date: Fri, 24 May 2019 09:03:14 +0200 Message-ID: Subject: Re: [PATCH] gpio: fix gpio-adp5588 build errors To: Randy Dunlap Cc: LKML , "linux-gpio@vger.kernel.org" , kbuild test robot , Michael Hennerich , Linus Walleij Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org pt., 24 maj 2019 o 00:00 Randy Dunlap napisa=C5=82(= a): > > From: Randy Dunlap > > The gpio-adp5588 driver uses interfaces that are provided by > GPIOLIB_IRQCHIP, so select that symbol in its Kconfig entry. > > Fixes these build errors: > > ../drivers/gpio/gpio-adp5588.c: In function =E2=80=98adp5588_irq_handler= =E2=80=99: > ../drivers/gpio/gpio-adp5588.c:266:26: error: =E2=80=98struct gpio_chip= =E2=80=99 has no member named =E2=80=98irq=E2=80=99 > dev->gpio_chip.irq.domain, gpio)); > ^ > ../drivers/gpio/gpio-adp5588.c: In function =E2=80=98adp5588_irq_setup=E2= =80=99: > ../drivers/gpio/gpio-adp5588.c:298:2: error: implicit declaration of func= tion =E2=80=98gpiochip_irqchip_add_nested=E2=80=99 [-Werror=3Dimplicit-func= tion-declaration] > ret =3D gpiochip_irqchip_add_nested(&dev->gpio_chip, > ^ > ../drivers/gpio/gpio-adp5588.c:307:2: error: implicit declaration of func= tion =E2=80=98gpiochip_set_nested_irqchip=E2=80=99 [-Werror=3Dimplicit-func= tion-declaration] > gpiochip_set_nested_irqchip(&dev->gpio_chip, > ^ > > Fixes: 459773ae8dbb ("gpio: adp5588-gpio: support interrupt controller") > > Reported-by: kbuild test robot > Signed-off-by: Randy Dunlap > Cc: Michael Hennerich > Cc: Linus Walleij > Cc: Bartosz Golaszewski > Cc: linux-gpio@vger.kernel.org > --- > drivers/gpio/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > --- lnx-52-rc1.orig/drivers/gpio/Kconfig > +++ lnx-52-rc1/drivers/gpio/Kconfig > @@ -822,6 +822,7 @@ config GPIO_ADP5588 > config GPIO_ADP5588_IRQ > bool "Interrupt controller support for ADP5588" > depends on GPIO_ADP5588=3Dy > + select GPIOLIB_IRQCHIP > help > Say yes here to enable the adp5588 to be used as an interrupt > controller. It requires the driver to be built in the kernel. > > Reviewed-by: Bartosz Golaszewski