From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E00DEC4708F for ; Wed, 2 Jun 2021 13:36:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C40FF61168 for ; Wed, 2 Jun 2021 13:36:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229807AbhFBNho (ORCPT ); Wed, 2 Jun 2021 09:37:44 -0400 Received: from mail-yb1-f182.google.com ([209.85.219.182]:39583 "EHLO mail-yb1-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229606AbhFBNhn (ORCPT ); Wed, 2 Jun 2021 09:37:43 -0400 Received: by mail-yb1-f182.google.com with SMTP id n133so3854023ybf.6 for ; Wed, 02 Jun 2021 06:36:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=7y54rKSNGdkrAUoqhpn2Fjw3daxbe/zgPvjMo8fDxkE=; b=AODZrLfxfp66ey27tmS+muPaAjACfDUTxc4po/MAna8MQA+SUqwFY+DzYotk5VQmFz A3uFbRcWP9hFFVGGMpKUZKnsPwRbPAuDjUX83+Tjm3eWOBxXAeIaQqR9dM0/caOKFXsr 7BrGLNaqcoajWLB8cpZhAoZKJGS4dKkgWhHXMO0TDTMlQ3wSdtJjEHJlXnqv/+mDcmZ9 Fn8DwMbbCRh3s33NwVhPfYVn30y3iIVD/Kq/bC+McVp3V98WqlYrnVXe00J0I0pdTAv/ Xs4Za4E8yUTxeN+/N4vOcdSzHzY4r52v1FSk+JmRwmtAakNERCGEAvmt6ga6QlvwuCey YOlQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=7y54rKSNGdkrAUoqhpn2Fjw3daxbe/zgPvjMo8fDxkE=; b=hWwLQA3HODJ009I/Z1nl9mGUcMChpG0S18ixwI3O5LIngOYdFs/AKCxGuDekV+0i9k L6S3RdfCGJRNXc/brbGQYMGYZdt0xfQ+zAqT6ePppic0d+Q9vi4cnCFLOA4s3C5+su7D mglfBaWUS1wh+InBKWkkF6ztVg3oILXWzAzlv1UTQ+zm5CCqIwd//jRuKXWskMi0Kn/I DUJy3DhebgQJNa+k2DSu2ZtsO0T2WVPso//PXSZ6GgQdf6FT1Ndyx+CeWTaXoQiIANq3 /Ok8X4P79TGZWy5Z7AchJR8okSZ/yRo8R3bBRbB6gbZIGiWQvCrUQOFtt5+iXpOKmMRM qrIQ== X-Gm-Message-State: AOAM5336H1RAQny92QMGdbBzLS1asheqvA2loitJLvuV5CEyBsIy0rOZ UIkyLQXLVyhXi0Q5uAUHhG1CiFTQvU0U5qmzqtZBlQ== X-Google-Smtp-Source: ABdhPJwkyaLtGdIx4nMxydwWEO4QUlZ0SxgiPZQ9ls0Flty1oFgxtpYosn6RTHF4g6tKQlJ+IcVK7yH6YgU5Oe3D8R0= X-Received: by 2002:a25:1b0b:: with SMTP id b11mr48646766ybb.302.1622640900244; Wed, 02 Jun 2021 06:35:00 -0700 (PDT) MIME-Version: 1.0 References: <20210601162128.35663-1-andriy.shevchenko@linux.intel.com> In-Reply-To: <20210601162128.35663-1-andriy.shevchenko@linux.intel.com> From: Bartosz Golaszewski Date: Wed, 2 Jun 2021 15:34:49 +0200 Message-ID: Subject: Re: [PATCH v1 1/2] gpio: dwapb: Drop redundant check in dwapb_irq_set_type() To: Andy Shevchenko Cc: Serge Semin , linux-gpio , LKML , Hoan Tran , Serge Semin , Linus Walleij Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 1, 2021 at 6:21 PM Andy Shevchenko wrote: > > For more than 15 years we may not get into ->irq_set_type() > without any meaningful type provided. > > Drop redundant check in dwapb_irq_set_type(). > > See the commit e76de9f8eb67 ("[PATCH] genirq: add SA_TRIGGER support") > out of curiosity. > > Signed-off-by: Andy Shevchenko > --- > drivers/gpio/gpio-dwapb.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/gpio/gpio-dwapb.c b/drivers/gpio/gpio-dwapb.c > index d3233cc4b76b..939701c1465e 100644 > --- a/drivers/gpio/gpio-dwapb.c > +++ b/drivers/gpio/gpio-dwapb.c > @@ -297,9 +297,6 @@ static int dwapb_irq_set_type(struct irq_data *d, u32 type) > irq_hw_number_t bit = irqd_to_hwirq(d); > unsigned long level, polarity, flags; > > - if (type & ~IRQ_TYPE_SENSE_MASK) > - return -EINVAL; > - > spin_lock_irqsave(&gc->bgpio_lock, flags); > level = dwapb_read(gpio, GPIO_INTTYPE_LEVEL); > polarity = dwapb_read(gpio, GPIO_INT_POLARITY); > -- > 2.30.2 > Applied, thanks! Bart