From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BA752C47077 for ; Tue, 12 May 2020 17:12:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 990CF206B8 for ; Tue, 12 May 2020 17:12:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20150623.gappssmtp.com header.i=@baylibre-com.20150623.gappssmtp.com header.b="Yf7kJP8T" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729427AbgELRMu (ORCPT ); Tue, 12 May 2020 13:12:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35406 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726367AbgELRMt (ORCPT ); Tue, 12 May 2020 13:12:49 -0400 Received: from mail-qk1-x743.google.com (mail-qk1-x743.google.com [IPv6:2607:f8b0:4864:20::743]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 79717C05BD09 for ; Tue, 12 May 2020 10:12:49 -0700 (PDT) Received: by mail-qk1-x743.google.com with SMTP id f189so8726826qkd.5 for ; Tue, 12 May 2020 10:12:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=mhXIarFJGq4Y7o1OACEMY+CWjpNuyCrBkx0AvhbST58=; b=Yf7kJP8TPOhuvK1QsyJFscagmDUQZK+pL/Y6v6hbW+/t58l6484/Vvudp5TmsD66Vt ZONixv6Z6GQNvj9xxmrbpKfZiHkllK9oOmUj03VSq3CnB7zHzAVUu0g4gk29zJgYIFnZ f5hjoYCB9IISk16xC5+FX5Ym/KaPYaNpy0AbL8QM25gdCBcZje70QIw0LwxqIbXeRMvH axOI0kqzxQOK6xsNSCwvEpQITI75sAyJ/ZvIz+WtxJdlU0TE/X+D1Vu5mySY0N6NauSH OyaW5sRpqz6N97CnWlBFBDTjsjG8qXyEDp73cGlwoZejHPhUyHE5YsJ4olE9CWho31jJ mLsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=mhXIarFJGq4Y7o1OACEMY+CWjpNuyCrBkx0AvhbST58=; b=eRs/nPGnQybWuAHAxzI8IVSVnr0FMbZy+Ss/k4GD9vpa0IIeuQ8KFOkov7ZFLu8e44 den2ik11YN84+kNFH5NIaGVHzT8sYMJA94L9LK7Ps/mwY+oHgGPPmZFff0ojZ2P1hFe8 dRx1S/DaFEjy4Nh9JWUCIa7Lrt6C2UTHsx2YJJGXRk8gsLOc/pQveQDriGdzN0pxjk1w 10ichdZbgnG65TJU8fKpWc2BTAL20uyGpWyVefkD4ddG3H9yIFFFGNKIT0Fd5LiE5ZYj 9qVhAPSaszGxQaFW0BPoPFg/Spty5FXVqSNi3Ifx9vq2ohiljIm0S4d6+KBRS/EnV5r4 BIrw== X-Gm-Message-State: AGi0PuZhjsJkhVYxA58rXjAyMya1xcAz7Mqvy+2W6SPQToB5u8Oibdty oXmuiGOS/+dSWqyZn3OFwM4PB/Oxz2PYiLR6D7YQIA== X-Google-Smtp-Source: APiQypJIMsGtzThZyW1lqSg5Tc9VmY8HlcF1qXM8u4OPF55cPNjhQjFyV5VLPhxjjL+KT0ArViJcIzRkt1OOy/WCwhY= X-Received: by 2002:a37:5b47:: with SMTP id p68mr15632193qkb.120.1589303568424; Tue, 12 May 2020 10:12:48 -0700 (PDT) MIME-Version: 1.0 References: <20200430143019.1704-1-brgl@bgdev.pl> <20200430143019.1704-3-brgl@bgdev.pl> <6568919d6cc3ee8f602a58354e3aff44@kernel.org> In-Reply-To: <6568919d6cc3ee8f602a58354e3aff44@kernel.org> From: Bartosz Golaszewski Date: Tue, 12 May 2020 19:12:37 +0200 Message-ID: Subject: Re: [PATCH v4 2/2] irq/irq_sim: simplify the API To: Marc Zyngier Cc: Bartosz Golaszewski , Linus Walleij , Jonathan Cameron , Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler , Thomas Gleixner , Jason Cooper , linux-gpio , LKML , linux-iio@vger.kernel.org, Jonathan Cameron Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org wt., 12 maj 2020 o 17:37 Marc Zyngier napisa=C5=82(a): > > > - */ > > -int irq_sim_irqnum(struct irq_sim *sim, unsigned int offset) > > -{ > > - return sim->irqs[offset].irqnum; > > + irq_ctx =3D irq_data_get_irq_chip_data(irqd); > > + > > + if (irq_ctx->enabled) { > > + set_bit(irqd_to_hwirq(irqd), irq_ctx->work_ctx->pending); > > + irq_work_queue(&irq_ctx->work_ctx->work); > > + } > > } > > -EXPORT_SYMBOL_GPL(irq_sim_irqnum); > > +EXPORT_SYMBOL_GPL(irq_sim_fire); > > Rather than using an ad-hoc API to queue an interrupt, why don't you > actually implement the interface that already exists for this at > the irqchip level (irq_set_irqchip_state, which allows the pending > state to be set)? > Yes, this is great, thanks for bringing this to my attention. I can drop another function from the API. Bart