From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: "Mark-MC.Lee" <Mark-MC.Lee@mediatek.com>,
linux-devicetree <devicetree@vger.kernel.org>,
Felix Fietkau <nbd@openwrt.org>, Arnd Bergmann <arnd@arndb.de>,
netdev <netdev@vger.kernel.org>,
Bartosz Golaszewski <brgl@bgdev.pl>,
Sean Wang <sean.wang@mediatek.com>,
LKML <linux-kernel@vger.kernel.org>,
Fabien Parent <fparent@baylibre.com>,
Rob Herring <robh+dt@kernel.org>,
linux-mediatek@lists.infradead.org,
John Crispin <john@phrozen.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Jakub Kicinski <kuba@kernel.org>,
"David S . Miller" <davem@davemloft.net>,
arm-soc <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 06/11] net: ethernet: mtk-eth-mac: new driver
Date: Thu, 7 May 2020 19:01:42 +0200 [thread overview]
Message-ID: <CAMpxmJV7xGhE4DoZAEYg=wjE-a1MEnc7carZ39zdvWtKAp+qfA@mail.gmail.com> (raw)
In-Reply-To: <20200507131645.GM208718@lunn.ch>
czw., 7 maj 2020 o 15:16 Andrew Lunn <andrew@lunn.ch> napisał(a):
>
> On Thu, May 07, 2020 at 12:50:15PM +0200, Bartosz Golaszewski wrote:
> > czw., 7 maj 2020 o 11:46 Mark-MC.Lee <Mark-MC.Lee@mediatek.com> napisał(a):
> > >
> > > Hi Bartosz:
> > > I think the naming of this driver and its Kconfig option is too generic
> > > that will confuse with current mediatek SoCs eth driver architecture(for
> > > all mt7xxx SoCs).
> > > Since mtk_eth_mac.c is not a common MAC part for all mediatek SoC but
> > > only a specific eth driver for mt85xx, it will be more reasonable to
> > > name it as mt85xx_eth.c and change NET_MEDIATEK_MAC to
> > > NET_MEDIATEK_MT85XX. How do you think?
> > >
> >
> > Hi Mark,
> >
> > I actually consulted this with MediaTek and the name is their idea.
> > Many drivers in drivers/net/ethernet have very vague names. I guess
> > this isn't a problem.
>
> They have vague names, but they tend to be not confusing.
>
> NET_MEDIATEK_MAC vs NET_MEDIATEK_SOC is confusing.
>
> I think the proposed name, mt85xx_eth.c and NET_MEDIATEK_MT85XX is
> good. Or some variant on this, mt8xxx?
>
I've just verified with MediaTek that this IP will be used in future
designs as well - even on ones that don't share the mt8* prefix. It
doesn't really have a name though by itself. How much confusion can it
cause anyway? People who want to compile this driver will know which
one to choose, right? It's not like it's an i2c component shared
across many board designs.
Bart
next prev parent reply other threads:[~2020-05-07 17:01 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-05 14:02 [PATCH 00/11] mediatek: add support for MediaTek Ethernet MAC Bartosz Golaszewski
2020-05-05 14:02 ` [PATCH 01/11] dt-bindings: add a binding document for MediaTek PERICFG controller Bartosz Golaszewski
2020-05-13 2:38 ` Rob Herring
2020-05-13 8:09 ` Bartosz Golaszewski
2020-05-05 14:02 ` [PATCH 02/11] dt-bindings: new: add yaml bindings for MediaTek Ethernet MAC Bartosz Golaszewski
2020-05-13 2:41 ` Rob Herring
2020-05-05 14:02 ` [PATCH 03/11] net: ethernet: mediatek: rename Kconfig prompt Bartosz Golaszewski
2020-05-05 14:02 ` [PATCH 04/11] net: ethernet: mediatek: remove unnecessary spaces from Makefile Bartosz Golaszewski
2020-05-05 14:02 ` [PATCH 05/11] net: core: provide devm_register_netdev() Bartosz Golaszewski
2020-05-05 17:31 ` Jakub Kicinski
2020-05-06 6:39 ` Bartosz Golaszewski
2020-05-06 17:12 ` Jakub Kicinski
2020-05-07 9:25 ` Bartosz Golaszewski
2020-05-07 16:53 ` Jakub Kicinski
2020-05-07 17:03 ` Bartosz Golaszewski
2020-05-07 22:56 ` Jakub Kicinski
2020-05-08 5:54 ` Heiner Kallweit
2020-05-08 18:39 ` Bartosz Golaszewski
2020-05-05 19:25 ` Edwin Peer
2020-05-06 6:46 ` Bartosz Golaszewski
2020-05-06 18:20 ` Edwin Peer
2020-05-05 14:02 ` [PATCH 06/11] net: ethernet: mtk-eth-mac: new driver Bartosz Golaszewski
2020-05-05 17:47 ` Andrew Lunn
2020-05-06 7:02 ` Bartosz Golaszewski
2020-05-05 18:04 ` Jakub Kicinski
2020-05-06 7:09 ` Bartosz Golaszewski
2020-05-06 17:19 ` Jakub Kicinski
2020-05-06 19:16 ` Leon Romanovsky
2020-05-06 19:23 ` Jakub Kicinski
2020-05-07 5:55 ` Leon Romanovsky
2020-05-07 22:50 ` Jakub Kicinski
2020-05-06 19:24 ` Joe Perches
[not found] ` <1588844771.5921.27.camel@mtksdccf07>
2020-05-07 10:50 ` Bartosz Golaszewski
2020-05-07 13:16 ` Andrew Lunn
2020-05-07 17:01 ` Bartosz Golaszewski [this message]
2020-05-05 14:02 ` [PATCH 07/11] ARM64: dts: mediatek: add pericfg syscon to mt8516.dtsi Bartosz Golaszewski
2020-05-05 14:02 ` [PATCH 08/11] ARM64: dts: mediatek: add the ethernet node " Bartosz Golaszewski
2020-05-05 14:02 ` [PATCH 09/11] ARM64: dts: mediatek: add an alias for ethernet0 for pumpkin boards Bartosz Golaszewski
2020-05-05 14:02 ` [PATCH 10/11] ARM64: dts: mediatek: add ethernet pins " Bartosz Golaszewski
2020-05-05 14:02 ` [PATCH 11/11] ARM64: dts: mediatek: enable ethernet on " Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMpxmJV7xGhE4DoZAEYg=wjE-a1MEnc7carZ39zdvWtKAp+qfA@mail.gmail.com' \
--to=bgolaszewski@baylibre.com \
--cc=Mark-MC.Lee@mediatek.com \
--cc=andrew@lunn.ch \
--cc=arnd@arndb.de \
--cc=brgl@bgdev.pl \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=fparent@baylibre.com \
--cc=john@phrozen.org \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=nbd@openwrt.org \
--cc=netdev@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=sean.wang@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).