From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
To: Vignesh Raghavendra <vigneshr@ti.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
linux-gpio <linux-gpio@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Grygorii Strashko <grygorii.strashko@ti.com>
Subject: Re: [PATCH v2] gpio: pca953x: Don't hardcode irq trigger type
Date: Wed, 11 Dec 2019 10:47:11 +0100 [thread overview]
Message-ID: <CAMpxmJVLZfvh0p0qpcS+V3Cwuv-mi6o-hO5X-JThj-T_0dOCVw@mail.gmail.com> (raw)
In-Reply-To: <20191209062749.26429-1-vigneshr@ti.com>
pon., 9 gru 2019 o 07:27 Vignesh Raghavendra <vigneshr@ti.com> napisał(a):
>
> Don't hardcode irq trigger to IRQF_TRIGGER_LOW while registering IRQ
> handler. IRQ/platform core will take care of setting appropriate trigger
> type.
>
> Signed-off-by: Vignesh Raghavendra <vigneshr@ti.com>
> ---
> v2:
> Drop explicit call to irq_get_trigger_type() as this is take care of in core
> code.
>
> drivers/gpio/gpio-pca953x.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/gpio/gpio-pca953x.c b/drivers/gpio/gpio-pca953x.c
> index 6652bee01966..40e48f7d83bb 100644
> --- a/drivers/gpio/gpio-pca953x.c
> +++ b/drivers/gpio/gpio-pca953x.c
> @@ -770,8 +770,7 @@ static int pca953x_irq_setup(struct pca953x_chip *chip, int irq_base)
>
> ret = devm_request_threaded_irq(&client->dev, client->irq,
> NULL, pca953x_irq_handler,
> - IRQF_TRIGGER_LOW | IRQF_ONESHOT |
> - IRQF_SHARED,
> + IRQF_ONESHOT | IRQF_SHARED,
> dev_name(&client->dev), chip);
> if (ret) {
> dev_err(&client->dev, "failed to request irq %d\n",
> --
> 2.24.0
>
Patch applied, thanks!
Bartosz
prev parent reply other threads:[~2019-12-11 9:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-09 6:27 [PATCH v2] gpio: pca953x: Don't hardcode irq trigger type Vignesh Raghavendra
2019-12-11 9:47 ` Bartosz Golaszewski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMpxmJVLZfvh0p0qpcS+V3Cwuv-mi6o-hO5X-JThj-T_0dOCVw@mail.gmail.com \
--to=bgolaszewski@baylibre.com \
--cc=grygorii.strashko@ti.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).