From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
To: Jon Hunter <jonathanh@nvidia.com>
Cc: Rob Herring <robh+dt@kernel.org>,
Thierry Reding <thierry.reding@gmail.com>,
linux-i2c <linux-i2c@vger.kernel.org>,
linux-devicetree <devicetree@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
linux-tegra@vger.kernel.org
Subject: Re: [PATCH V2 1/5] misc: eeprom: at24: Initialise AT24 NVMEM ID field
Date: Thu, 24 Sep 2020 15:14:24 +0200 [thread overview]
Message-ID: <CAMpxmJVqEHBZRTxwK1Dviz2MH=MUpNbUdtkVLjn0E2BM_HiCbQ@mail.gmail.com> (raw)
In-Reply-To: <20200916094952.458003-2-jonathanh@nvidia.com>
On Wed, Sep 16, 2020 at 11:50 AM Jon Hunter <jonathanh@nvidia.com> wrote:
>
> The AT24 EEPROM driver does not initialise the 'id' field of the
> nvmem_config structure and because the entire structure is not
> initialised, it ends up with a random value. This causes the NVMEM
> driver to append the device 'devid' value to name of the NVMEM
> device. Ideally for I2C devices such as the AT24 that already have a
> unique name, we would not bother to append the 'devid'. However, given
> that this has always been done for AT24 devices, we cannot remove the
> 'devid' as this will change the name of the userspace sysfs node for
> the NVMEM device. Nonetheless we should ensure that the 'id' field of
> the nvmem_config structure is initialised so that there is no chance of
> a random value causes problems in the future. Therefore, set the NVMEM
> config.id to NVMEM_DEVID_AUTO for AT24 EEPROMs so that the 'devid' is
> always appended.
>
> Signed-off-by: Jon Hunter <jonathanh@nvidia.com>
> ---
> drivers/misc/eeprom/at24.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/misc/eeprom/at24.c b/drivers/misc/eeprom/at24.c
> index e9df1ca251df..f76624b5c033 100644
> --- a/drivers/misc/eeprom/at24.c
> +++ b/drivers/misc/eeprom/at24.c
> @@ -715,6 +715,7 @@ static int at24_probe(struct i2c_client *client)
>
> nvmem_config.name = dev_name(dev);
> nvmem_config.dev = dev;
> + nvmem_config.id = NVMEM_DEVID_AUTO;
> nvmem_config.read_only = !writable;
> nvmem_config.root_only = !(flags & AT24_FLAG_IRUGO);
> nvmem_config.owner = THIS_MODULE;
> --
> 2.25.1
>
Ha! I only now noticed I already have a patch for this in my tree from
Vadym Kochan for this cycle. I'll drop this one.
Bartosz
next prev parent reply other threads:[~2020-09-24 13:14 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-16 9:49 [PATCH V2 0/5] Add support for custom names for AT24 EEPROMs Jon Hunter
2020-09-16 9:49 ` [PATCH V2 1/5] misc: eeprom: at24: Initialise AT24 NVMEM ID field Jon Hunter
2020-09-24 13:14 ` Bartosz Golaszewski [this message]
2020-09-24 13:17 ` Bartosz Golaszewski
2020-09-16 9:49 ` [PATCH V2 2/5] dt-bindings: eeprom: at24: Add label property for AT24 Jon Hunter
2020-09-23 15:32 ` Rob Herring
2020-09-24 13:25 ` Bartosz Golaszewski
2020-09-16 9:49 ` [PATCH V2 3/5] misc: eeprom: at24: Support custom device names for AT24 EEPROMs Jon Hunter
2020-09-24 13:25 ` Bartosz Golaszewski
2020-09-16 9:49 ` [PATCH V2 4/5] arm64: tegra: Add label properties for EEPROMs Jon Hunter
2020-09-16 9:49 ` [PATCH V2 5/5] arm64: tegra: Populate EEPROMs for Jetson Xavier NX Jon Hunter
2020-09-23 9:15 ` [PATCH V2 0/5] Add support for custom names for AT24 EEPROMs Bartosz Golaszewski
2020-09-23 9:23 ` Jon Hunter
2020-09-23 11:38 ` Thierry Reding
2020-09-23 11:43 ` Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMpxmJVqEHBZRTxwK1Dviz2MH=MUpNbUdtkVLjn0E2BM_HiCbQ@mail.gmail.com' \
--to=bgolaszewski@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=jonathanh@nvidia.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).