From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
To: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Frank Rowand <frowand.list@gmail.com>,
linux-gpio <linux-gpio@vger.kernel.org>,
linux-devicetree <devicetree@vger.kernel.org>,
arm-soc <linux-arm-kernel@lists.infradead.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 0/4] gpio: API boundary cleanups
Date: Tue, 10 Sep 2019 10:50:55 +0200 [thread overview]
Message-ID: <CAMpxmJVrQ92+ULRrzyN52LwEcdPTuK7OZssZjUcRPRSTBQ=fwg@mail.gmail.com> (raw)
In-Reply-To: <20190906084539.21838-1-geert+renesas@glider.be>
pt., 6 wrz 2019 o 10:45 Geert Uytterhoeven <geert+renesas@glider.be> napisał(a):
>
> Hi Linus, Bartosz,
>
> This patch series contains various API boundary cleanups for gpiolib:
> - The first two patches make two functions private,
> - The last two patches switch the remaining gpiolib exported functions
> from EXPORT_SYMBOL() to EXPORT_SYMBOL_GPL().
>
> After this there is only a single GPIO driver function exported with
> EXPORT_SYMBOL();
>
> drivers/gpio/gpio-htc-egpio.c:EXPORT_SYMBOL(htc_egpio_get_wakeup_irq);
>
> I believe this symbol was never used upstream, and may be a relic of the
> original out-of-tree code the htc-egpio was based on. I don't know if
> there (still) exist out-of-tree users of the symbol.
>
> Thanks for your comments!
All looks good to me. Are you fine with this being picked up after the
v5.4 merge window?
Bart
>
> Geert Uytterhoeven (4):
> gpio: of: Make of_get_named_gpiod_flags() private
> gpio: of: Make of_gpio_simple_xlate() private
> gpio: of: Switch to EXPORT_SYMBOL_GPL()
> gpio: devres: Switch to EXPORT_SYMBOL_GPL()
>
> drivers/gpio/gpiolib-devres.c | 28 ++++++++++++++--------------
> drivers/gpio/gpiolib-of.c | 16 ++++++++--------
> drivers/gpio/gpiolib-of.h | 7 -------
> include/linux/of_gpio.h | 11 -----------
> 4 files changed, 22 insertions(+), 40 deletions(-)
>
> --
> 2.17.1
>
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
> -- Linus Torvalds
next prev parent reply other threads:[~2019-09-10 8:51 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-06 8:45 [PATCH 0/4] gpio: API boundary cleanups Geert Uytterhoeven
2019-09-06 8:45 ` [PATCH 1/4] gpio: of: Make of_get_named_gpiod_flags() private Geert Uytterhoeven
2019-09-11 13:45 ` Linus Walleij
2019-09-06 8:45 ` [PATCH 2/4] gpio: of: Make of_gpio_simple_xlate() private Geert Uytterhoeven
2019-09-11 13:46 ` Linus Walleij
2019-09-06 8:45 ` [PATCH 3/4] gpio: of: Switch to EXPORT_SYMBOL_GPL() Geert Uytterhoeven
2019-09-11 13:47 ` Linus Walleij
2019-09-06 8:45 ` [PATCH 4/4] gpio: devres: " Geert Uytterhoeven
2019-09-11 13:48 ` Linus Walleij
2019-09-10 8:50 ` Bartosz Golaszewski [this message]
2019-09-10 8:59 ` [PATCH 0/4] gpio: API boundary cleanups Geert Uytterhoeven
2019-09-10 10:22 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMpxmJVrQ92+ULRrzyN52LwEcdPTuK7OZssZjUcRPRSTBQ=fwg@mail.gmail.com' \
--to=bgolaszewski@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=frowand.list@gmail.com \
--cc=geert+renesas@glider.be \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).