* [PATCH] gpio: sifive: select IRQ_DOMAIN_HIERARCHY rather than depend on it
@ 2021-01-19 3:18 Randy Dunlap
2021-01-19 11:10 ` Bartosz Golaszewski
0 siblings, 1 reply; 2+ messages in thread
From: Randy Dunlap @ 2021-01-19 3:18 UTC (permalink / raw)
To: linux-kernel
Cc: Randy Dunlap, Linus Walleij, Bartosz Golaszewski, linux-gpio,
Thierry Reding, Greentime Hu, Yash Shah
This is the only driver in the kernel source tree that depends on
IRQ_DOMAIN_HIERARCHY instead of selecting it. Since it is not a
visible Kconfig symbol, depending on it (expecting a user to
set/enable it) doesn't make much sense, so change it to select
instead of "depends on".
Fixes: 96868dce644d ("gpio/sifive: Add GPIO driver for SiFive SoCs")
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Linus Walleij <linus.walleij@linaro.org>
Cc: Bartosz Golaszewski <bgolaszewski@baylibre.com>
Cc: linux-gpio@vger.kernel.org
Cc: Thierry Reding <treding@nvidia.com>
Cc: Greentime Hu <greentime.hu@sifive.com>
Cc: Yash Shah <yash.shah@sifive.com>
---
drivers/gpio/Kconfig | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
--- linux-next-20210118.orig/drivers/gpio/Kconfig
+++ linux-next-20210118/drivers/gpio/Kconfig
@@ -521,7 +521,8 @@ config GPIO_SAMA5D2_PIOBU
config GPIO_SIFIVE
bool "SiFive GPIO support"
- depends on OF_GPIO && IRQ_DOMAIN_HIERARCHY
+ depends on OF_GPIO
+ select IRQ_DOMAIN_HIERARCHY
select GPIO_GENERIC
select GPIOLIB_IRQCHIP
select REGMAP_MMIO
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] gpio: sifive: select IRQ_DOMAIN_HIERARCHY rather than depend on it
2021-01-19 3:18 [PATCH] gpio: sifive: select IRQ_DOMAIN_HIERARCHY rather than depend on it Randy Dunlap
@ 2021-01-19 11:10 ` Bartosz Golaszewski
0 siblings, 0 replies; 2+ messages in thread
From: Bartosz Golaszewski @ 2021-01-19 11:10 UTC (permalink / raw)
To: Randy Dunlap
Cc: LKML, Linus Walleij, linux-gpio, Thierry Reding, Greentime Hu, Yash Shah
On Tue, Jan 19, 2021 at 4:18 AM Randy Dunlap <rdunlap@infradead.org> wrote:
>
> This is the only driver in the kernel source tree that depends on
> IRQ_DOMAIN_HIERARCHY instead of selecting it. Since it is not a
> visible Kconfig symbol, depending on it (expecting a user to
> set/enable it) doesn't make much sense, so change it to select
> instead of "depends on".
>
> Fixes: 96868dce644d ("gpio/sifive: Add GPIO driver for SiFive SoCs")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: Bartosz Golaszewski <bgolaszewski@baylibre.com>
> Cc: linux-gpio@vger.kernel.org
> Cc: Thierry Reding <treding@nvidia.com>
> Cc: Greentime Hu <greentime.hu@sifive.com>
> Cc: Yash Shah <yash.shah@sifive.com>
> ---
> drivers/gpio/Kconfig | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> --- linux-next-20210118.orig/drivers/gpio/Kconfig
> +++ linux-next-20210118/drivers/gpio/Kconfig
> @@ -521,7 +521,8 @@ config GPIO_SAMA5D2_PIOBU
>
> config GPIO_SIFIVE
> bool "SiFive GPIO support"
> - depends on OF_GPIO && IRQ_DOMAIN_HIERARCHY
> + depends on OF_GPIO
> + select IRQ_DOMAIN_HIERARCHY
> select GPIO_GENERIC
> select GPIOLIB_IRQCHIP
> select REGMAP_MMIO
Applied, thanks!
Bart
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-01-19 11:28 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-19 3:18 [PATCH] gpio: sifive: select IRQ_DOMAIN_HIERARCHY rather than depend on it Randy Dunlap
2021-01-19 11:10 ` Bartosz Golaszewski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).