From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
To: Alexandru Ardelean <aardelean@deviqon.com>
Cc: linux-gpio <linux-gpio@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Linus Walleij <linus.walleij@linaro.org>
Subject: Re: [PATCH] gpio: gpio-wm831x: remove platform_set_drvdata() + cleanup probe
Date: Tue, 25 May 2021 16:35:29 +0200 [thread overview]
Message-ID: <CAMpxmJWbz1ORhaEZGcS7dKqzo31JDcA7hZRRGuFFnJ7cBNuDGQ@mail.gmail.com> (raw)
In-Reply-To: <20210517113540.237495-1-aardelean@deviqon.com>
On Mon, May 17, 2021 at 1:36 PM Alexandru Ardelean
<aardelean@deviqon.com> wrote:
>
> The platform_set_drvdata() call is only useful if we need to retrieve back
> the private information.
> Since the driver doesn't do that, it's not useful to have it.
>
> If this is removed, we can also just do a direct return on
> devm_gpiochip_add_data(). We don't need to print that this call failed as
> there are other ways to log/see this during probe.
>
> Signed-off-by: Alexandru Ardelean <aardelean@deviqon.com>
> ---
> drivers/gpio/gpio-wm831x.c | 12 +-----------
> 1 file changed, 1 insertion(+), 11 deletions(-)
>
> diff --git a/drivers/gpio/gpio-wm831x.c b/drivers/gpio/gpio-wm831x.c
> index a3a32a77041f..9cf1e5ebb352 100644
> --- a/drivers/gpio/gpio-wm831x.c
> +++ b/drivers/gpio/gpio-wm831x.c
> @@ -261,7 +261,6 @@ static int wm831x_gpio_probe(struct platform_device *pdev)
> struct wm831x *wm831x = dev_get_drvdata(pdev->dev.parent);
> struct wm831x_pdata *pdata = &wm831x->pdata;
> struct wm831x_gpio *wm831x_gpio;
> - int ret;
>
> wm831x_gpio = devm_kzalloc(&pdev->dev, sizeof(*wm831x_gpio),
> GFP_KERNEL);
> @@ -280,16 +279,7 @@ static int wm831x_gpio_probe(struct platform_device *pdev)
> wm831x_gpio->gpio_chip.of_node = wm831x->dev->of_node;
> #endif
>
> - ret = devm_gpiochip_add_data(&pdev->dev, &wm831x_gpio->gpio_chip,
> - wm831x_gpio);
> - if (ret < 0) {
> - dev_err(&pdev->dev, "Could not register gpiochip, %d\n", ret);
> - return ret;
> - }
> -
> - platform_set_drvdata(pdev, wm831x_gpio);
> -
> - return ret;
> + return devm_gpiochip_add_data(&pdev->dev, &wm831x_gpio->gpio_chip, wm831x_gpio);
> }
>
> static struct platform_driver wm831x_gpio_driver = {
> --
> 2.31.1
>
Applied, thanks!
Bart
prev parent reply other threads:[~2021-05-25 14:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-17 11:35 [PATCH] gpio: gpio-wm831x: remove platform_set_drvdata() + cleanup probe Alexandru Ardelean
2021-05-17 11:35 ` [PATCH] gpio: gpio-wm8350: " Alexandru Ardelean
2021-05-25 14:35 ` Bartosz Golaszewski
2021-05-17 11:35 ` [PATCH] gpio: gpio-wm8994: " Alexandru Ardelean
2021-05-25 14:35 ` Bartosz Golaszewski
2021-05-25 14:35 ` Bartosz Golaszewski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMpxmJWbz1ORhaEZGcS7dKqzo31JDcA7hZRRGuFFnJ7cBNuDGQ@mail.gmail.com \
--to=bgolaszewski@baylibre.com \
--cc=aardelean@deviqon.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).