From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752861AbcGOIya (ORCPT <rfc822;w@1wt.eu>);
	Fri, 15 Jul 2016 04:54:30 -0400
Received: from mail-it0-f47.google.com ([209.85.214.47]:35248 "EHLO
	mail-it0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752646AbcGOIyZ (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 15 Jul 2016 04:54:25 -0400
MIME-Version: 1.0
In-Reply-To: <20160715063047.GA7675@tetsubishi>
References: <1465202936-16832-1-git-send-email-bgolaszewski@baylibre.com>
 <1465202936-16832-12-git-send-email-bgolaszewski@baylibre.com> <20160715063047.GA7675@tetsubishi>
From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
Date: Fri, 15 Jul 2016 10:54:24 +0200
Message-ID: <CAMpxmJWeEXSsoTFfg-Lx3pMC0mfSY0=Ez4Tg1Z2nhf5wJyQTPA@mail.gmail.com>
Subject: Re: [RESEND PATCH 11/14] eeprom: at24: add the at24cs series to the
 list of supported devices
To: Wolfram Sang <wsa@the-dreams.de>
Cc: linux-i2c <linux-i2c@vger.kernel.org>, LKML <linux-kernel@vger.kernel.org>,
        Andrew Lunn <andrew@lunn.ch>,
        Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
        Maxime Ripard <maxime.ripard@free-electrons.com>,
        GregKH <greg@kroah.com>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

2016-07-15 8:30 GMT+02:00 Wolfram Sang <wsa@the-dreams.de>:
>
>>       { "24c01",      AT24_DEVICE_MAGIC(1024 / 8,     0) },
>> +     { "24cs01",     AT24_DEVICE_MAGIC(128 / 8,
>
> I encoded the size for EEPROMs with "x / 8" originally to make it
> visible where the EEPROM name came from, i.e. that is from kilobits not
> kilobytes. So, for the serial number I would simply encode the size as
> 16 and not as (128 / 8), because it has nothing to do with the name. I
> can fix this locally if you are okay with the idea?
>

Sure, thanks!

Bart