From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D3CFEC433E0 for ; Fri, 26 Mar 2021 13:08:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9276861A06 for ; Fri, 26 Mar 2021 13:08:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230095AbhCZNHi (ORCPT ); Fri, 26 Mar 2021 09:07:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33810 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229930AbhCZNH3 (ORCPT ); Fri, 26 Mar 2021 09:07:29 -0400 Received: from mail-ed1-x532.google.com (mail-ed1-x532.google.com [IPv6:2a00:1450:4864:20::532]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F306AC0613AA for ; Fri, 26 Mar 2021 06:07:28 -0700 (PDT) Received: by mail-ed1-x532.google.com with SMTP id l18so6221370edc.9 for ; Fri, 26 Mar 2021 06:07:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=UzC5FBVz05PHuae7oBlniWjIpKp36WiskgIQCfeie3A=; b=V2Ytu6qBPPGkLMv7S6mlhwfXx73xncAijDlfo/GWHDkV2vSaO7UEb+pL2lXTMSyc5T IS8zUw/vml70QF5x1CKd0LeZY3y+6cRbfEMJ1xDLKyJ6P1Wp0E1aRqCoJxutN99HxIIj ApPez/DvySFJy9SEe6wXhAga56XRZj9RLazbYoPnqEHIvlzyG6zLm9eLX0EjsTPTQtS0 1Gtv7+5x4BTV5lm9KgOtXvV1GfUeRwO+ZJlYOtIzyaUgKQrdCDD0mJHLE0cQd693TKmR I/76K60wh46tNX2SDm8Oitpz6W/2T+/oA/Mzq4sulFiheOe1a+VhaE5W+dWYFP/97uVa jsXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=UzC5FBVz05PHuae7oBlniWjIpKp36WiskgIQCfeie3A=; b=XZ1o+Vh0I7mnY4K75fH1SgCVT6qrRJjXRPaeDYPRBNr7pmbdObZra7PsZi/Ty9u0Ht 1rNoOdh3tqV2jBTvKLmWaJp/dTn2HANBafRH4VB1Gcz5B24UQxP2dMHu/8prpmMDKJnA kTec14t3IvbRnSZlgJA//obwuOYtRNf58FRaywwHDxjo7CuaNapxDSg6neZIDzDUgL08 zYOQWT6Zl8EbEUVZTv0N9UYBNNZfFC2El2C7mq77PfCq6rTjg7xDO45frOvEUobxW1yL k9pGDtS9iYbafsJV7ktxVVoFm/jfolEQTMRhtB0nNHjmUjsSTUuMsqka2U2ngTsZM/cb VhKg== X-Gm-Message-State: AOAM5335Xzf7m9eKjXppQgioSgnySjHHeAXOJB9Y/AtsfUrT0kzIdHjX BepkA9qOEXuZ8DmIGzzXA8Cr/0mIceNxx8HfLb52bQ== X-Google-Smtp-Source: ABdhPJwkjDuvTV8Eny6IaII+A63BvbGqHoVciv6m70WrZQH4YTnZlVRI3Qv1mAGKV+kcQQCfrCPZQPEI7Hh3uEB5emg= X-Received: by 2002:a05:6402:17d6:: with SMTP id s22mr14815062edy.232.1616764047557; Fri, 26 Mar 2021 06:07:27 -0700 (PDT) MIME-Version: 1.0 References: <20210324064541.949630-1-jay.xu@rock-chips.com> <202103241450286417142@rock-chips.com> In-Reply-To: <202103241450286417142@rock-chips.com> From: Bartosz Golaszewski Date: Fri, 26 Mar 2021 14:07:16 +0100 Message-ID: Subject: Re: [PATCH RESEND 0/7] gpio-rockchip driver To: "jay.xu@rock-chips.com" Cc: Tao Huang , =?UTF-8?B?5p2o5Yev?= , Linus Walleij , =?UTF-8?Q?Heiko_St=C3=BCbner?= , "open list:GPIO SUBSYSTEM" , "open list:ARM/Rockchip SoC..." , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 24, 2021 at 7:50 AM jay.xu@rock-chips.com wrote: > > I'm forget to send-to include Bartosz, I'll remember in next version > > -------------- > jay.xu@rock-chips.com > >Separate gpio driver from pinctrl driver, and support v2 controller. > > > >Jianqun Xu (7): > > pinctrl/rockchip: separate struct rockchip_pin_bank to a head file > > pinctrl/pinctrl-rockchip.h: add pinctrl device to gpio bank struct > > gpio: separate gpio driver from pinctrl-rockchip driver > > gpio/rockchip: use struct rockchip_gpio_regs for gpio controller > > gpio/rockchip: support next version gpio controller > > gpio/rockchip: always enable clock for gpio controller > > gpio/rockchip: drop irq_gc_lock/irq_gc_unlock for irq set type > > > > drivers/gpio/Kconfig | 8 + > > drivers/gpio/Makefile | 1 + > > drivers/gpio/gpio-rockchip.c | 758 ++++++++++++++++++++++++ > > drivers/pinctrl/pinctrl-rockchip.c | 909 +---------------------------- > > drivers/pinctrl/pinctrl-rockchip.h | 286 +++++++++ > > 5 files changed, 1072 insertions(+), 890 deletions(-) > > create mode 100644 drivers/gpio/gpio-rockchip.c > > create mode 100644 drivers/pinctrl/pinctrl-rockchip.h > > > >-- > >2.25.1 > > > > > > I don't even have this in my inbox so I can't review it. Bartosz