linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
To: Alexandru Ardelean <aardelean@deviqon.com>
Cc: linux-gpio <linux-gpio@vger.kernel.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Linus Walleij <linus.walleij@linaro.org>
Subject: Re: [PATCH v2] gpio: viperboard: remove platform_set_drvdata() call in probe
Date: Tue, 31 Aug 2021 11:29:46 +0200	[thread overview]
Message-ID: <CAMpxmJWpOjsJXSDJ3w64MrKeT3Uh1Jx+C7tP44Dj7uF9tnw-Eg@mail.gmail.com> (raw)
In-Reply-To: <20210825070125.32918-1-aardelean@deviqon.com>

On Wed, Aug 25, 2021 at 9:02 AM Alexandru Ardelean
<aardelean@deviqon.com> wrote:
>
> The platform_set_drvdata() call is only useful if we need to retrieve back
> the private information.
> Since the driver doesn't do that, it's not useful to have it.
>
> This change removes it.
> Also removing with this change is some logging about the failure to init
> the gpio chip data. There are other logging methods to view that this
> failed.
>
> Signed-off-by: Alexandru Ardelean <aardelean@deviqon.com>
> ---
>
> Changelog v1 -> v2:
> * remove dev_err() prints
> * [styling] added empty line before first devm_gpiochip_add_data()
>
>  drivers/gpio/gpio-viperboard.c | 14 +++-----------
>  1 file changed, 3 insertions(+), 11 deletions(-)
>
> diff --git a/drivers/gpio/gpio-viperboard.c b/drivers/gpio/gpio-viperboard.c
> index c301c1d56dd2..e55d28a8a66f 100644
> --- a/drivers/gpio/gpio-viperboard.c
> +++ b/drivers/gpio/gpio-viperboard.c
> @@ -404,11 +404,10 @@ static int vprbrd_gpio_probe(struct platform_device *pdev)
>         vb_gpio->gpioa.get = vprbrd_gpioa_get;
>         vb_gpio->gpioa.direction_input = vprbrd_gpioa_direction_input;
>         vb_gpio->gpioa.direction_output = vprbrd_gpioa_direction_output;
> +
>         ret = devm_gpiochip_add_data(&pdev->dev, &vb_gpio->gpioa, vb_gpio);
> -       if (ret < 0) {
> -               dev_err(vb_gpio->gpioa.parent, "could not add gpio a");
> +       if (ret < 0)
>                 return ret;
> -       }
>
>         /* registering gpio b */
>         vb_gpio->gpiob.label = "viperboard gpio b";
> @@ -421,15 +420,8 @@ static int vprbrd_gpio_probe(struct platform_device *pdev)
>         vb_gpio->gpiob.get = vprbrd_gpiob_get;
>         vb_gpio->gpiob.direction_input = vprbrd_gpiob_direction_input;
>         vb_gpio->gpiob.direction_output = vprbrd_gpiob_direction_output;
> -       ret = devm_gpiochip_add_data(&pdev->dev, &vb_gpio->gpiob, vb_gpio);
> -       if (ret < 0) {
> -               dev_err(vb_gpio->gpiob.parent, "could not add gpio b");
> -               return ret;
> -       }
> -
> -       platform_set_drvdata(pdev, vb_gpio);
>
> -       return ret;
> +       return devm_gpiochip_add_data(&pdev->dev, &vb_gpio->gpiob, vb_gpio);
>  }
>
>  static struct platform_driver vprbrd_gpio_driver = {
> --
> 2.31.1
>

Applied, thanks!

Bart

      reply	other threads:[~2021-08-31  9:30 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-07 13:51 [PATCH] " Alexandru Ardelean
2021-07-21 13:16 ` Bartosz Golaszewski
2021-07-21 14:13   ` Alexandru Ardelean
2021-07-27 13:32     ` Bartosz Golaszewski
2021-08-25  7:01 ` [PATCH v2] " Alexandru Ardelean
2021-08-31  9:29   ` Bartosz Golaszewski [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAMpxmJWpOjsJXSDJ3w64MrKeT3Uh1Jx+C7tP44Dj7uF9tnw-Eg@mail.gmail.com \
    --to=bgolaszewski@baylibre.com \
    --cc=aardelean@deviqon.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --subject='Re: [PATCH v2] gpio: viperboard: remove platform_set_drvdata() call in probe' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).