From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
To: Rasmus Villemoes <linux@rasmusvillemoes.dk>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Thomas Gleixner <tglx@linutronix.de>,
Song Hui <hui.song_1@nxp.com>,
"Stable # 4 . 20+" <stable@vger.kernel.org>,
linux-gpio <linux-gpio@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Revert "gpio: mpc8xxx: change the gpio interrupt flags."
Date: Sun, 18 Jul 2021 14:53:09 +0200 [thread overview]
Message-ID: <CAMpxmJWrmVNb2jYs8e585kDnE+Xv8yNiFpABh3RwDUFg1KAWqA@mail.gmail.com> (raw)
In-Reply-To: <20210702133712.128611-1-linux@rasmusvillemoes.dk>
On Fri, Jul 2, 2021 at 3:37 PM Rasmus Villemoes
<linux@rasmusvillemoes.dk> wrote:
>
> This reverts commit 3d5bfbd9716318b1ca5c38488aa69f64d38a9aa5.
>
> When booting with threadirqs, it causes a splat
>
> WARNING: CPU: 0 PID: 29 at kernel/irq/handle.c:159 __handle_irq_event_percpu+0x1ec/0x27c
> irq 66 handler irq_default_primary_handler+0x0/0x1c enabled interrupts
>
> That splat later went away with commit 81e2073c175b ("genirq: Disable
> interrupts for force threaded handlers"), which got backported to
> -stable. However, when running an -rt kernel, the splat still
> exists. Moreover, quoting Thomas Gleixner [1]
>
> But 3d5bfbd97163 ("gpio: mpc8xxx: change the gpio interrupt flags.")
> has nothing to do with that:
>
> "Delete the interrupt IRQF_NO_THREAD flags in order to gpio interrupts
> can be threaded to allow high-priority processes to preempt."
>
> This changelog is blatantly wrong. In mainline forced irq threads
> have always been invoked with softirqs disabled, which obviously
> makes them non-preemptible.
>
> So the patch didn't even do what its commit log said.
>
> [1] https://lore.kernel.org/lkml/871r8zey88.ffs@nanos.tec.linutronix.de/
>
> Cc: stable@vger.kernel.org # v5.9+
> Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
> ---
Applied for fixes, thanks!
Bartosz
next prev parent reply other threads:[~2021-07-18 12:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-02 13:37 [PATCH] Revert "gpio: mpc8xxx: change the gpio interrupt flags." Rasmus Villemoes
2021-07-18 12:53 ` Bartosz Golaszewski [this message]
2021-07-21 20:25 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMpxmJWrmVNb2jYs8e585kDnE+Xv8yNiFpABh3RwDUFg1KAWqA@mail.gmail.com \
--to=bgolaszewski@baylibre.com \
--cc=hui.song_1@nxp.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=stable@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).