From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
To: "Gustavo A. R. Silva" <gustavoars@kernel.org>
Cc: Alban Bedel <albeu@free.fr>,
Linus Walleij <linus.walleij@linaro.org>,
linux-gpio <linux-gpio@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
linux-hardening@vger.kernel.org
Subject: Re: [PATCH][next] gpio: ath79: Fix fall-through warning for Clang
Date: Tue, 1 Dec 2020 15:50:12 +0100 [thread overview]
Message-ID: <CAMpxmJXD+qiJLoEdFxmceVNyXPDfmvKPwG+SthOS8oHd2GqLuA@mail.gmail.com> (raw)
In-Reply-To: <20201119170901.GA22703@embeddedor>
On Thu, Nov 19, 2020 at 6:08 PM Gustavo A. R. Silva
<gustavoars@kernel.org> wrote:
>
> In preparation to enable -Wimplicit-fallthrough for Clang, fix a
> warning by explicitly adding a fallthrough pseudo-keyword to indicate
> that the code is intended to fall through to the next case.
>
> Link: https://github.com/KSPP/linux/issues/115
> Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
> ---
> drivers/gpio/gpio-ath79.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpio/gpio-ath79.c b/drivers/gpio/gpio-ath79.c
> index d5359341cc6b..678ddd375891 100644
> --- a/drivers/gpio/gpio-ath79.c
> +++ b/drivers/gpio/gpio-ath79.c
> @@ -123,6 +123,7 @@ static int ath79_gpio_irq_set_type(struct irq_data *data,
> switch (flow_type) {
> case IRQ_TYPE_EDGE_RISING:
> polarity |= mask;
> + fallthrough;
> case IRQ_TYPE_EDGE_FALLING:
> case IRQ_TYPE_EDGE_BOTH:
> break;
> --
> 2.27.0
>
Applied, thanks!
Bartosz
prev parent reply other threads:[~2020-12-01 14:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-19 17:09 [PATCH][next] gpio: ath79: Fix fall-through warning for Clang Gustavo A. R. Silva
2020-12-01 14:50 ` Bartosz Golaszewski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMpxmJXD+qiJLoEdFxmceVNyXPDfmvKPwG+SthOS8oHd2GqLuA@mail.gmail.com \
--to=bgolaszewski@baylibre.com \
--cc=albeu@free.fr \
--cc=gustavoars@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).