From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
To: Alexandru Ardelean <aardelean@deviqon.com>
Cc: linux-gpio <linux-gpio@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Linus Walleij <linus.walleij@linaro.org>
Subject: Re: [PATCH] gpio: gpio-sta2x11: remove platform_set_drvdata() + cleanup probe
Date: Tue, 25 May 2021 16:34:14 +0200 [thread overview]
Message-ID: <CAMpxmJXJOnEfMrDf5krOAOydEui6fAHGqUx8Ub7iWZxMEOqT5Q@mail.gmail.com> (raw)
In-Reply-To: <20210516062315.10832-1-aardelean@deviqon.com>
On Sun, May 16, 2021 at 8:23 AM Alexandru Ardelean
<aardelean@deviqon.com> wrote:
>
> The platform_set_drvdata() call is only useful if we need to retrieve back
> the private information.
> Since the driver doesn't do that, it's not useful to have it.
>
> If this is removed, we can also just do a direct return on
> devm_gpiochip_add_data(). We don't need to print that this call failed as
> there are other ways to log/see this during probe.
>
> Signed-off-by: Alexandru Ardelean <aardelean@deviqon.com>
> ---
> drivers/gpio/gpio-sta2x11.c | 10 +---------
> 1 file changed, 1 insertion(+), 9 deletions(-)
>
> diff --git a/drivers/gpio/gpio-sta2x11.c b/drivers/gpio/gpio-sta2x11.c
> index a74bb97a41e2..392fcab06ab8 100644
> --- a/drivers/gpio/gpio-sta2x11.c
> +++ b/drivers/gpio/gpio-sta2x11.c
> @@ -398,15 +398,7 @@ static int gsta_probe(struct platform_device *dev)
> return err;
> }
>
> - err = devm_gpiochip_add_data(&dev->dev, &chip->gpio, chip);
> - if (err < 0) {
> - dev_err(&dev->dev, "sta2x11 gpio: Can't register (%i)\n",
> - -err);
> - return err;
> - }
> -
> - platform_set_drvdata(dev, chip);
> - return 0;
> + return devm_gpiochip_add_data(&dev->dev, &chip->gpio, chip);
> }
>
> static struct platform_driver sta2x11_gpio_platform_driver = {
> --
> 2.31.1
>
Applied, thanks!
Bart
prev parent reply other threads:[~2021-05-25 14:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-16 6:23 [PATCH] gpio: gpio-sta2x11: remove platform_set_drvdata() + cleanup probe Alexandru Ardelean
2021-05-25 14:34 ` Bartosz Golaszewski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMpxmJXJOnEfMrDf5krOAOydEui6fAHGqUx8Ub7iWZxMEOqT5Q@mail.gmail.com \
--to=bgolaszewski@baylibre.com \
--cc=aardelean@deviqon.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).