From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E24FAC32751 for ; Wed, 31 Jul 2019 10:05:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B0ECD2171F for ; Wed, 31 Jul 2019 10:05:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20150623.gappssmtp.com header.i=@baylibre-com.20150623.gappssmtp.com header.b="V4wjj7k/" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726675AbfGaKFQ (ORCPT ); Wed, 31 Jul 2019 06:05:16 -0400 Received: from mail-ot1-f65.google.com ([209.85.210.65]:36404 "EHLO mail-ot1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726248AbfGaKFQ (ORCPT ); Wed, 31 Jul 2019 06:05:16 -0400 Received: by mail-ot1-f65.google.com with SMTP id r6so69586343oti.3 for ; Wed, 31 Jul 2019 03:05:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=+1oHf1+ErP2HL7hVOGccTTUzsvFfZGUFo4kLW3/NF74=; b=V4wjj7k//NOYAnpNAy96d0VR3zxB/qYbLmdYJlrlx0nf+bmL39DVNQc/aRXm7+14Id PRhm47KopeSw/zRX9YujsBjwurOMNyRArBrMcO+4PVWv9/YoJEewX7M3rp6sBlkT5poE Lw7+yeT4e2/pjmdK4Rp+CK7UaMbXrRIPKlX/0lLBU3osLmjUg6j2dUhXAp3+FHUnib8n VLrjR/DC1z5Nx4pcVMj3mDFFdkRItDwZSDrRw39UzVjSc6p9hhMhztFlQvQ/WdfGgpl0 LsRicLctxiARRIw8wpN9xzzeS2+TT5nIbWW0twE2svcmdPwDEmgbFlYvm0RT6HYPOfAW K5mw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=+1oHf1+ErP2HL7hVOGccTTUzsvFfZGUFo4kLW3/NF74=; b=dqtlXRAmTGfO/ai3RuuN6ruJc/rJHcHgFzG43xnkV0g+/u0nBNG8ILxiC0oAZYdU/O ZOLmEro9MkHNF3lClS5YAET3eV0SjRslWhrm0wLKAFnyPwtBKf8Sz4QUP181p8GrjWX7 O4H3/WFz9PPz/l8b23gzC3XXK0qnzBCL908NjDac/fou8+30dUYMuvlMC2MBqIjIOSbZ k0xbqUjBe2Gigm1p1VECFbbUH/OsTJTcgnxZVqCzODL3vADJcLRFd3xkFUqg3hNpsFzs LzEngFlo+BRvKkwa1mQ8Q7H5OPpUe3VIAx3CfbtQ0ViNtPQTWWeqEepMNY3FeEdf3EJH HdTg== X-Gm-Message-State: APjAAAWdmzv6oPVWmJ1hWLCVZPk1gWh2yKe38D/gs2qw+/54x/fhsL+R OIyx/dHLNbgxqQz2GuYcBrgBYMwWOl32QbZq3dIlKA== X-Google-Smtp-Source: APXvYqz5jnxUo8M7IbSxK0LhJprE4y7hCuX1ujLyNA1InAolL8RUQuVGlHq6hYe8FOBh+P3mZT3Ka7f3nLqQT5diftM= X-Received: by 2002:a9d:7352:: with SMTP id l18mr27744113otk.292.1564567515226; Wed, 31 Jul 2019 03:05:15 -0700 (PDT) MIME-Version: 1.0 References: <1564566474-18294-1-git-send-email-dingxiang@cmss.chinamobile.com> In-Reply-To: <1564566474-18294-1-git-send-email-dingxiang@cmss.chinamobile.com> From: Bartosz Golaszewski Date: Wed, 31 Jul 2019 12:05:04 +0200 Message-ID: Subject: Re: [PATCH] gpio: ixp4xx: remove redundant dev_err message To: Ding Xiang Cc: Linus Walleij , linux-gpio , LKML Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org =C5=9Br., 31 lip 2019 o 11:48 Ding Xiang n= apisa=C5=82(a): > > devm_ioremap_resource already contains error message, so remove > the redundant dev_err message > > Signed-off-by: Ding Xiang > --- > drivers/gpio/gpio-ixp4xx.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/gpio/gpio-ixp4xx.c b/drivers/gpio/gpio-ixp4xx.c > index 670c2a8..2b2b89b 100644 > --- a/drivers/gpio/gpio-ixp4xx.c > +++ b/drivers/gpio/gpio-ixp4xx.c > @@ -321,10 +321,8 @@ static int ixp4xx_gpio_probe(struct platform_device = *pdev) > > res =3D platform_get_resource(pdev, IORESOURCE_MEM, 0); > g->base =3D devm_ioremap_resource(dev, res); > - if (IS_ERR(g->base)) { > - dev_err(dev, "ioremap error\n"); > + if (IS_ERR(g->base)) > return PTR_ERR(g->base); > - } > > /* > * Make sure GPIO 14 and 15 are NOT used as clocks but GPIO on > -- > 1.9.1 > > > Patch applied, thanks! Bart