From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933799AbdK2RDM convert rfc822-to-8bit (ORCPT ); Wed, 29 Nov 2017 12:03:12 -0500 Received: from youngberry.canonical.com ([91.189.89.112]:51907 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932234AbdK2RDK (ORCPT ); Wed, 29 Nov 2017 12:03:10 -0500 X-Google-Smtp-Source: AGs4zMaxfo5u9Lyn1hnxAZ3BSl6MA0NHwNfM2gD9pXXQR5SQflHOeFtvt9rJRrDUwTfUxCBxI/vpNmzHy1MJBkAUw/8= MIME-Version: 1.0 In-Reply-To: References: <20171114123834.xsjiy2ynvott4gae@brain> <1511780854-7213-1-git-send-email-paolo.pisati@canonical.com> From: Paolo Pisati Date: Wed, 29 Nov 2017 18:03:07 +0100 Message-ID: Subject: Re: [PATCH v3] scripts/package: snap-pkg target To: Jim Davis Cc: Masahiro Yamada , Michal Marek , Behan Webster , Matthias Kaehlcke , =?UTF-8?Q?Vin=C3=ADcius_Tinti?= , linux-kbuild , linux-kernel Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Weird, are you sure you are checking the snap version? $ /snap/bin/snapcraft --version snapcraft, version 2.35+git26.0474d85 $ snap info snapcraft name: snapcraft summary: easily create snaps publisher: canonical contact: snappy-canonical-storeaccount@canonical.com description: | Snapcraft aims to make upstream developers' lives easier and as such is not a single toolset, but instead is a collection of tools that enable the natural workflow of an upstream to be extended with a simple release step into Snappy enabled system. snap-id: vMTKRaLjnOJQetI78HjntT37VuoyssFE commands: - snapcraft tracking: edge installed: 2.35+git26.0474d85 (864) 53MB classic refreshed: 2017-11-29 09:54:04 +0100 CET channels: stable: 2.35 (794) 53MB classic candidate: ↑ beta: ↑ edge: 2.35+git26.0474d85 (864) 53MB classic On Tue, Nov 28, 2017 at 8:35 PM, Jim Davis wrote: > On Tue, Nov 28, 2017 at 10:14 AM, Paolo Pisati > wrote: >> On Mon, Nov 27, 2017 at 7:33 PM, Jim Davis wrote: >>> >>> With this patch applied to the 4.14 kernel source, and running make >>> snap-pkg on a Ubuntu 16.04 VM with the latest 16.04 kernel config >>> file, I ran into >>> >>> Traceback (most recent call last): >>> File "/usr/lib/python3.5/shutil.py", line 538, in move >>> os.rename(src, real_dst) >>> FileNotFoundError: [Errno 2] No such file or directory: >>> '/home/jim/linux/snap/parts/kernel/install/lib/firmware' -> >>> '/home/jim/linux/snap/parts/kernel/install/firmware' >>> >>> What did I miss? >> >> You need a recent version of snapcraft, i landed a fix for that last week. >> >> $ snap install --classic --edge snapcraft >> >> or refresh it, in case you already installed via snaps: >> >> $ snap refresh --edge snapcraft >> >> and then 'make snap-pkg' again. >> Beware of $PATH in case you have the snap and deb version installed. > > Ok, after updating and setting ~/snapcraft/bin/snapcraft ahead of > /usr/bin in my $PATH, the build completed. Oddly both > /usr/bin/snapcraft --version and ~/snapcraft/bin/snapcraft --version > return 2.34, though the build failed with /usr/bin/snapcraft. > > -- > Jim -- bye, p.