From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A6A5BC32792 for ; Thu, 3 Oct 2019 15:16:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 777F12133F for ; Thu, 3 Oct 2019 15:16:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=amarulasolutions.com header.i=@amarulasolutions.com header.b="ngQbGJwi" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729992AbfJCPQp (ORCPT ); Thu, 3 Oct 2019 11:16:45 -0400 Received: from mail-io1-f65.google.com ([209.85.166.65]:39605 "EHLO mail-io1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729159AbfJCPQp (ORCPT ); Thu, 3 Oct 2019 11:16:45 -0400 Received: by mail-io1-f65.google.com with SMTP id a1so6408353ioc.6 for ; Thu, 03 Oct 2019 08:16:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=hA2LtxmdLIDTNytgEaB7reCfgrHgEKb4xoiREE/0K7Q=; b=ngQbGJwiby9Ke44nsAO/tlZUe9hbTCbksGis/YVtTxDj+EC1MtxBGvRkmqd0JLO845 p7e2ovtJjAB5LueL0Y5aQf5J1HQ/lKdMuIPvH9lVJpzJiPC2gNldIggTM1iJrlmY8m33 IpRwZ92PJPi/rxe1pcdqhVrJdkMQIW6Iw6Toc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=hA2LtxmdLIDTNytgEaB7reCfgrHgEKb4xoiREE/0K7Q=; b=SyPtUcY4cz5w6ovWqbEPVrGl0LxmUq7tR43orCov/41W2TNpyRR/l7nbDLtv+TiEiy nv345L0NGWlHrODozuA1hjxCsCzj82osdgOSkUy1yFuZvwpREwXDuX6a4N4Ta+zYU1Xr BnyFJjKZ5L3Si3O3Yc68lDe/jskyhh8/N8uM0qy7bACY6tRk1oiohmAMuZsPVpQuk4a9 25rXtlNAjD9GqwumxCXfhTJkwKZBckmBjylYzCzz4+P1h8nkDfwU3OY5KP+DNzjJm8nU OaqgDR/0IkGZPTwp1qHQGHrS25YisZna56PJB7AC3/+bvv7w4BGIzom+t8c5GdUp4gdy QyKA== X-Gm-Message-State: APjAAAVYzx8kLpjzIZB85DQXro8ZNrn65kM34nIghyc4vLCiUNnCxjTn JqNo8d8UWGwDvMtAENjC17HbCb+t6mHYPZOB3w78IA== X-Google-Smtp-Source: APXvYqzlTS7XsY5btr8rMMngqjvVqVkZJIrk+i/7OsB/hdVMXH4Zvn/MgTgexACnaezUOhbxLyWLbSVqyy23WYGVkQQ= X-Received: by 2002:a92:17c4:: with SMTP id 65mr10501991ilx.28.1570115803953; Thu, 03 Oct 2019 08:16:43 -0700 (PDT) MIME-Version: 1.0 References: <20191003064527.15128-1-jagan@amarulasolutions.com> <20191003064527.15128-2-jagan@amarulasolutions.com> <20191003131737.bvpf5quds66qtsmy@gilmour> In-Reply-To: <20191003131737.bvpf5quds66qtsmy@gilmour> From: Jagan Teki Date: Thu, 3 Oct 2019 20:46:31 +0530 Message-ID: Subject: Re: [PATCH v11 1/7] drm/sun4i: dsi: Fix TCON DRQ set bits To: Maxime Ripard Cc: Chen-Yu Tsai , David Airlie , Daniel Vetter , Michael Trimarchi , Icenowy Zheng , linux-sunxi , dri-devel , linux-arm-kernel , linux-kernel , devicetree Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Oct 3, 2019 at 6:47 PM Maxime Ripard wrote: > > On Thu, Oct 03, 2019 at 12:15:21PM +0530, Jagan Teki wrote: > > The LCD timing definitions between Linux DRM vs Allwinner are different, > > below diagram shows this clear differences. > > > > Active Front Sync Back > > Region Porch Porch > > <-----------------------><----------------><--------------><--------------> > > //////////////////////| > > ////////////////////// | > > ////////////////////// |.................. ................ > > ________________ > > <----- [hv]display -----> > > <------------- [hv]sync_start ------------> > > <--------------------- [hv]sync_end ----------------------> > > <-------------------------------- [hv]total ------------------------------> > > > > <----- lcd_[xy] --------> <- lcd_[hv]spw -> > > <---------- lcd_[hv]bp ---------> > > <-------------------------------- lcd_[hv]t ------------------------------> > > > > The DSI driver misinterpreted the hbp term from the BSP code to refer > > only to the backporch, when in fact it was backporch + sync. Thus the > > driver incorrectly used the horizontal front porch plus sync in its > > calculation of the DRQ set bit value, when it should not have included > > the sync timing. > > > > Including additional sync timings leads to flip_done timed out as: > > > > WARNING: CPU: 0 PID: 31 at drivers/gpu/drm/drm_atomic_helper.c:1429 drm_atomic_helper_wait_for_vblanks.part.1+0x298/0x2a0 > > [CRTC:46:crtc-0] vblank wait timed out > > Modules linked in: > > CPU: 0 PID: 31 Comm: kworker/0:1 Not tainted 5.1.0-next-20190514-00026-g01f0c75b902d-dirty #13 > > Hardware name: Allwinner sun8i Family > > Workqueue: events deferred_probe_work_func > > [] (unwind_backtrace) from [] (show_stack+0x10/0x14) > > [] (show_stack) from [] (dump_stack+0x84/0x98) > > [] (dump_stack) from [] (__warn+0xfc/0x114) > > [] (__warn) from [] (warn_slowpath_fmt+0x44/0x68) > > [] (warn_slowpath_fmt) from [] (drm_atomic_helper_wait_for_vblanks.part.1+0x298/0x2a0) > > [] (drm_atomic_helper_wait_for_vblanks.part.1) from [] (drm_atomic_helper_commit_tail_rpm+0x5c/0x6c) > > [] (drm_atomic_helper_commit_tail_rpm) from [] (commit_tail+0x40/0x6c) > > [] (commit_tail) from [] (drm_atomic_helper_commit+0xbc/0x128) > > [] (drm_atomic_helper_commit) from [] (restore_fbdev_mode_atomic+0x1cc/0x1dc) > > [] (restore_fbdev_mode_atomic) from [] (drm_fb_helper_restore_fbdev_mode_unlocked+0x54/0xa0) > > [] (drm_fb_helper_restore_fbdev_mode_unlocked) from [] (drm_fb_helper_set_par+0x30/0x54) > > [] (drm_fb_helper_set_par) from [] (fbcon_init+0x560/0x5ac) > > [] (fbcon_init) from [] (visual_init+0xbc/0x104) > > [] (visual_init) from [] (do_bind_con_driver+0x1b0/0x390) > > [] (do_bind_con_driver) from [] (do_take_over_console+0x13c/0x1c4) > > [] (do_take_over_console) from [] (do_fbcon_takeover+0x74/0xcc) > > [] (do_fbcon_takeover) from [] (notifier_call_chain+0x44/0x84) > > [] (notifier_call_chain) from [] (__blocking_notifier_call_chain+0x48/0x60) > > [] (__blocking_notifier_call_chain) from [] (blocking_notifier_call_chain+0x18/0x20) > > [] (blocking_notifier_call_chain) from [] (register_framebuffer+0x1e0/0x2f8) > > [] (register_framebuffer) from [] (__drm_fb_helper_initial_config_and_unlock+0x2fc/0x50c) > > [] (__drm_fb_helper_initial_config_and_unlock) from [] (drm_fbdev_client_hotplug+0xe8/0x1b8) > > [] (drm_fbdev_client_hotplug) from [] (drm_fbdev_generic_setup+0x88/0x118) > > [] (drm_fbdev_generic_setup) from [] (sun4i_drv_bind+0x128/0x160) > > [] (sun4i_drv_bind) from [] (try_to_bring_up_master+0x164/0x1a0) > > [] (try_to_bring_up_master) from [] (__component_add+0x94/0x140) > > [] (__component_add) from [] (sun6i_dsi_probe+0x144/0x234) > > [] (sun6i_dsi_probe) from [] (platform_drv_probe+0x48/0x9c) > > [] (platform_drv_probe) from [] (really_probe+0x1dc/0x2c8) > > [] (really_probe) from [] (driver_probe_device+0x60/0x160) > > [] (driver_probe_device) from [] (bus_for_each_drv+0x74/0xb8) > > [] (bus_for_each_drv) from [] (__device_attach+0xd0/0x13c) > > [] (__device_attach) from [] (bus_probe_device+0x84/0x8c) > > [] (bus_probe_device) from [] (deferred_probe_work_func+0x64/0x90) > > [] (deferred_probe_work_func) from [] (process_one_work+0x204/0x420) > > [] (process_one_work) from [] (worker_thread+0x274/0x5a0) > > [] (worker_thread) from [] (kthread+0x11c/0x14c) > > [] (kthread) from [] (ret_from_fork+0x14/0x2c) > > Exception stack(0xde539fb0 to 0xde539ff8) > > 9fa0: 00000000 00000000 00000000 00000000 > > 9fc0: 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 > > 9fe0: 00000000 00000000 00000000 00000000 00000013 00000000 > > ---[ end trace b57eb1e5c64c6b8b ]--- > > random: fast init done > > [drm:drm_atomic_helper_wait_for_dependencies] *ERROR* [CRTC:46:crtc-0] flip_done timed out > > [drm:drm_atomic_helper_wait_for_dependencies] *ERROR* [CONNECTOR:48:DSI-1] flip_done timed out > > [drm:drm_atomic_helper_wait_for_dependencies] *ERROR* [PLANE:30:plane-0] flip_done timed out > > > > With the terms(as described in above diagram) fixed, the panel > > displays correctly without any timeouts. > > > > Tested-by: Merlijn Wajer > > Signed-off-by: Jagan Teki > > Applied, thanks Thanks, would you apply the similar change in 3/7?