From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 83FE1C4161D for ; Tue, 20 Nov 2018 12:08:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 03AA1208E3 for ; Tue, 20 Nov 2018 12:07:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=amarulasolutions.com header.i=@amarulasolutions.com header.b="YT5/H7dJ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 03AA1208E3 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=amarulasolutions.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729483AbeKTWgN (ORCPT ); Tue, 20 Nov 2018 17:36:13 -0500 Received: from mail-it1-f194.google.com ([209.85.166.194]:39503 "EHLO mail-it1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728908AbeKTWgN (ORCPT ); Tue, 20 Nov 2018 17:36:13 -0500 Received: by mail-it1-f194.google.com with SMTP id m15so3085776itl.4 for ; Tue, 20 Nov 2018 04:07:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=X+oqhYJ+WjLifnUyJ3ft2kTzX1u4UUihC6oUhdtKyRY=; b=YT5/H7dJuhiULLUl1CQBXfWufpW9KT4Q4qWp0Bcqeu47cHuHiUP/yOWHGEHr1HIdI8 maG2SiNROzzz/8OHGtrg48aHqexMseCYNgr1CuQD5Q0fM7Vw92UBP9FyBUOLgoU40mst l3k4WdAtGJidbnKPu4QZ7n7vqhL6pp+rXIZdg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=X+oqhYJ+WjLifnUyJ3ft2kTzX1u4UUihC6oUhdtKyRY=; b=PpBoM+Pt4wZAh9FjW3d/pMnag6lEn+Z8Wug6iXennaEth2BW0Li8GlLbW/KzvoqT2V k3uzFioYKaEM7iN7qsRIPo2PnSgxvkngFcwg+bKlQoHVT+k4u1N/jtE0ynJ/w8+3cGw3 CkcJzjJ2r8McrAcFpt7zzkQyXJCBMSsnxmFbEs/xvaTbI0oBUy3Z3Z2+CQfnzeY3+1Tn VuoOvClK2kwhNZ1TiM7sgFBpxSeKyGvWE7w+f4dRX69O8S8VOLTC185H4N+23+R9I6lV 5oxUMjO14cP9Di5Cs8Alh/9pf55Cmgh1aEtRkRiymZbq/wdfOIQrnEieWv9Vcz/M+EQU ipsg== X-Gm-Message-State: AGRZ1gKqi8iGES5koKmReDAlmWh+54jwO755iQtYhW3EDOK1KnL273fg mX1QrZ1KTIglc/0GBuwMNtVR7e+n4qLkrgxS02bdQQ== X-Google-Smtp-Source: AJdET5cLqA6MlwAqkitC7ii3wAfw4YoaB8PO6E10qjr4OXZoLKzvcSDfsQ98CYU152g/zwt76hp/Z+seO+LYcGsydmE= X-Received: by 2002:a02:94d:: with SMTP id f74-v6mr1538521jad.85.1542715643416; Tue, 20 Nov 2018 04:07:23 -0800 (PST) MIME-Version: 1.0 References: <20181113111633.20189-1-jagan@amarulasolutions.com> <20181113111633.20189-4-jagan@amarulasolutions.com> <20181113132658.niwy6bqdqzaeqpv2@flea> <20181120105557.3mysirc3ga2h2334@flea> In-Reply-To: <20181120105557.3mysirc3ga2h2334@flea> From: Jagan Teki Date: Tue, 20 Nov 2018 17:37:11 +0530 Message-ID: Subject: Re: [PATCH v4 03/26] clk: sunxi-ng: Add check for maximum rate to NKM PLLs To: Maxime Ripard Cc: Chen-Yu Tsai , Icenowy Zheng , Jernej Skrabec , Vasily Khoruzhick , Rob Herring , Mark Rutland , Catalin Marinas , Will Deacon , David Airlie , dri-devel , Michael Turquette , Stephen Boyd , linux-clk , Michael Trimarchi , linux-arm-kernel , devicetree , linux-kernel , linux-sunxi@googlegroups.com, linux-amarula@amarulasolutions.com Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 20, 2018 at 4:26 PM Maxime Ripard wrote: > > On Thu, Nov 15, 2018 at 08:51:04PM +0530, Jagan Teki wrote: > > > > drivers/clk/sunxi-ng/ccu_nkm.c | 3 +++ > > > > drivers/clk/sunxi-ng/ccu_nkm.h | 1 + > > > > 2 files changed, 4 insertions(+) > > > > > > > > diff --git a/drivers/clk/sunxi-ng/ccu_nkm.c b/drivers/clk/sunxi-ng/ccu_nkm.c > > > > index 6b5ad990f802..b8b66cdd30bf 100644 > > > > --- a/drivers/clk/sunxi-ng/ccu_nkm.c > > > > +++ b/drivers/clk/sunxi-ng/ccu_nkm.c > > > > @@ -128,6 +128,9 @@ static unsigned long ccu_nkm_round_rate(struct ccu_mux_internal *mux, > > > > if (rate < nkm->min_rate) > > > > return nkm->min_rate; > > > > > > > > + if (nkm->max_rate && rate > nkm->max_rate) > > > > + return nkm->max_rate; > > > > + > > > > > > I would expect the test to be the same for the minimum and maximum cases. > > > > I don't have proper use-case for max rate test, I do verify by using > > higher the rate on dclock, but nor sure. May be I can skip the > > max_rate patch? > > So you're sending more patches that you haven't really tested? I didn't understand this question. > Why are you sending them then? I think I've mentioned in the first version patch itself, since it's common code and many other callers might have used for rate alternative I did it how other ccu dividers does. I have not added just as simple. > > > Apart from this, any idea about this issue where SUN4I_TCON0_DCLK_REG > > will only work with div upto 6 on A64 DSI panels[1], did you find the > > same issue on A33? > > IIRC my panel was falling into the case where the divider was 4, so > I've not fallen into that case. OK, thanks.