From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 00196C64EBD for ; Thu, 4 Oct 2018 16:06:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A4C4C2082A for ; Thu, 4 Oct 2018 16:06:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=amarulasolutions.com header.i=@amarulasolutions.com header.b="O26f44Rc" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A4C4C2082A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=amarulasolutions.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727803AbeJDXAN (ORCPT ); Thu, 4 Oct 2018 19:00:13 -0400 Received: from mail-it1-f194.google.com ([209.85.166.194]:52470 "EHLO mail-it1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727484AbeJDXAN (ORCPT ); Thu, 4 Oct 2018 19:00:13 -0400 Received: by mail-it1-f194.google.com with SMTP id 134-v6so13847643itz.2 for ; Thu, 04 Oct 2018 09:06:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=hZ3jQBWyij4szJ4UcNl1dG24LzSiXr3DVnkwp4Brar4=; b=O26f44RcPi261y4+VTT+u/RsxzYaE+FTcj2msaXPcd8rD1DPLvCS87+0VcBt7MExDh q4ULNEyAT1OAncgRjMQt0epc1CEkY+h550fMxr1tJP+J4SLhlwLIBBp8sP2tmfAJNSsW h6bzOBkEMzBre/x5M2DINya3alZZ8RoWE1XKs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=hZ3jQBWyij4szJ4UcNl1dG24LzSiXr3DVnkwp4Brar4=; b=eYynk/1bhz7e8q75+1yPCWiRqHSkFMKTNv73mwSOlDaFUQfXccDd7ghpxMIM0TWW+B ZCiaxmqZ3sqKtbtLxEvFMApccI3YnHIRjyEHOxZsqrvKHKb7DC9rTI2UvYXQM7hBdLQe D2234rqdks5RxJ0c99AIfxlO879fUBnws4yWBTgrrLnUYv7NkFLx2Nz8qI4vKPi0XZMT ytVWX3H1EVABd9DnwQxEC57z+BBy3AYiQs7KjFt7s++wfB0SHWGKD2VyubYThW24ozWu Lgzq3TOOnapepYPb9hMGv1SeKFtrkTR51piDUFbcnjw4IsER1xdDQfpbXgTP5k1K0zYT bL2Q== X-Gm-Message-State: ABuFfoiGQACJNuqqEpFeWB8oL/W9Z7s54etZ+jCCOf87p45vmGLPGsd5 paApzzyHYgGWKYpamYAvBujm9wftYdlOV8PQ19CrYQ== X-Google-Smtp-Source: ACcGV62TOMH4uOVRwVRqFkBEo78/dC0mINDRph+90DYhY99rtrRUaJaku3KC2dxq8lslZzF4UAhkF4mIHtuUID78G8I= X-Received: by 2002:a24:809:: with SMTP id 9-v6mr5191856itc.31.1538669177524; Thu, 04 Oct 2018 09:06:17 -0700 (PDT) MIME-Version: 1.0 References: <20180927114850.24565-1-jagan@amarulasolutions.com> <20180927114850.24565-11-jagan@amarulasolutions.com> In-Reply-To: From: Jagan Teki Date: Thu, 4 Oct 2018 21:36:05 +0530 Message-ID: Subject: Re: [PATCH 10/12] drm/panel: Add Bananapi S070WV20-CT16 MIPI-DSI panel driver To: Chen-Yu Tsai Cc: Maxime Ripard , Icenowy Zheng , Jernej Skrabec , Vasily Khoruzhick , Rob Herring , Mark Rutland , Catalin Marinas , Will Deacon , David Airlie , dri-devel , Michael Turquette , Stephen Boyd , linux-clk , Michael Trimarchi , linux-arm-kernel , devicetree , linux-kernel , linux-sunxi Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Sep 28, 2018 at 10:02 AM Chen-Yu Tsai wrote: > > On Thu, Sep 27, 2018 at 7:50 PM Jagan Teki wrote: > > > > Bananapi S070WV20-CT16 is 800x480, 4-lane MIPI-DSI panel which > > can be used to connect via BPI-M64 board, so add a driver for it. > > > > The same panel PCB comes with parallel RBG which is supported via > > panel-simple driver with "bananapi,s070wv20-ct16" compatible. > > As I mentioned before, this PCB uses a ICN6211 MIPI-DSI to RGB bridge. > Please model it as such. OK. > > > Signed-off-by: Jagan Teki > > --- > > drivers/gpu/drm/panel/Kconfig | 9 + > > drivers/gpu/drm/panel/Makefile | 1 + > > .../gpu/drm/panel/panel-bananapi-s070wv20.c | 336 ++++++++++++++++++ > > 3 files changed, 346 insertions(+) > > create mode 100644 drivers/gpu/drm/panel/panel-bananapi-s070wv20.c > > > > diff --git a/drivers/gpu/drm/panel/Kconfig b/drivers/gpu/drm/panel/Kconfig > > index 6020c30a33b3..d25960a63b10 100644 > > --- a/drivers/gpu/drm/panel/Kconfig > > +++ b/drivers/gpu/drm/panel/Kconfig > > @@ -17,6 +17,15 @@ config DRM_PANEL_ARM_VERSATILE > > reference designs. The panel is detected using special registers > > in the Versatile family syscon registers. > > > > +config DRM_PANEL_BANANAPI_S070WV20 > > + tristate "Bananapi S070WV20-CT16 MIPI-DSI panel driver" > > + depends on OF > > + depends on DRM_MIPI_DSI > > + depends on BACKLIGHT_CLASS_DEVICE > > + help > > + Say Y if you want to enable support for panels based on the > > + Bananapi S070WV20-CT16 MIPI-DSI controller. > > + > > config DRM_PANEL_LVDS > > tristate "Generic LVDS panel driver" > > depends on OF > > diff --git a/drivers/gpu/drm/panel/Makefile b/drivers/gpu/drm/panel/Makefile > > index 5ccaaa9d13af..345b6475d3a4 100644 > > --- a/drivers/gpu/drm/panel/Makefile > > +++ b/drivers/gpu/drm/panel/Makefile > > @@ -1,5 +1,6 @@ > > # SPDX-License-Identifier: GPL-2.0 > > obj-$(CONFIG_DRM_PANEL_ARM_VERSATILE) += panel-arm-versatile.o > > +obj-$(CONFIG_DRM_PANEL_BANANAPI_S070WV20) += panel-bananapi-s070wv20.o > > obj-$(CONFIG_DRM_PANEL_LVDS) += panel-lvds.o > > obj-$(CONFIG_DRM_PANEL_SIMPLE) += panel-simple.o > > obj-$(CONFIG_DRM_PANEL_ILITEK_IL9322) += panel-ilitek-ili9322.o > > diff --git a/drivers/gpu/drm/panel/panel-bananapi-s070wv20.c b/drivers/gpu/drm/panel/panel-bananapi-s070wv20.c > > new file mode 100644 > > index 000000000000..6c9adbec6dd8 > > --- /dev/null > > +++ b/drivers/gpu/drm/panel/panel-bananapi-s070wv20.c > > @@ -0,0 +1,336 @@ > > +// SPDX-License-Identifier: (GPL-2.0+ or MIT) > > +/* > > + * Copyright (C) 2018 Amarula Solutions > > + * Author: Jagan Teki > > + */ > > + > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > + > > +#include > > +#include > > + > > +#include > > +#include > > +#include > > + > > +#include