From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3F73FC43613 for ; Mon, 24 Jun 2019 16:02:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CBC9F20673 for ; Mon, 24 Jun 2019 16:02:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=amarulasolutions.com header.i=@amarulasolutions.com header.b="TELgOvYq" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731471AbfFXQCY (ORCPT ); Mon, 24 Jun 2019 12:02:24 -0400 Received: from mail-io1-f67.google.com ([209.85.166.67]:46803 "EHLO mail-io1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728416AbfFXQCY (ORCPT ); Mon, 24 Jun 2019 12:02:24 -0400 Received: by mail-io1-f67.google.com with SMTP id i10so1243713iol.13 for ; Mon, 24 Jun 2019 09:02:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=+QxcUL4CilwX16coEsIXXTDXwDxzE6GpVqhF0z074is=; b=TELgOvYqrsUQdwNcsefZFJ4UJyHg5CyNMDe0ThhQFQB/Wq7s4XZqDgDQyEl29OQQeL iikdwE08bmmGcIFSJPpU5fK+hQdGpWfsOBnXMppQzDWtFfVav8dfrcUU2U4gVB9ZOweX QJKoHk/PL85ebzpiTslx5bTzjdsu2ncO2w1Wo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=+QxcUL4CilwX16coEsIXXTDXwDxzE6GpVqhF0z074is=; b=T/I7dglwMU7uhAP/7PueAaBG3cGZXlyfLxHkoq+lhDVlCpXUPTEQnp3osNWL1Oycdr s7fETR2DtN6ik8qm3vmycHsxQFfd5a4cxsMJZapvMYS78a6ImTfatwxXq2Pj/djyNtg7 KGSCf6aAdU45m1xbFK36IIWNadw+XiZXaXv7S2+5ofNGHwFI+i3nCCj7TzdSMtWZWOzt fplE/uiCkRL23TAY0vDJ/WT7v294np4/gGf5dld0Q2LJrMsBDdbpdm+tJisNCytTBfHa rmQ4YTZM/NKVS4r9DIyaznUAv8CIyf0eA3BV8PxotMq9CuSf5dy1j9mV4BlftizwUbnw idfQ== X-Gm-Message-State: APjAAAVvBoHfC621vTfJRGPKSHN7jG0wsGvFY0mm06r0e5NmPtxTjDE5 K62UMspQSKrtT/+Yi4NzQqiwA36EBvCsgfOmfWYlWA== X-Google-Smtp-Source: APXvYqyRkDCO3GEjMe3TJ9+gSRguxeeRU5rxueUVmJmQxyLTexEYqjZ1qtoY/vTbw73Gr5gAysM++5FSWtzzosCb8Ls= X-Received: by 2002:a05:6638:3d6:: with SMTP id r22mr41805399jaq.71.1561392142964; Mon, 24 Jun 2019 09:02:22 -0700 (PDT) MIME-Version: 1.0 References: <20190520090318.27570-1-jagan@amarulasolutions.com> <20190520090318.27570-5-jagan@amarulasolutions.com> <20190523204823.mx7l4ozklzdh7npn@flea> <20190604143016.fcx3ezmga244xakp@flea> <20190613131626.7zbwvrvd4e7eafrc@flea> <20190624130442.ww4l3zctykr4i2e2@flea> In-Reply-To: <20190624130442.ww4l3zctykr4i2e2@flea> From: Jagan Teki Date: Mon, 24 Jun 2019 21:32:11 +0530 Message-ID: Subject: Re: [linux-sunxi] Re: [PATCH v10 04/11] drm/sun4i: tcon: Compute DCLK dividers based on format, lanes To: Maxime Ripard Cc: David Airlie , Daniel Vetter , Chen-Yu Tsai , dri-devel , linux-arm-kernel , linux-kernel , Bhushan Shah , Vasily Khoruzhick , =?UTF-8?B?5Z2a5a6a5YmN6KGM?= , Michael Trimarchi , linux-amarula , linux-sunxi Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 24, 2019 at 6:34 PM Maxime Ripard wrote: > > On Fri, Jun 14, 2019 at 05:33:23PM +0530, Jagan Teki wrote: > > On Thu, Jun 13, 2019 at 7:28 PM Maxime Ripard wrote: > > > > > > On Wed, Jun 05, 2019 at 01:11:44PM +0530, Jagan Teki wrote: > > > > On Tue, Jun 4, 2019 at 8:00 PM Maxime Ripard wrote: > > > > > > > > > > On Fri, May 24, 2019 at 03:37:36PM +0530, Jagan Teki wrote: > > > > > > On Fri, May 24, 2019 at 2:18 AM Maxime Ripard wrote: > > > > > > > > > > > > > > On Mon, May 20, 2019 at 02:33:11PM +0530, Jagan Teki wrote: > > > > > > > > pll-video => pll-mipi => tcon0 => tcon0-pixel-clock is the typical > > > > > > > > MIPI clock topology in Allwinner DSI controller. > > > > > > > > > > > > > > > > TCON dotclock driver is computing the desired DCLK divider based on > > > > > > > > panel pixel clock along with input DCLK min, max divider values from > > > > > > > > tcon driver and that would eventually set the pll-mipi clock rate. > > > > > > > > > > > > > > > > The current code is passing dsi min and max divider value as 4 via > > > > > > > > tcon driver which would ended-up triggering below vblank wait timed out > > > > > > > > warning on "bananapi,s070wv20-ct16" panel. > > > > > > > > > > > > > > > > WARNING: CPU: 0 PID: 31 at drivers/gpu/drm/drm_atomic_helper.c:1429 drm_atomic_helper_wait_for_vblanks.part.1+0x298/0x2a0 > > > > > > > > [CRTC:46:crtc-0] vblank wait timed out > > > > > > > > Modules linked in: > > > > > > > > CPU: 0 PID: 31 Comm: kworker/0:1 Not tainted 5.1.0-next-20190514-00025-g5186cdf10757-dirty #6 > > > > > > > > Hardware name: Allwinner sun8i Family > > > > > > > > Workqueue: events deferred_probe_work_func > > > > > > > > [] (unwind_backtrace) from [] (show_stack+0x10/0x14) > > > > > > > > [] (show_stack) from [] (dump_stack+0x84/0x98) > > > > > > > > [] (dump_stack) from [] (__warn+0xfc/0x114) > > > > > > > > [] (__warn) from [] (warn_slowpath_fmt+0x44/0x68) > > > > > > > > [] (warn_slowpath_fmt) from [] (drm_atomic_helper_wait_for_vblanks.part.1+0x298/0x2a0) > > > > > > > > [] (drm_atomic_helper_wait_for_vblanks.part.1) from [] (drm_atomic_helper_commit_tail_rpm+0x5c/0x6c) > > > > > > > > [] (drm_atomic_helper_commit_tail_rpm) from [] (commit_tail+0x40/0x6c) > > > > > > > > [] (commit_tail) from [] (drm_atomic_helper_commit+0xbc/0x128) > > > > > > > > [] (drm_atomic_helper_commit) from [] (restore_fbdev_mode_atomic+0x1cc/0x1dc) > > > > > > > > [] (restore_fbdev_mode_atomic) from [] (drm_fb_helper_restore_fbdev_mode_unlocked+0x54/0xa0) > > > > > > > > [] (drm_fb_helper_restore_fbdev_mode_unlocked) from [] (drm_fb_helper_set_par+0x30/0x54) > > > > > > > > [] (drm_fb_helper_set_par) from [] (fbcon_init+0x560/0x5ac) > > > > > > > > [] (fbcon_init) from [] (visual_init+0xbc/0x104) > > > > > > > > [] (visual_init) from [] (do_bind_con_driver+0x1b0/0x390) > > > > > > > > [] (do_bind_con_driver) from [] (do_take_over_console+0x13c/0x1c4) > > > > > > > > [] (do_take_over_console) from [] (do_fbcon_takeover+0x74/0xcc) > > > > > > > > [] (do_fbcon_takeover) from [] (notifier_call_chain+0x44/0x84) > > > > > > > > [] (notifier_call_chain) from [] (__blocking_notifier_call_chain+0x48/0x60) > > > > > > > > [] (__blocking_notifier_call_chain) from [] (blocking_notifier_call_chain+0x18/0x20) > > > > > > > > [] (blocking_notifier_call_chain) from [] (register_framebuffer+0x1e0/0x2f8) > > > > > > > > [] (register_framebuffer) from [] (__drm_fb_helper_initial_config_and_unlock+0x2fc/0x50c) > > > > > > > > [] (__drm_fb_helper_initial_config_and_unlock) from [] (drm_fbdev_client_hotplug+0xe8/0x1b8) > > > > > > > > [] (drm_fbdev_client_hotplug) from [] (drm_fbdev_generic_setup+0x88/0x118) > > > > > > > > [] (drm_fbdev_generic_setup) from [] (sun4i_drv_bind+0x128/0x160) > > > > > > > > [] (sun4i_drv_bind) from [] (try_to_bring_up_master+0x164/0x1a0) > > > > > > > > [] (try_to_bring_up_master) from [] (__component_add+0x94/0x140) > > > > > > > > [] (__component_add) from [] (sun6i_dsi_probe+0x144/0x234) > > > > > > > > [] (sun6i_dsi_probe) from [] (platform_drv_probe+0x48/0x9c) > > > > > > > > [] (platform_drv_probe) from [] (really_probe+0x1dc/0x2c8) > > > > > > > > [] (really_probe) from [] (driver_probe_device+0x60/0x160) > > > > > > > > [] (driver_probe_device) from [] (bus_for_each_drv+0x74/0xb8) > > > > > > > > [] (bus_for_each_drv) from [] (__device_attach+0xd0/0x13c) > > > > > > > > [] (__device_attach) from [] (bus_probe_device+0x84/0x8c) > > > > > > > > [] (bus_probe_device) from [] (deferred_probe_work_func+0x64/0x90) > > > > > > > > [] (deferred_probe_work_func) from [] (process_one_work+0x204/0x420) > > > > > > > > [] (process_one_work) from [] (worker_thread+0x274/0x5a0) > > > > > > > > [] (worker_thread) from [] (kthread+0x11c/0x14c) > > > > > > > > [] (kthread) from [] (ret_from_fork+0x14/0x2c) > > > > > > > > Exception stack(0xde539fb0 to 0xde539ff8) > > > > > > > > 9fa0: 00000000 00000000 00000000 00000000 > > > > > > > > 9fc0: 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 > > > > > > > > 9fe0: 00000000 00000000 00000000 00000000 00000013 00000000 > > > > > > > > ---[ end trace 4017fea4906ab391 ]--- > > > > > > > > > > > > > > > > But accordingly to Allwinner A33, A64 BSP codes [1] [2] this divider > > > > > > > > is clearly using 'format/lanes' for dsi divider value, dsi_clk.clk_div > > > > > > > > > > > > > > > > Which would compute the pll_freq and set a clock rate for it in > > > > > > > > [3] and [4] respectively. > > > > > > > > > > > > > > > > The same issue has reproduced in A33, A64 with 4-lane and 2-lane devices > > > > > > > > and got fixed with this computation logic 'format/lanes', so this patch > > > > > > > > using dclk min and max dividers as per BSP. > > > > > > > > > > > > > > > > [1] https://github.com/BPI-SINOVOIP/BPI-M2M-bsp/blob/master/linux-sunxi/drivers/video/sunxi/disp/de/disp_lcd.c#L1106 > > > > > > > > [2] https://github.com/BPI-SINOVOIP/BPI-M64-bsp/blob/master/linux-sunxi/drivers/video/sunxi/disp2/disp/de/lowlevel_sun50iw1/disp_al.c#L213 > > > > > > > > [3] https://github.com/BPI-SINOVOIP/BPI-M2M-bsp/blob/master/linux-sunxi/drivers/video/sunxi/disp/de/disp_lcd.c#L1127 > > > > > > > > [4] https://github.com/BPI-SINOVOIP/BPI-M2M-bsp/blob/master/linux-sunxi/drivers/video/sunxi/disp/de/disp_lcd.c#L1161 > > > > > > > > > > > > > > In that mail, I've pointed out that clk_div isn't used for the TCON dclk divider: > > > > > > > http://lists.infradead.org/pipermail/linux-arm-kernel/2019-February/629596.html > > > > > > > > > > > > > > The only reply you've sent is that you indeed see that the divider is > > > > > > > set to 4 in the BSP, but you're now saying that the BSP can change > > > > > > > it. If so, then please point exactly the flaw in the explanation in > > > > > > > that mail. > > > > > > > > > > > > Frankly, I have explained these details in commit message and previous > > > > > > version patch[1] with print messages on the code. > > > > > > > > > > > > BSP has tcon_div and dsi_div. dsi_div is dynamic which depends on > > > > > > bpp/lanes and it indeed depends on PLL computation (not tcon_div), > > > > > > anyway I have explained again on this initial link you mentioned. > > > > > > Please have a look and get back. > > > > > > > > > > I'll have a look, thanks. > > > > > > > > > > I've given your patches a try on my setup though, and this patch > > > > > breaks it with vblank timeouts and some horizontal lines that looks > > > > > like what should be displayed, but blinking and on the right of the > > > > > display. The previous ones are fine though. > > > > > > > > Would you please send me the link of panel driver. > > > > > > It's drivers/gpu/drm/panel/panel-ronbo-rb070d30.c > > > > Look like this panel work even w/o any vendor sequence. it's similar > > to the 4-lane panel I have with RGB888, so the dclk div is 6, is it > > working with this divider? > > It works with 4, it doesn't work with 6. Can be the pixel clock with associated timings can make this diff. Would you send me the pixel clock, pll_rate and timings this panel used it from BSP?