From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0D05BC433E0 for ; Thu, 7 Jan 2021 06:50:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id ABEF122E00 for ; Thu, 7 Jan 2021 06:50:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726313AbhAGGuD (ORCPT ); Thu, 7 Jan 2021 01:50:03 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40952 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725306AbhAGGuC (ORCPT ); Thu, 7 Jan 2021 01:50:02 -0500 Received: from mail-ed1-x52a.google.com (mail-ed1-x52a.google.com [IPv6:2a00:1450:4864:20::52a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0BF15C0612F5 for ; Wed, 6 Jan 2021 22:49:21 -0800 (PST) Received: by mail-ed1-x52a.google.com with SMTP id cm17so6732167edb.4 for ; Wed, 06 Jan 2021 22:49:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=iluA/f+Nx9iV4l3x2XO+uEUXDpQareT2nFvYNJnsH5U=; b=r6tcrQG2/r/1bXPuM3no1kaZ76iN3GEwjWW/bK2ooP6Dysos6JF1c2RfN5OfXFqhLS K4daUnqvzUeN8ScOhnhRmY882C2r0ella8LhzTH6HqqZZZQdiUAM+Lc9rY8asQwizZxj 4WTtRpysuaOKxbJXPlL4wlm7YxMxZlmdEpuvQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=iluA/f+Nx9iV4l3x2XO+uEUXDpQareT2nFvYNJnsH5U=; b=HNH+5SArf1blXrveVK2koHSlYd39kBITXvGHk1JTntSkYJPNBCwyDMpfF725Jh656o ddK9GOfJHlqMAWBrRFL3ex0Sz4+CXoF04oDOnFiJqOaBCkDz5aoLBoERMz1CIiG8zxiK AtmMSZ4wJumcpwGEVB+RhYSUQzeImYCqNnF2scH5BCZ2VMFAKV9kLiwx6wuFC5/uzfZ6 ZHQoHCmhe66maseiFCCsHS5PDGrp7BgfhvRfSYfG0lC613igdgpiN6ZXYqmbMALrxhkD klV3F1BIkn7QBVS0CsCzDuRVghU4o2QizLUQ+xkCTY2xm7GKY4L0B9gECAtmtZVrGtYi 1AWg== X-Gm-Message-State: AOAM53344ByT9JEp9qXbyz25e+D9PT27vs9i8lbItPiZXhjFF5SAR1kg FhX4XskWjJicnnAWqqR3x21kll3c8Sg3QI1r3E25nR8d1fMf6Q== X-Google-Smtp-Source: ABdhPJztcw6+ch3jIP1KsxwisrTgHXjVHJJf4yU30FjteHikhnzele/d/izfDLVgev1PeSNgdb48lclIc9s8z+pl29g= X-Received: by 2002:a50:d80c:: with SMTP id o12mr558299edj.338.1610002159811; Wed, 06 Jan 2021 22:49:19 -0800 (PST) MIME-Version: 1.0 References: <20201128125257.1626588-1-icenowy@aosc.io> In-Reply-To: From: Jagan Teki Date: Thu, 7 Jan 2021 12:19:08 +0530 Message-ID: Subject: Re: [PATCH] drm/panel: feiyang-fy07024di26a30d: cleanup if panel attaching failed To: Icenowy Zheng Cc: Thierry Reding , Sam Ravnborg , David Airlie , Daniel Vetter , dri-devel , linux-kernel Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 7, 2021 at 10:16 AM Icenowy Zheng wrote: > > > > =E4=BA=8E 2021=E5=B9=B41=E6=9C=886=E6=97=A5 GMT+08:00 =E4=B8=8B=E5=8D=885= :47:20, Jagan Teki =E5=86=99=E5=88=B0: > >On Sat, Nov 28, 2020 at 6:23 PM Icenowy Zheng wrote: > >> > >> Attaching the panel can fail, so cleanup work is necessary, otherwise > >> a pointer to freed struct drm_panel* will remain in drm_panel code. > >> > >> Do the cleanup if panel attaching failed. > >> > >> Fixes: 69dc678abc2b ("drm/panel: Add Feiyang FY07024DI26A30-D > >MIPI-DSI LCD panel") > > > >The fact that this has failed to probe due to recent changes in > >sun6i_mipi_dsi.c I don't know how to put that into the commit message. > > It's not related, we shouldn't assume this panel driver will always > be used with sunxi SoCs. Well, I'm aware of it. What I'm trying to say is this panel has referenced with one of exiting panel in a tree and that indeed return mipi_dsi_attach and it verified with DSI host at that time. > > It's a panel driver bug that cannot deal with -EPROBE_DEFER well. Yes, ie reason I have added Reviewed-by tag above. Jagan.