From: Jagan Teki <jagan@amarulasolutions.com>
To: Rob Herring <robh@kernel.org>, devicetree <devicetree@vger.kernel.org>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Chen-Yu Tsai <wens@csie.org>,
linux-input@vger.kernel.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Michael Trimarchi <michael@amarulasolutions.com>,
linux-amarula@amarulasolutions.com
Subject: Re: [PATCH v3 1/4] dt-bindings: input: touchscreen: goodix: Document AVDD28-supply property
Date: Fri, 18 Jan 2019 21:31:04 +0530 [thread overview]
Message-ID: <CAMty3ZCyq=tZMt6RC1aYJuEWgYp2zv1LBh+ZUwucE+g4RCoUaQ@mail.gmail.com> (raw)
In-Reply-To: <CAL_JsqKTnPVM7Qahy9ejQbPfENpLCdzf5K5uUTcPh8j3EiqWRA@mail.gmail.com>
On Wed, Jan 9, 2019 at 7:08 PM Rob Herring <robh@kernel.org> wrote:
>
> Please CC DT list if you want bindings reviewed.
Sorry I forgot.
>
> On Wed, Jan 9, 2019 at 1:40 AM Dmitry Torokhov
> <dmitry.torokhov@gmail.com> wrote:
> >
> > On Sat, Dec 15, 2018 at 08:47:59PM +0530, Jagan Teki wrote:
> > > Most of the Goodix CTP controllers are supply with AVDD28 pin.
> > > which need to supply for controllers like GT5663 on some boards
> > > to trigger the power.
> > >
> > > So, document the supply property so-that the require boards
> > > that used on GT5663 can enable it via device tree.
> > >
> > > Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
> > > ---
> > > Documentation/devicetree/bindings/input/touchscreen/goodix.txt | 1 +
> > > 1 file changed, 1 insertion(+)
> > >
> > > diff --git a/Documentation/devicetree/bindings/input/touchscreen/goodix.txt b/Documentation/devicetree/bindings/input/touchscreen/goodix.txt
> > > index f7e95c52f3c7..c4622c983e08 100644
> > > --- a/Documentation/devicetree/bindings/input/touchscreen/goodix.txt
> > > +++ b/Documentation/devicetree/bindings/input/touchscreen/goodix.txt
> > > @@ -23,6 +23,7 @@ Optional properties:
> > > - touchscreen-inverted-y : Y axis is inverted (boolean)
> > > - touchscreen-swapped-x-y : X and Y axis are swapped (boolean)
> > > (swapping is done after inverting the axis)
> > > + - AVDD28-supply : Analog power supply regulator on AVDD28 pin
> >
> > I think we normally use lower case in DT bindings and rarely encode
> > voltage in the supply name unless we are dealing with several supplies
> > of the same kind, but I'll let Ron comment on this.
>
> Yes on lowercase though there are some exceptions.
>
> There's also a AVDD22 supply as well as DVDD12 and VDDIO. So we
> probably need to keep the voltage, but the binding is incomplete.
What is incomplete here? can you please elaborate.
next prev parent reply other threads:[~2019-01-18 16:01 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-15 15:17 [PATCH v3 0/4] input: touchscreen: Add goodix GT5553 CTP support Jagan Teki
2018-12-15 15:17 ` [PATCH v3 1/4] dt-bindings: input: touchscreen: goodix: Document AVDD28-supply property Jagan Teki
2019-01-07 22:58 ` Dmitry Torokhov
2019-01-09 13:37 ` Rob Herring
2019-01-18 16:01 ` Jagan Teki [this message]
2019-01-21 16:16 ` Rob Herring
[not found] ` <CAMty3ZBtoocXBW5A0astyQPh2y7vG7NtbZ_M0BjSeex2etmGsw@mail.gmail.com>
2019-01-24 4:32 ` Jagan Teki
2019-02-13 21:51 ` Rob Herring
2019-02-17 7:51 ` Jagan Teki
2019-02-17 9:15 ` Jagan Teki
2019-02-18 7:12 ` Dmitry Torokhov
2019-02-18 9:33 ` Jagan Teki
2019-02-18 19:30 ` Jagan Teki
2019-02-19 8:15 ` Dmitry Torokhov
2019-02-19 8:45 ` Jagan Teki
2018-12-15 15:18 ` [PATCH v3 2/4] Input: goodix - Add AVDD28-supply regulator support Jagan Teki
2019-01-07 23:00 ` Dmitry Torokhov
2019-01-31 20:00 ` Jagan Teki
2019-02-01 8:18 ` Dmitry Torokhov
2018-12-15 15:18 ` [PATCH v3 3/4] dt-bindings: input: touchscreen: goodix: Add GT5663 compatible Jagan Teki
2018-12-15 15:18 ` [PATCH v3 4/4] Input: goodix - Add GT5663 CTP support Jagan Teki
2019-01-06 16:38 ` [PATCH v3 0/4] input: touchscreen: Add goodix GT5553 " Jagan Teki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMty3ZCyq=tZMt6RC1aYJuEWgYp2zv1LBh+ZUwucE+g4RCoUaQ@mail.gmail.com' \
--to=jagan@amarulasolutions.com \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-amarula@amarulasolutions.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michael@amarulasolutions.com \
--cc=robh@kernel.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).