From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B4A8FC433E2 for ; Wed, 9 Sep 2020 16:38:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 34A5920C09 for ; Wed, 9 Sep 2020 16:38:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=amarulasolutions.com header.i=@amarulasolutions.com header.b="bmYvV+I7" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730997AbgIIQiI (ORCPT ); Wed, 9 Sep 2020 12:38:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58070 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731231AbgIIQhn (ORCPT ); Wed, 9 Sep 2020 12:37:43 -0400 Received: from mail-ej1-x641.google.com (mail-ej1-x641.google.com [IPv6:2a00:1450:4864:20::641]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 146DDC06134F for ; Wed, 9 Sep 2020 06:57:02 -0700 (PDT) Received: by mail-ej1-x641.google.com with SMTP id q13so3679776ejo.9 for ; Wed, 09 Sep 2020 06:57:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=MENKoY7sLjEa2j5YMFoQoj6IgU1USAsQMBDdxrkFhWc=; b=bmYvV+I7LEbseXbHhtlbAYck9NqN46DhFgxBTsEeJ62wPE19xy8BFBuma+r8HSDDl1 iuZJZ8QGSo4EVy9qOeJDa/xYKE2GSamLaVyFqXD1HKbEk2ngrJbnqfyNRdiR66NIpRwA 3s9f9mHs1brTm/hm5ADtRKLLPVEXeFDabl0+E= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=MENKoY7sLjEa2j5YMFoQoj6IgU1USAsQMBDdxrkFhWc=; b=uUAy77XGZRYN4wvGR2A1wfHmdztqPv80L3FCgtChjt/ngcBjEHsNdOleyl1ovP6Bk+ GOpVmz2R1dPjilnP2EGVTxtZTmVEuLALr+qgXyq/uhkP7Sp2FhtWgMBIa/kPMnMykNpm vnezPgiR0iLSp8E6QS14sfVwJPRpDdfjC6DA/XfA925gsMmAdieKaQizSAKuos8QCVx6 +NwBgR/CQ9cxv+D5+a1FOV+H/lye6D3LOYXHbpVE8xYcLta02gcM5DhkXkY4eer+BUZz WdW/xbeButN8IT7mhL8uNul/Dhdf51b4ZuyL6fpblnEbzi+GyrLu2RyG0DX6DmHbqhJj iZpg== X-Gm-Message-State: AOAM532YCZWxwglft2pi1gECWWyJ0ikrNPEcN1CJNKt1AJnJShO2ldN4 f8EqVVHiszMGc0knW3Yp8DocT0cidTaytkGLYyrBWw== X-Google-Smtp-Source: ABdhPJwG32nnroeWUrNq1UG84+2uFGxqral4DWpgnb4iJnEw6uoi6YO7+CdOPDvYDAQ+31gRePqleCHukCNdIJR9k7U= X-Received: by 2002:a17:906:c1c6:: with SMTP id bw6mr2327666ejb.374.1599659818729; Wed, 09 Sep 2020 06:56:58 -0700 (PDT) MIME-Version: 1.0 References: <20200904191830.387296-1-jagan@amarulasolutions.com> <6955091.ERBjKZ0CLf@diego> In-Reply-To: <6955091.ERBjKZ0CLf@diego> From: Jagan Teki Date: Wed, 9 Sep 2020 19:26:47 +0530 Message-ID: Subject: Re: [PATCH 0/3] extcon: Add Type-C Virtual PD To: =?UTF-8?Q?Heiko_St=C3=BCbner?= Cc: MyungJoo Ham , Chanwoo Choi , Rob Herring , Tom Cubie , devicetree , linux-arm-kernel , "open list:ARM/Rockchip SoC..." , linux-kernel , linux-amarula Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Heiko, On Sat, Sep 5, 2020 at 2:53 AM Heiko St=C3=BCbner wrote: > > Hi Jagan, > > Am Freitag, 4. September 2020, 21:18:27 CEST schrieb Jagan Teki: > > USB Type-C protocol supports various modes of operations > > includes PD, USB3, and Altmode. If the platform design > > supports a Type-C connector then configuring these modes > > can be done via enumeration. > > > > However, there are some platforms that design these modes > > of operations as separate protocol connectors like design > > Display Port from on-chip USB3 controller. So accessing > > Type-C Altmode Display Port via onboard Display Port > > connector instead of a Type-C connector. > > > > These kinds of platforms require an explicit extcon driver > > in order to handle Power Delivery and Port Detection. > > > > This series support this Type-C Virtual PD and enable the > > same in ROCK Pi 4C SBC. > > > > Any inputs? > > I tend to disagree on the design via an extcon. Okay, are you disagree with the extcon extension for fusb chips routing or entire rk3399 designs? I totally agree with this point of bypassing extcon for the designs which has fusb302 chips. My only concern is about designs that don't have fusb chips - for example rock-pi-4. Designs that do have fusb302 chips, has dynamic possibilities to identify data roles, like detecting Altmode DP via Type-C connector whereas designs that don't have fusb302 or any type-c chip need static identification of data role, polarity, and ss for detecting direct DP port ie where virtual-pd is useful. Look like we have two potential issues of handling DP on rk3399 here, let me know if you think these non-type-c chips designs also possible to detect w/o extcon? Jagan.