From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Dan Murphy <dmurphy@ti.com>
Cc: "David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Sergei Shtylyov <sergei.shtylyov@gmail.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Andrew Lunn <andrew@lunn.ch>,
Oleksij Rempel <linux@rempel-privat.de>,
Philippe Schenker <philippe.schenker@toradex.com>,
Heiner Kallweit <hkallweit1@gmail.com>,
Kazuya Mizuguchi <kazuya.mizuguchi.ks@renesas.com>,
Wolfram Sang <wsa+renesas@sang-engineering.com>,
Magnus Damm <magnus.damm@gmail.com>,
netdev <netdev@vger.kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net-next v4 5/5] ravb: Add support for explicit internal clock delay configuration
Date: Fri, 18 Sep 2020 11:04:02 +0200 [thread overview]
Message-ID: <CAMuHMdU+C9_mKJHtpevohkMkbHyur0gaVq1PvXnmY7cMHrSmWQ@mail.gmail.com> (raw)
In-Reply-To: <29970fbf-9779-d182-5df9-4f563f377311@ti.com>
Hi Dan,
On Thu, Sep 17, 2020 at 8:50 PM Dan Murphy <dmurphy@ti.com> wrote:
> On 9/17/20 8:57 AM, Geert Uytterhoeven wrote:
> > Some EtherAVB variants support internal clock delay configuration, which
> > can add larger delays than the delays that are typically supported by
> > the PHY (using an "rgmii-*id" PHY mode, and/or "[rt]xc-skew-ps"
> > properties).
> >
> > Historically, the EtherAVB driver configured these delays based on the
> > "rgmii-*id" PHY mode. This caused issues with PHY drivers that
> > implement PHY internal delays properly[1]. Hence a backwards-compatible
> > workaround was added by masking the PHY mode[2].
> >
> > Add proper support for explicit configuration of the MAC internal clock
> > delays using the new "[rt]x-internal-delay-ps" properties.
> > Fall back to the old handling if none of these properties is present.
> >
> > [1] Commit bcf3440c6dd78bfe ("net: phy: micrel: add phy-mode support for
> > the KSZ9031 PHY")
> > [2] Commit 9b23203c32ee02cd ("ravb: Mask PHY mode to avoid inserting
> > delays twice").
> >
> > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> > Reviewed-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
> > Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
> > @@ -1989,20 +1986,41 @@ static const struct soc_device_attribute ravb_delay_mode_quirk_match[] = {
> > };
> >
> > /* Set tx and rx clock internal delay modes */
> > -static void ravb_parse_delay_mode(struct net_device *ndev)
> > +static void ravb_parse_delay_mode(struct device_node *np, struct net_device *ndev)
> > {
> > struct ravb_private *priv = netdev_priv(ndev);
> > + bool explicit_delay = false;
> > + u32 delay;
> > +
> > + if (!of_property_read_u32(np, "rx-internal-delay-ps", &delay)) {
> > + /* Valid values are 0 and 1800, according to DT bindings */
> > + priv->rxcidm = !!delay;
> > + explicit_delay = true;
> > + }
> > + if (!of_property_read_u32(np, "tx-internal-delay-ps", &delay)) {
> > + /* Valid values are 0 and 2000, according to DT bindings */
> > + priv->txcidm = !!delay;
> > + explicit_delay = true;
> > + }
> There are helper functions for this
>
> s32 phy_get_internal_delay(struct phy_device *phydev, struct device
> *dev, const int *delay_values, int size, bool is_rx)
That helper operates on the PHY device, not on the MAC device.
Cfr. what I stated in the cover letter:
This can be considered the MAC counterpart of commit 9150069bf5fc0e86
("dt-bindings: net: Add tx and rx internal delays"), which applies to
the PHY. Note that unlike commit 92252eec913b2dd5 ("net: phy: Add a
helper to return the index for of the internal delay"), no helpers are
provided to parse the DT properties, as so far there is a single user
only, which supports only zero or a single fixed value. Of course such
helpers can be added later, when the need arises, or when deemed useful
otherwise.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
next prev parent reply other threads:[~2020-09-18 9:04 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-17 13:57 [PATCH net-next v4 0/5] net/ravb: Add support for explicit internal clock delay configuration Geert Uytterhoeven
2020-09-17 13:57 ` [PATCH net-next v4 1/5] dt-bindings: net: ethernet-controller: Add internal delay properties Geert Uytterhoeven
2020-09-17 13:57 ` [PATCH net-next v4 2/5] dt-bindings: net: renesas,ravb: Document internal clock " Geert Uytterhoeven
2020-09-17 13:57 ` [PATCH net-next v4 3/5] dt-bindings: net: renesas,etheravb: Convert to json-schema Geert Uytterhoeven
2020-09-17 13:57 ` [PATCH net-next v4 4/5] ravb: Split delay handling in parsing and applying Geert Uytterhoeven
2020-09-17 13:57 ` [PATCH net-next v4 5/5] ravb: Add support for explicit internal clock delay configuration Geert Uytterhoeven
2020-09-17 18:49 ` Dan Murphy
2020-09-18 9:04 ` Geert Uytterhoeven [this message]
2020-09-30 12:21 ` [PATCH net-next v4 0/5] net/ravb: " Geert Uytterhoeven
2020-09-30 21:19 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMuHMdU+C9_mKJHtpevohkMkbHyur0gaVq1PvXnmY7cMHrSmWQ@mail.gmail.com \
--to=geert@linux-m68k.org \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=dmurphy@ti.com \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=kazuya.mizuguchi.ks@renesas.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux@rempel-privat.de \
--cc=magnus.damm@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=philippe.schenker@toradex.com \
--cc=robh+dt@kernel.org \
--cc=sergei.shtylyov@gmail.com \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).