From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 64931C636CA for ; Fri, 16 Jul 2021 07:38:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4F2D3613E9 for ; Fri, 16 Jul 2021 07:38:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236709AbhGPHlh (ORCPT ); Fri, 16 Jul 2021 03:41:37 -0400 Received: from mail-vs1-f45.google.com ([209.85.217.45]:42681 "EHLO mail-vs1-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231966AbhGPHld (ORCPT ); Fri, 16 Jul 2021 03:41:33 -0400 Received: by mail-vs1-f45.google.com with SMTP id u7so4479122vst.9; Fri, 16 Jul 2021 00:38:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=/8xw8kA+i02VusdPbd0JDRclj3jeC0DgBPnvEpMrBZo=; b=eXRKIlFJb5txJErZQlr54C0z65DSs1meTzz1poPWBkumvap6WBGWeDyCuXCxufOP3y jr0xhuE14rkhTTLkOhpcZSCXaGm8R/aRS9SQ5MRBz7SbxGafX8sPKbBhUFFfn0w4ELVG Hf2glLV09ggm/u2f5Ymt/S9YiLYFFPg6i8+2wdFNW4NO3uj8sus/1HQqJZ+0gzvVzuGx rufNsds94vKYXEb0kTB3GtCyra84Lx0Vjjno/6xK6Eq+FgG24RG9aD8zznYghPNZzQIN ddBgxyymAKAUAzjHyw8cFWpPtOrRq2iEvgBYPes7UgKLCoAhH3i/9E6UMTXpO7pZDFGY 4wHA== X-Gm-Message-State: AOAM531YEjpLT8Aurm8SG/omQUrJF9S55cVdcIpi449HrAQ1vqC7ABaT Vvi4py5yMvcrPsPxU81Jncez7m52AL9jy2xlGbY= X-Google-Smtp-Source: ABdhPJzATlxh7v3TPVScN/pNQlX1LkPyBHWHSVXqQh9KOM24RerTxuY4NXa4lzjc15K3hgij1fF57C1RZ44OvNYZ4wQ= X-Received: by 2002:a05:6102:2828:: with SMTP id ba8mr11030321vsb.18.1626421118272; Fri, 16 Jul 2021 00:38:38 -0700 (PDT) MIME-Version: 1.0 References: <20210715182123.23372-1-prabhakar.mahadev-lad.rj@bp.renesas.com> <20210715182123.23372-2-prabhakar.mahadev-lad.rj@bp.renesas.com> In-Reply-To: <20210715182123.23372-2-prabhakar.mahadev-lad.rj@bp.renesas.com> From: Geert Uytterhoeven Date: Fri, 16 Jul 2021 09:38:27 +0200 Message-ID: Subject: Re: [PATCH 1/6] dt-bindings: net: can: renesas,rcar-canfd: Document RZ/G2L SoC To: Lad Prabhakar Cc: Rob Herring , Wolfgang Grandegger , Marc Kleine-Budde , "David S. Miller" , Jakub Kicinski , Michael Turquette , Stephen Boyd , Philipp Zabel , linux-can@vger.kernel.org, netdev , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , linux-clk , Linux Kernel Mailing List , Linux-Renesas , Prabhakar , Biju Das Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Prabhakar, On Thu, Jul 15, 2021 at 8:21 PM Lad Prabhakar wrote: > Add CANFD binding documentation for Renesas RZ/G2L SoC. > > Signed-off-by: Lad Prabhakar > Reviewed-by: Biju Das Thanks for your patch! > --- a/Documentation/devicetree/bindings/net/can/renesas,rcar-canfd.yaml > +++ b/Documentation/devicetree/bindings/net/can/renesas,rcar-canfd.yaml > @@ -78,6 +79,38 @@ patternProperties: > node. Each child node supports the "status" property only, which > is used to enable/disable the respective channel. > > +if: > + properties: > + compatible: > + contains: > + enum: > + - renesas,rzg2l-canfd > +then: > + properties: > + interrupts: > + items: > + - description: CAN global error interrupt > + - description: CAN receive FIFO interrupt > + - description: CAN0 error interrupt > + - description: CAN0 transmit interrupt > + - description: CAN0 transmit/receive FIFO receive completion interrupt > + - description: CAN1 error interrupt > + - description: CAN1 transmit interrupt > + - description: CAN1 transmit/receive FIFO receive completion interrupt Does it make sense to add interrupt-names? > + > + resets: > + maxItems: 2 Same here, for reset-names? Or a list of descriptions, so we know which reset serves what purpose. > + > +else: > + properties: > + interrupts: > + items: > + - description: Channel interrupt > + - description: Global interrupt > + > + resets: > + maxItems: 1 > + > required: > - compatible > - reg The rest looks good to me. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds