From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CC12EC83027 for ; Thu, 2 Sep 2021 16:44:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B17FE610E5 for ; Thu, 2 Sep 2021 16:44:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346449AbhIBQpg (ORCPT ); Thu, 2 Sep 2021 12:45:36 -0400 Received: from mail-vk1-f175.google.com ([209.85.221.175]:33380 "EHLO mail-vk1-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242304AbhIBQpe (ORCPT ); Thu, 2 Sep 2021 12:45:34 -0400 Received: by mail-vk1-f175.google.com with SMTP id j5so851338vki.0 for ; Thu, 02 Sep 2021 09:44:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=S8ciweqCSnmF0lrcF+dCm4bYbs7yF6R8RNgWL4GCGc4=; b=ClONLIvrv7snOUZq2GVGNiucW/N2YWqRv+VSTm6rRxv156HTZXPLGvXXjoeYhbavPs pCTW9YaUrwZyeSDMeAmUsZA2k6T4MYAnss/mGGPp3k63qbyTwlPosz1aIAkar2zL1CfZ 68eLbMTvKUmXvi4DEXUGFVovCL19zV5PWtpmmcNIzkoZC65wNOZVA49AlddaoH9jDuEX U8l59xX6AbgbPvkuUhvyYFVZiFyJ7vQ1esNKTaiIUZjHuW/68w5sowu6pBlqCX72OTo1 9tuweA8j+LwlThoCb5elUzgeZEQTHIiOABuQDSn372Z4T2Jtme1gmOu0Z4aaZbnyiNvn sgpA== X-Gm-Message-State: AOAM532p0t8mn9kHvBkDWCVH5I1Ns3lN7A2IZ/yBBSS/1erq9n94qUsR /wnlCHMA86gPU+xaVmIQAv6aFd4cJe1K1ApDlNAlXlxqfzg= X-Google-Smtp-Source: ABdhPJxW6799mxeUzoB48DvT0FXTNwmWHONPl+cHVkxeRwWgBN0xlWUX+n978nIvNloFpd/wE8Q+PSrXa+QzmCwfVeQ= X-Received: by 2002:a1f:fe04:: with SMTP id l4mr2579598vki.9.1630601075662; Thu, 02 Sep 2021 09:44:35 -0700 (PDT) MIME-Version: 1.0 References: <20210707214752.3831-1-rdunlap@infradead.org> <49495ab9-5039-f332-2895-1a79c034f58d@infradead.org> In-Reply-To: <49495ab9-5039-f332-2895-1a79c034f58d@infradead.org> From: Geert Uytterhoeven Date: Thu, 2 Sep 2021 18:44:23 +0200 Message-ID: Subject: Re: [PATCH v3] ASoC: atmel: ATMEL drivers don't need HAS_DMA To: Randy Dunlap Cc: Codrin.Ciubotariu@microchip.com, Linux Kernel Mailing List , ALSA Development Mailing List , Liam Girdwood , Mark Brown , mirq-linux@rere.qmqm.pl, Alexandre Belloni Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Randy, On Thu, Jul 8, 2021 at 6:51 PM Randy Dunlap wrote: > On 7/8/21 1:19 AM, Codrin.Ciubotariu@microchip.com wrote: > > On 08.07.2021 00:47, Randy Dunlap wrote: > >> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe > >> > >> On a config (such as arch/sh/) which does not set HAS_DMA when MMU > >> is not set, several ATMEL ASoC drivers select symbols that cause > >> kconfig warnings. There is one "depends on HAS_DMA" which is no longer > >> needed. Dropping it eliminates the kconfig warnings and still builds > >> with no problems reported. > >> > >> Fix the following kconfig warnings: > >> > >> WARNING: unmet direct dependencies detected for SND_ATMEL_SOC_PDC > >> Depends on [n]: SOUND [=m] && !UML && SND [=m] && SND_SOC [=m] && SND_ATMEL_SOC [=m] && HAS_DMA [=n] > >> Selected by [m]: > >> - SND_ATMEL_SOC_SSC [=m] && SOUND [=m] && !UML && SND [=m] && SND_SOC [=m] && SND_ATMEL_SOC [=m] > >> - SND_ATMEL_SOC_SSC_PDC [=m] && SOUND [=m] && !UML && SND [=m] && SND_SOC [=m] && SND_ATMEL_SOC [=m] && ATMEL_SSC [=m] > >> > >> WARNING: unmet direct dependencies detected for SND_ATMEL_SOC_SSC_PDC > >> Depends on [n]: SOUND [=m] && !UML && SND [=m] && SND_SOC [=m] && SND_ATMEL_SOC [=m] && ATMEL_SSC [=m] && HAS_DMA [=n] > >> Selected by [m]: > >> - SND_AT91_SOC_SAM9G20_WM8731 [=m] && SOUND [=m] && !UML && SND [=m] && SND_SOC [=m] && SND_ATMEL_SOC [=m] && (ARCH_AT91 || COMPILE_TEST [=y]) && ATMEL_SSC [=m] && SND_SOC_I2C_AND_SPI [=m] > >> > >> WARNING: unmet direct dependencies detected for SND_ATMEL_SOC_SSC > >> Depends on [n]: SOUND [=m] && !UML && SND [=m] && SND_SOC [=m] && SND_ATMEL_SOC [=m] && HAS_DMA [=n] > >> Selected by [m]: > >> - SND_ATMEL_SOC_SSC_DMA [=m] && SOUND [=m] && !UML && SND [=m] && SND_SOC [=m] && SND_ATMEL_SOC [=m] && ATMEL_SSC [=m] > >> > >> WARNING: unmet direct dependencies detected for SND_ATMEL_SOC_SSC_DMA > >> Depends on [n]: SOUND [=m] && !UML && SND [=m] && SND_SOC [=m] && SND_ATMEL_SOC [=m] && ATMEL_SSC [=m] && HAS_DMA [=n] > >> Selected by [m]: > >> - SND_ATMEL_SOC_WM8904 [=m] && SOUND [=m] && !UML && SND [=m] && SND_SOC [=m] && SND_ATMEL_SOC [=m] && (ARCH_AT91 || COMPILE_TEST [=y]) && ATMEL_SSC [=m] && I2C [=m] > >> - SND_AT91_SOC_SAM9X5_WM8731 [=m] && SOUND [=m] && !UML && SND [=m] && SND_SOC [=m] && SND_ATMEL_SOC [=m] && (ARCH_AT91 || COMPILE_TEST [=y]) && ATMEL_SSC [=m] && SND_SOC_I2C_AND_SPI [=m] > >> > >> Fixes: 3951e4aae2ce ("ASoC: atmel-pcm: dma support based on pcm dmaengine") > >> Fixes: 18291410557f ("ASoC: atmel: enable SOC_SSC_PDC and SOC_SSC_DMA in Kconfig") > >> Fixes: 061981ff8cc8 ("ASoC: atmel: properly select dma driver state") > > > > I am not sure about these fixes tags. As Alexandre mentioned, it looks > > like the reason for HAS_DMA in the first place was the COMPILE_TEST with > > m32r arch. I dig a bit, and, if any, I think we should use: > > Fixes: eb17726b00b3 ("m32r: add simple dma") > > since this commit adds dummy DMA support for m32r and seems to fix the > > HAS_DMA dependency. > > Ah, I forgot to update the Fixes: tag(s). > > I won't disagree with your Fixes: suggestion (good digging) but > I would probably have used 8d7d11005e930: > ASoC: atmel: fix build failure > which is the commit that added "depends on HAS_DMA". M32r was not the only platform NO_DMA, so I guess the build would have failed for the others, too (e.g. Sun-3). So the real fix was probably commit f29ab49b5388b2f8 ("dma-mapping: Convert NO_DMA get_dma_ops() into a real dummy"), or one of the related commits adding dummies to subsystems. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds