From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752053AbdKMI4h (ORCPT ); Mon, 13 Nov 2017 03:56:37 -0500 Received: from mail-qt0-f194.google.com ([209.85.216.194]:49794 "EHLO mail-qt0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751585AbdKMI4g (ORCPT ); Mon, 13 Nov 2017 03:56:36 -0500 X-Google-Smtp-Source: AGs4zMapDMyuv0ziGnpLZWe8dydUCQR46vT2qzP1mQcmWLdILQiELOaH6HN6kvGQg5PmNyk7fMExwofPOkas1MplAPA= MIME-Version: 1.0 In-Reply-To: <51c5a1526bbf522bbb76d6a71040c220e7e72a8a.1510377369.git.fthain@telegraphics.com.au> References: <51c5a1526bbf522bbb76d6a71040c220e7e72a8a.1510377369.git.fthain@telegraphics.com.au> From: Geert Uytterhoeven Date: Mon, 13 Nov 2017 09:56:35 +0100 X-Google-Sender-Auth: eD4tOJtqMR-3daNsupFOiZmbTYs Message-ID: Subject: Re: [PATCH 11/14] nubus: Repopulate /proc/bus/nubus/s/ To: Finn Thain Cc: "Linux/m68k" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Finn, On Sat, Nov 11, 2017 at 7:12 AM, Finn Thain wrote: > Create the /proc/bus/nubus/s/ inodes while scanning slot s. During > descent through slot resource subdirectories, call the new > nubus_proc_add_foo() functions to create the procfs inodes. > > Also add a new function, nubus_seq_write_rsrc_mem(), to write the > contents of a particular slot resource to a given seq_file. This is > used by the procfs file_operations methods, to finally give userspace > access to slot ROM information, such as the available video modes. > > Tested-by: Stan Johnson > Signed-off-by: Finn Thain Thanks for your patch! > --- > drivers/nubus/nubus.c | 117 +++++++++++++++++++++++++++------- > drivers/nubus/proc.c | 170 +++++++++++++++++++++++++++++++++++++++++++++++--- > include/linux/nubus.h | 35 ++++++++++- > 3 files changed, 288 insertions(+), 34 deletions(-) Wow, that's much more code added than was removed by "[PATCH 10/14] nubus: Depopulate /proc/bus/nubus/s/": drivers/nubus/proc.c | 100 -------------------------------------------------- include/linux/nubus.h | 1 - 2 files changed, 101 deletions(-) How much memory is saved by not using the stored representation of slot resource data? BTW, should 10 and 11 be combined, to avoid a regression during bisection? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds