linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	David Daney <david.daney@cavium.com>
Subject: Re: Build regressions/improvements in v5.4-rc2
Date: Tue, 8 Oct 2019 09:28:33 +0200	[thread overview]
Message-ID: <CAMuHMdUERaoHLNKi03zCuYi7NevgBFjXrV=pt0Yy=HOeRiL25Q@mail.gmail.com> (raw)
In-Reply-To: <4ce1ecd0-4b90-f4f6-936b-ae2d756b08d5@infradead.org>

Hi Randy,

On Tue, Oct 8, 2019 at 1:41 AM Randy Dunlap <rdunlap@infradead.org> wrote:
> On 10/7/19 2:04 PM, Geert Uytterhoeven wrote:
> > On Mon, Oct 7, 2019 at 10:48 PM Randy Dunlap <rdunlap@infradead.org> wrote:
> >> On 10/7/19 12:18 AM, Geert Uytterhoeven wrote:
> >>> Below is the list of build error/warning regressions/improvements in
> >>> v5.4-rc2[1] compared to v5.3[2].
> >>>
> >>> Summarized:
> >>>   - build errors: +10/-3
> >>>   - build warnings: +152/-143
> >>>
> >>> JFYI, when comparing v5.4-rc2[1] to v5.4-rc1[3], the summaries are:
> >>>   - build errors: +5/-10
> >>>   - build warnings: +44/-133
> >>>
> >>> Note that there may be false regressions, as some logs are incomplete.
> >>> Still, they're build errors/warnings.
> >>>
> >>> Happy fixing! ;-)
> >>>
> >>> Thanks to the linux-next team for providing the build service.
> >>>
> >>> [1] http://kisskb.ellerman.id.au/kisskb/branch/linus/head/da0c9ea146cbe92b832f1b0f694840ea8eb33cce/ (233 out of 242 configs)
> >>> [2] http://kisskb.ellerman.id.au/kisskb/branch/linus/head/4d856f72c10ecb060868ed10ff1b1453943fc6c8/ (all 242 configs)
> >>> [3] http://kisskb.ellerman.id.au/kisskb/branch/linus/head/54ecb8f7028c5eb3d740bb82b0f1d90f2df63c5c/ (233 out of 242 configs)
> >>>
> >>>
> >>> *** ERRORS ***
> >>>
> >>> 10 error regressions:
> >>
> >>>   + error: "__delay" [drivers/net/phy/mdio-cavium.ko] undefined!:  => N/A
> >>
> >> Hi Geert,
> >>
> >> What arch & config is the above build error from?
> >
> > That was a new one in v5.4-rc1 for sh-allmodconfig (blamed on David Daney).
>
> so it seems arch/sh/ needs include/asm/delay.h that at least does
> #include <asm-generic/delay.h>
>
> eh?

__delay() is an internal implementation detail on several architectures.

include/asm-generic/delay.h says:

    /* Undefined functions to get compile-time errors */
    ...
    extern void __delay(unsigned long loops);

drivers/net/phy/mdio-cavium.c calls __delay() directly to wait n "clocks",
which is not portable.  It should use one of [nmu]delay() instead.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

      reply	other threads:[~2019-10-08  7:28 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-07  7:18 Build regressions/improvements in v5.4-rc2 Geert Uytterhoeven
2019-10-07  7:33 ` Geert Uytterhoeven
2019-10-07 20:48 ` Randy Dunlap
2019-10-07 21:04   ` Geert Uytterhoeven
2019-10-07 23:41     ` Randy Dunlap
2019-10-08  7:28       ` Geert Uytterhoeven [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAMuHMdUERaoHLNKi03zCuYi7NevgBFjXrV=pt0Yy=HOeRiL25Q@mail.gmail.com' \
    --to=geert@linux-m68k.org \
    --cc=david.daney@cavium.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rdunlap@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).