* [PATCH] devicetree: property-units: Add kohms unit
@ 2019-09-17 7:58 Biwen Li
2019-09-17 8:19 ` Geert Uytterhoeven
0 siblings, 1 reply; 4+ messages in thread
From: Biwen Li @ 2019-09-17 7:58 UTC (permalink / raw)
To: robh+dt, mark.rutland, geert+renesas, alexandre.belloni, sam
Cc: devicetree, linux-kernel, Biwen Li
The patch adds kohms unit
Signed-off-by: Biwen Li <biwen.li@nxp.com>
---
Documentation/devicetree/bindings/property-units.txt | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/property-units.txt b/Documentation/devicetree/bindings/property-units.txt
index e9b8360b3288..97feb8995d1f 100644
--- a/Documentation/devicetree/bindings/property-units.txt
+++ b/Documentation/devicetree/bindings/property-units.txt
@@ -27,6 +27,7 @@ Electricity
-microamp : microampere
-microamp-hours : microampere hour
-ohms : ohm
+-kohms : kiloohm
-micro-ohms : microohm
-microwatt-hours: microwatt hour
-microvolt : microvolt
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] devicetree: property-units: Add kohms unit
2019-09-17 7:58 [PATCH] devicetree: property-units: Add kohms unit Biwen Li
@ 2019-09-17 8:19 ` Geert Uytterhoeven
2019-09-17 8:25 ` [EXT] " Biwen Li
0 siblings, 1 reply; 4+ messages in thread
From: Geert Uytterhoeven @ 2019-09-17 8:19 UTC (permalink / raw)
To: Biwen Li
Cc: Rob Herring, Mark Rutland, Geert Uytterhoeven, Alexandre Belloni,
Sam Ravnborg,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
Linux Kernel Mailing List
Hi Biwen,
On Tue, Sep 17, 2019 at 10:09 AM Biwen Li <biwen.li@nxp.com> wrote:
> The patch adds kohms unit
>
> Signed-off-by: Biwen Li <biwen.li@nxp.com>
Thanks for your patch!
> --- a/Documentation/devicetree/bindings/property-units.txt
> +++ b/Documentation/devicetree/bindings/property-units.txt
> @@ -27,6 +27,7 @@ Electricity
> -microamp : microampere
> -microamp-hours : microampere hour
> -ohms : ohm
> +-kohms : kiloohm
> -micro-ohms : microohm
> -microwatt-hours: microwatt hour
> -microvolt : microvolt
What's your rationale for adding "kohms"?
Do you need to specify resistance values that do not fit in 32-bit, and
thus cannot be specified using "ohms"?
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: [EXT] Re: [PATCH] devicetree: property-units: Add kohms unit
2019-09-17 8:19 ` Geert Uytterhoeven
@ 2019-09-17 8:25 ` Biwen Li
2019-09-30 22:48 ` Rob Herring
0 siblings, 1 reply; 4+ messages in thread
From: Biwen Li @ 2019-09-17 8:25 UTC (permalink / raw)
To: 'Geert Uytterhoeven'
Cc: Rob Herring, Mark Rutland, Geert Uytterhoeven, Alexandre Belloni,
Sam Ravnborg,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
Linux Kernel Mailing List
>
> Caution: EXT Email
>
> Hi Biwen,
>
> On Tue, Sep 17, 2019 at 10:09 AM Biwen Li <biwen.li@nxp.com> wrote:
> > The patch adds kohms unit
> >
> > Signed-off-by: Biwen Li <biwen.li@nxp.com>
>
> Thanks for your patch!
>
> > --- a/Documentation/devicetree/bindings/property-units.txt
> > +++ b/Documentation/devicetree/bindings/property-units.txt
> > @@ -27,6 +27,7 @@ Electricity
> > -microamp : microampere
> > -microamp-hours : microampere hour
> > -ohms : ohm
> > +-kohms : kiloohm
> > -micro-ohms : microohm
> > -microwatt-hours: microwatt hour
> > -microvolt : microvolt
>
> What's your rationale for adding "kohms"?
> Do you need to specify resistance values that do not fit in 32-bit, and thus
32-bit is enough, I have three values, 60 kohm, 100 kohm and 500 kohm
> cannot be specified using "ohms"?
If replace with ohms, the value is as follows:
60000 ohm, 100000 ohm, 500000 ohm.
It's so long for everyone.
>
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 --
> geert@linux-m68k.org
>
> In personal conversations with technical people, I call myself a hacker. But when
> I'm talking to journalists I just say "programmer" or something like that.
> -- Linus Torvalds
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [EXT] Re: [PATCH] devicetree: property-units: Add kohms unit
2019-09-17 8:25 ` [EXT] " Biwen Li
@ 2019-09-30 22:48 ` Rob Herring
0 siblings, 0 replies; 4+ messages in thread
From: Rob Herring @ 2019-09-30 22:48 UTC (permalink / raw)
To: Biwen Li
Cc: 'Geert Uytterhoeven',
Mark Rutland, Geert Uytterhoeven, Alexandre Belloni,
Sam Ravnborg,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
Linux Kernel Mailing List
On Tue, Sep 17, 2019 at 08:25:55AM +0000, Biwen Li wrote:
> >
> > Caution: EXT Email
> >
> > Hi Biwen,
> >
> > On Tue, Sep 17, 2019 at 10:09 AM Biwen Li <biwen.li@nxp.com> wrote:
> > > The patch adds kohms unit
> > >
> > > Signed-off-by: Biwen Li <biwen.li@nxp.com>
> >
> > Thanks for your patch!
> >
> > > --- a/Documentation/devicetree/bindings/property-units.txt
> > > +++ b/Documentation/devicetree/bindings/property-units.txt
> > > @@ -27,6 +27,7 @@ Electricity
> > > -microamp : microampere
> > > -microamp-hours : microampere hour
> > > -ohms : ohm
> > > +-kohms : kiloohm
> > > -micro-ohms : microohm
> > > -microwatt-hours: microwatt hour
> > > -microvolt : microvolt
> >
> > What's your rationale for adding "kohms"?
> > Do you need to specify resistance values that do not fit in 32-bit, and thus
> 32-bit is enough, I have three values, 60 kohm, 100 kohm and 500 kohm
> > cannot be specified using "ohms"?
> If replace with ohms, the value is as follows:
> 60000 ohm, 100000 ohm, 500000 ohm.
> It's so long for everyone.
It's not any longer, it's still 32-bits.
Please stick with '-ohms'.
Rob
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-09-30 22:48 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-17 7:58 [PATCH] devicetree: property-units: Add kohms unit Biwen Li
2019-09-17 8:19 ` Geert Uytterhoeven
2019-09-17 8:25 ` [EXT] " Biwen Li
2019-09-30 22:48 ` Rob Herring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).