From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Vladimir Zapolskiy <vz@mleia.com>,
Sylvain Lemieux <slemieux.tyco@gmail.com>,
Linus Walleij <linus.walleij@linaro.org>,
Wolfram Sang <wsa@the-dreams.de>, Jean Delvare <jdelvare@suse.de>,
Jarkko Nikula <jarkko.nikula@linux.intel.com>,
Max Staudt <max@enpas.org>,
Juergen Fitschen <jfi@ssv-embedded.de>,
Elie Morisse <syniurge@gmail.com>,
Linux I2C <linux-i2c@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux ARM <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 5/5] i2c: Enable compile testing for some of drivers
Date: Mon, 30 Dec 2019 20:11:03 +0100 [thread overview]
Message-ID: <CAMuHMdUXJo3=x32xbfSUXs3O3JHaFpfxt0mHupEb+vzi=5+S4g@mail.gmail.com> (raw)
In-Reply-To: <20191230172751.17985-5-krzk@kernel.org>
Hi Krzysztof,
On Mon, Dec 30, 2019 at 6:28 PM Krzysztof Kozlowski <krzk@kernel.org> wrote:
> Some of the I2C bus drivers can be compile tested to increase build
> coverage. This requires also:
> 1. Adding dependencies on COMMON_CLK for BCM2835 and Meson I2C
> controllers,
> 2. Adding 'if' conditional to 'default y' so they will not get enabled
> by default on all other architectures,
> 3. Limiting few compile test options to supported architectures (which
> provide the readsX()/writesX() primitives).
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Thanks for your patch!
> --- a/drivers/i2c/busses/Kconfig
> +++ b/drivers/i2c/busses/Kconfig
> @@ -367,7 +367,7 @@ comment "I2C system bus drivers (mostly embedded / system-on-chip)"
>
> config I2C_ALTERA
> tristate "Altera Soft IP I2C"
> - depends on (ARCH_SOCFPGA || NIOS2) && OF
> + depends on (ARCH_SOCFPGA || NIOS2 || COMPILE_TEST) && OF
Might be easier to read and maintain by splitting in "hard" and "useful"
dependencies:
depends on OF
depends on ARCH_SOCFPGA || NIOS2 || COMPILE_TEST
> @@ -611,8 +612,8 @@ config I2C_EMEV2
>
> config I2C_EXYNOS5
> tristate "Exynos5 high-speed I2C driver"
> - depends on ARCH_EXYNOS && OF
> - default y
> + depends on (ARCH_EXYNOS && OF) || COMPILE_TEST
This means it is only useful on DT-based Exynos platforms, but compiles
everywhere?
Do you still have support for non-DT Exynos platforms?
ARCH_EXYNOS depends on ARCH_MULTI_V7?
(and its help text mentions Exynos 4/5 only, no 3?)
> @@ -1055,15 +1057,15 @@ config I2C_SYNQUACER
>
> config I2C_TEGRA
> tristate "NVIDIA Tegra internal I2C controller"
> - depends on ARCH_TEGRA
> + depends on ARCH_TEGRA || (COMPILE_TEST && (ARC || ARM || ARM64 || M68K || RISCV || SUPERH || SPARC))
Perhaps
depends on ARCH_TEGRA || COMPILE_TEST
depends on ARC || ARM || ARM64 || M68K || RISCV || SUPERH || SPARC
# needs <foo>
to remember which <foo> feature is needed?
> @@ -1403,8 +1405,8 @@ config I2C_OPAL
>
> config I2C_ZX2967
> tristate "ZTE ZX2967 I2C support"
> - depends on ARCH_ZX
> - default y
> + depends on ARCH_ZX || (COMPILE_TEST && (ARC || ARM || ARM64 || M68K || RISCV || SUPERH || SPARC))
Same here/
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
next prev parent reply other threads:[~2019-12-30 19:11 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-30 17:27 [PATCH 1/5] i2c: pmcmsp: Use proper printk format for resource_size_t Krzysztof Kozlowski
2019-12-30 17:27 ` [PATCH 2/5] i2c: pnx: " Krzysztof Kozlowski
2019-12-30 17:27 ` [PATCH 3/5] i2c: highlander: Use proper printk format for iomem pointer Krzysztof Kozlowski
2020-01-07 15:08 ` Luca Ceresoli
2019-12-30 17:27 ` [PATCH 4/5] i2c: stu300: " Krzysztof Kozlowski
2020-01-07 10:36 ` Linus Walleij
2019-12-30 17:27 ` [PATCH 5/5] i2c: Enable compile testing for some of drivers Krzysztof Kozlowski
2019-12-30 19:11 ` Geert Uytterhoeven [this message]
2019-12-31 9:01 ` Krzysztof Kozlowski
2019-12-31 9:20 ` Geert Uytterhoeven
2020-01-03 13:42 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMuHMdUXJo3=x32xbfSUXs3O3JHaFpfxt0mHupEb+vzi=5+S4g@mail.gmail.com' \
--to=geert@linux-m68k.org \
--cc=jarkko.nikula@linux.intel.com \
--cc=jdelvare@suse.de \
--cc=jfi@ssv-embedded.de \
--cc=krzk@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=max@enpas.org \
--cc=slemieux.tyco@gmail.com \
--cc=syniurge@gmail.com \
--cc=vz@mleia.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).