From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752250AbcAFIqC (ORCPT ); Wed, 6 Jan 2016 03:46:02 -0500 Received: from mail-ig0-f182.google.com ([209.85.213.182]:38361 "EHLO mail-ig0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752172AbcAFIpr (ORCPT ); Wed, 6 Jan 2016 03:45:47 -0500 MIME-Version: 1.0 In-Reply-To: <20160106083500.GB1525@katana> References: <1451998831-27705-1-git-send-email-phil.edworthy@renesas.com> <1451998831-27705-4-git-send-email-phil.edworthy@renesas.com> <20160106083500.GB1525@katana> Date: Wed, 6 Jan 2016 09:45:46 +0100 X-Google-Sender-Auth: Y4m9e-E47ER-0rhBqMHh44Oz3EQ Message-ID: Subject: Re: [PATCH v2 3/4] PCI: rcar: Add runtime PM support to pcie-rcar From: Geert Uytterhoeven To: Wolfram Sang Cc: Phil Edworthy , Simon Horman , Bjorn Helgaas , "linux-kernel@vger.kernel.org" , linux-pci , Linux-sh list Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Wolfram, On Wed, Jan 6, 2016 at 9:35 AM, Wolfram Sang wrote: >> +err_pm_put: >> + pm_runtime_put(pcie->dev); >> + >> +err_pm_disable: >> + pm_runtime_disable(pcie->dev); > > What about put/disable in the remove part? Which remove part? (been there, done that ;-) Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds